## Description We decided to remove middlewares, and revert to antehandlers (exactly like in v045) for this release. A better middleware solution will be implemented after v046. ref: #11955 Because this refactor is big, so I decided to cut it into two. This PR is part 1 of 2: - part 1: Revert baseapp and middlewares to v0.45.4 - part 2: Add posthandler, tips, priority --- Suggestion for reviewers: This PR might still be hard to review though. I think it's easier to actually review the diff between v0.45.4 and this PR: - `git difftool -d v0.45.4..am/revert-045-baseapp baseapp` - most important parts to review: runTx, runMsgs - `git difftool -d v0.45.4..am/revert-045-baseapp x/auth/ante` - only cosmetic changes - `git difftool -d v0.45.4..am/revert-045-baseapp simapp` --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
168 lines
4.4 KiB
Go
168 lines
4.4 KiB
Go
package baseapp
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
|
|
tmprototypes "github.com/tendermint/tendermint/proto/tendermint/types"
|
|
dbm "github.com/tendermint/tm-db"
|
|
|
|
pruningtypes "github.com/cosmos/cosmos-sdk/pruning/types"
|
|
"github.com/cosmos/cosmos-sdk/snapshots"
|
|
snapshottypes "github.com/cosmos/cosmos-sdk/snapshots/types"
|
|
"github.com/cosmos/cosmos-sdk/testutil"
|
|
)
|
|
|
|
func TestGetBlockRentionHeight(t *testing.T) {
|
|
logger := defaultLogger()
|
|
db := dbm.NewMemDB()
|
|
name := t.Name()
|
|
|
|
snapshotStore, err := snapshots.NewStore(dbm.NewMemDB(), testutil.GetTempDir(t))
|
|
require.NoError(t, err)
|
|
|
|
testCases := map[string]struct {
|
|
bapp *BaseApp
|
|
maxAgeBlocks int64
|
|
commitHeight int64
|
|
expected int64
|
|
}{
|
|
"defaults": {
|
|
bapp: NewBaseApp(name, logger, db, nil),
|
|
maxAgeBlocks: 0,
|
|
commitHeight: 499000,
|
|
expected: 0,
|
|
},
|
|
"pruning unbonding time only": {
|
|
bapp: NewBaseApp(name, logger, db, nil, SetMinRetainBlocks(1)),
|
|
maxAgeBlocks: 362880,
|
|
commitHeight: 499000,
|
|
expected: 136120,
|
|
},
|
|
"pruning iavl snapshot only": {
|
|
bapp: NewBaseApp(
|
|
name, logger, db, nil,
|
|
SetPruning(pruningtypes.NewPruningOptions(pruningtypes.PruningNothing)),
|
|
SetMinRetainBlocks(1),
|
|
SetSnapshot(snapshotStore, snapshottypes.NewSnapshotOptions(10000, 1)),
|
|
),
|
|
maxAgeBlocks: 0,
|
|
commitHeight: 499000,
|
|
expected: 489000,
|
|
},
|
|
"pruning state sync snapshot only": {
|
|
bapp: NewBaseApp(
|
|
name, logger, db, nil,
|
|
SetSnapshot(snapshotStore, snapshottypes.NewSnapshotOptions(50000, 3)),
|
|
SetMinRetainBlocks(1),
|
|
),
|
|
maxAgeBlocks: 0,
|
|
commitHeight: 499000,
|
|
expected: 349000,
|
|
},
|
|
"pruning min retention only": {
|
|
bapp: NewBaseApp(
|
|
name, logger, db, nil,
|
|
SetMinRetainBlocks(400000),
|
|
),
|
|
maxAgeBlocks: 0,
|
|
commitHeight: 499000,
|
|
expected: 99000,
|
|
},
|
|
"pruning all conditions": {
|
|
bapp: NewBaseApp(
|
|
name, logger, db, nil,
|
|
SetPruning(pruningtypes.NewCustomPruningOptions(0, 0)),
|
|
SetMinRetainBlocks(400000),
|
|
SetSnapshot(snapshotStore, snapshottypes.NewSnapshotOptions(50000, 3)),
|
|
),
|
|
maxAgeBlocks: 362880,
|
|
commitHeight: 499000,
|
|
expected: 99000,
|
|
},
|
|
"no pruning due to no persisted state": {
|
|
bapp: NewBaseApp(
|
|
name, logger, db, nil,
|
|
SetPruning(pruningtypes.NewCustomPruningOptions(0, 0)),
|
|
SetMinRetainBlocks(400000),
|
|
SetSnapshot(snapshotStore, snapshottypes.NewSnapshotOptions(50000, 3)),
|
|
),
|
|
maxAgeBlocks: 362880,
|
|
commitHeight: 10000,
|
|
expected: 0,
|
|
},
|
|
"disable pruning": {
|
|
bapp: NewBaseApp(
|
|
name, logger, db, nil,
|
|
SetPruning(pruningtypes.NewCustomPruningOptions(0, 0)),
|
|
SetMinRetainBlocks(0),
|
|
SetSnapshot(snapshotStore, snapshottypes.NewSnapshotOptions(50000, 3)),
|
|
),
|
|
maxAgeBlocks: 362880,
|
|
commitHeight: 499000,
|
|
expected: 0,
|
|
},
|
|
}
|
|
|
|
for name, tc := range testCases {
|
|
tc := tc
|
|
|
|
tc.bapp.SetParamStore(¶mStore{db: dbm.NewMemDB()})
|
|
tc.bapp.InitChain(abci.RequestInitChain{
|
|
ConsensusParams: &tmprototypes.ConsensusParams{
|
|
Evidence: &tmprototypes.EvidenceParams{
|
|
MaxAgeNumBlocks: tc.maxAgeBlocks,
|
|
},
|
|
},
|
|
})
|
|
|
|
t.Run(name, func(t *testing.T) {
|
|
require.Equal(t, tc.expected, tc.bapp.GetBlockRetentionHeight(tc.commitHeight))
|
|
})
|
|
}
|
|
}
|
|
|
|
// Test and ensure that invalid block heights always cause errors.
|
|
// See issues:
|
|
// - https://github.com/cosmos/cosmos-sdk/issues/11220
|
|
// - https://github.com/cosmos/cosmos-sdk/issues/7662
|
|
func TestBaseAppCreateQueryContext(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
logger := defaultLogger()
|
|
db := dbm.NewMemDB()
|
|
name := t.Name()
|
|
app := NewBaseApp(name, logger, db, nil)
|
|
|
|
app.BeginBlock(abci.RequestBeginBlock{Header: tmproto.Header{Height: 1}})
|
|
app.Commit()
|
|
|
|
app.BeginBlock(abci.RequestBeginBlock{Header: tmproto.Header{Height: 2}})
|
|
app.Commit()
|
|
|
|
testCases := []struct {
|
|
name string
|
|
height int64
|
|
prove bool
|
|
expErr bool
|
|
}{
|
|
{"valid height", 2, true, false},
|
|
{"future height", 10, true, true},
|
|
{"negative height, prove=true", -1, true, true},
|
|
{"negative height, prove=false", -1, false, true},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
_, err := app.createQueryContext(tc.height, tc.prove)
|
|
if tc.expErr {
|
|
require.Error(t, err)
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|