01832e6239
## Description We decided to remove middlewares, and revert to antehandlers (exactly like in v045) for this release. A better middleware solution will be implemented after v046. ref: #11955 Because this refactor is big, so I decided to cut it into two. This PR is part 1 of 2: - part 1: Revert baseapp and middlewares to v0.45.4 - part 2: Add posthandler, tips, priority --- Suggestion for reviewers: This PR might still be hard to review though. I think it's easier to actually review the diff between v0.45.4 and this PR: - `git difftool -d v0.45.4..am/revert-045-baseapp baseapp` - most important parts to review: runTx, runMsgs - `git difftool -d v0.45.4..am/revert-045-baseapp x/auth/ante` - only cosmetic changes - `git difftool -d v0.45.4..am/revert-045-baseapp simapp` --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
101 lines
2.7 KiB
Go
101 lines
2.7 KiB
Go
package streaming_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/cosmos/cosmos-sdk/baseapp"
|
|
"github.com/cosmos/cosmos-sdk/codec"
|
|
codecTypes "github.com/cosmos/cosmos-sdk/codec/types"
|
|
serverTypes "github.com/cosmos/cosmos-sdk/server/types"
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
"github.com/cosmos/cosmos-sdk/store/streaming"
|
|
"github.com/cosmos/cosmos-sdk/store/streaming/file"
|
|
"github.com/cosmos/cosmos-sdk/store/types"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
"github.com/tendermint/tendermint/libs/log"
|
|
dbm "github.com/tendermint/tm-db"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type fakeOptions struct{}
|
|
|
|
func (f *fakeOptions) Get(string) interface{} { return nil }
|
|
|
|
var (
|
|
mockOptions = new(fakeOptions)
|
|
mockKeys = []types.StoreKey{sdk.NewKVStoreKey("mockKey1"), sdk.NewKVStoreKey("mockKey2")}
|
|
interfaceRegistry = codecTypes.NewInterfaceRegistry()
|
|
testMarshaller = codec.NewProtoCodec(interfaceRegistry)
|
|
)
|
|
|
|
func TestStreamingServiceConstructor(t *testing.T) {
|
|
_, err := streaming.NewServiceConstructor("unexpectedName")
|
|
require.NotNil(t, err)
|
|
|
|
constructor, err := streaming.NewServiceConstructor("file")
|
|
require.Nil(t, err)
|
|
var expectedType streaming.ServiceConstructor
|
|
require.IsType(t, expectedType, constructor)
|
|
|
|
serv, err := constructor(mockOptions, mockKeys, testMarshaller)
|
|
require.Nil(t, err)
|
|
require.IsType(t, &file.StreamingService{}, serv)
|
|
listeners := serv.Listeners()
|
|
for _, key := range mockKeys {
|
|
_, ok := listeners[key]
|
|
require.True(t, ok)
|
|
}
|
|
}
|
|
|
|
func TestLoadStreamingServices(t *testing.T) {
|
|
db := dbm.NewMemDB()
|
|
encCdc := simapp.MakeTestEncodingConfig()
|
|
keys := sdk.NewKVStoreKeys("mockKey1", "mockKey2")
|
|
bApp := baseapp.NewBaseApp("appName", log.NewNopLogger(), db, nil)
|
|
|
|
testCases := map[string]struct {
|
|
appOpts serverTypes.AppOptions
|
|
activeStreamersLen int
|
|
}{
|
|
"empty app options": {
|
|
appOpts: simapp.EmptyAppOptions{},
|
|
},
|
|
"all StoreKeys exposed": {
|
|
appOpts: streamingAppOptions{keys: []string{"*"}},
|
|
activeStreamersLen: 1,
|
|
},
|
|
"some StoreKey exposed": {
|
|
appOpts: streamingAppOptions{keys: []string{"mockKey1"}},
|
|
activeStreamersLen: 1,
|
|
},
|
|
"not exposing anything": {
|
|
appOpts: streamingAppOptions{keys: []string{"mockKey3"}},
|
|
},
|
|
}
|
|
|
|
for name, tc := range testCases {
|
|
t.Run(name, func(t *testing.T) {
|
|
activeStreamers, _, err := streaming.LoadStreamingServices(bApp, tc.appOpts, encCdc.Codec, keys)
|
|
require.NoError(t, err)
|
|
require.Equal(t, tc.activeStreamersLen, len(activeStreamers))
|
|
})
|
|
}
|
|
|
|
}
|
|
|
|
type streamingAppOptions struct {
|
|
keys []string
|
|
}
|
|
|
|
func (ao streamingAppOptions) Get(o string) interface{} {
|
|
switch o {
|
|
case "store.streamers":
|
|
return []string{"file"}
|
|
case "streamers.file.keys":
|
|
return ao.keys
|
|
default:
|
|
return nil
|
|
}
|
|
}
|