## Description Most modules right now have a no-op for AppModule.BeginBlock and AppModule.EndBlock. We should move these methods off the AppModule interface so we have less deadcode, and instead move them to extension interfaces. 1. I added `BeginBlockAppModule` and `EndBlockAppModule` interface. 2. Remove the dead-code from modules that do no implement them 3. Add type casting in the the module code to use the new interface Closes: #12462 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
334 lines
11 KiB
Go
334 lines
11 KiB
Go
package gov
|
|
|
|
// DONTCOVER
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"math/rand"
|
|
"sort"
|
|
|
|
gwruntime "github.com/grpc-ecosystem/grpc-gateway/runtime"
|
|
"github.com/spf13/cobra"
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
"golang.org/x/exp/maps"
|
|
"golang.org/x/exp/slices"
|
|
|
|
modulev1 "cosmossdk.io/api/cosmos/gov/module/v1"
|
|
"cosmossdk.io/core/appmodule"
|
|
"cosmossdk.io/depinject"
|
|
"github.com/cosmos/cosmos-sdk/baseapp"
|
|
"github.com/cosmos/cosmos-sdk/client"
|
|
"github.com/cosmos/cosmos-sdk/codec"
|
|
codectypes "github.com/cosmos/cosmos-sdk/codec/types"
|
|
"github.com/cosmos/cosmos-sdk/runtime"
|
|
store "github.com/cosmos/cosmos-sdk/store/types"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
"github.com/cosmos/cosmos-sdk/types/module"
|
|
simtypes "github.com/cosmos/cosmos-sdk/types/simulation"
|
|
govclient "github.com/cosmos/cosmos-sdk/x/gov/client"
|
|
"github.com/cosmos/cosmos-sdk/x/gov/client/cli"
|
|
"github.com/cosmos/cosmos-sdk/x/gov/keeper"
|
|
"github.com/cosmos/cosmos-sdk/x/gov/simulation"
|
|
"github.com/cosmos/cosmos-sdk/x/gov/types"
|
|
v1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
|
|
"github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
|
|
paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
|
|
)
|
|
|
|
var (
|
|
_ module.AppModule = AppModule{}
|
|
_ module.AppModuleBasic = AppModuleBasic{}
|
|
_ module.AppModuleSimulation = AppModule{}
|
|
)
|
|
|
|
// AppModuleBasic defines the basic application module used by the gov module.
|
|
type AppModuleBasic struct {
|
|
cdc codec.Codec
|
|
legacyProposalHandlers []govclient.ProposalHandler // legacy proposal handlers which live in governance cli and rest
|
|
}
|
|
|
|
// NewAppModuleBasic creates a new AppModuleBasic object
|
|
func NewAppModuleBasic(legacyProposalHandlers []govclient.ProposalHandler) AppModuleBasic {
|
|
return AppModuleBasic{
|
|
legacyProposalHandlers: legacyProposalHandlers,
|
|
}
|
|
}
|
|
|
|
// Name returns the gov module's name.
|
|
func (AppModuleBasic) Name() string {
|
|
return types.ModuleName
|
|
}
|
|
|
|
// RegisterLegacyAminoCodec registers the gov module's types for the given codec.
|
|
func (AppModuleBasic) RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
|
|
v1beta1.RegisterLegacyAminoCodec(cdc)
|
|
v1.RegisterLegacyAminoCodec(cdc)
|
|
}
|
|
|
|
// DefaultGenesis returns default genesis state as raw bytes for the gov
|
|
// module.
|
|
func (AppModuleBasic) DefaultGenesis(cdc codec.JSONCodec) json.RawMessage {
|
|
return cdc.MustMarshalJSON(v1.DefaultGenesisState())
|
|
}
|
|
|
|
// ValidateGenesis performs genesis state validation for the gov module.
|
|
func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, config client.TxEncodingConfig, bz json.RawMessage) error {
|
|
var data v1.GenesisState
|
|
if err := cdc.UnmarshalJSON(bz, &data); err != nil {
|
|
return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err)
|
|
}
|
|
|
|
return v1.ValidateGenesis(&data)
|
|
}
|
|
|
|
// RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the gov module.
|
|
func (a AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *gwruntime.ServeMux) {
|
|
if err := v1.RegisterQueryHandlerClient(context.Background(), mux, v1.NewQueryClient(clientCtx)); err != nil {
|
|
panic(err)
|
|
}
|
|
if err := v1beta1.RegisterQueryHandlerClient(context.Background(), mux, v1beta1.NewQueryClient(clientCtx)); err != nil {
|
|
panic(err)
|
|
}
|
|
}
|
|
|
|
// GetTxCmd returns the root tx command for the gov module.
|
|
func (a AppModuleBasic) GetTxCmd() *cobra.Command {
|
|
legacyProposalCLIHandlers := getProposalCLIHandlers(a.legacyProposalHandlers)
|
|
|
|
return cli.NewTxCmd(legacyProposalCLIHandlers)
|
|
}
|
|
|
|
func getProposalCLIHandlers(handlers []govclient.ProposalHandler) []*cobra.Command {
|
|
proposalCLIHandlers := make([]*cobra.Command, 0, len(handlers))
|
|
for _, proposalHandler := range handlers {
|
|
proposalCLIHandlers = append(proposalCLIHandlers, proposalHandler.CLIHandler())
|
|
}
|
|
return proposalCLIHandlers
|
|
}
|
|
|
|
// GetQueryCmd returns the root query command for the gov module.
|
|
func (AppModuleBasic) GetQueryCmd() *cobra.Command {
|
|
return cli.GetQueryCmd()
|
|
}
|
|
|
|
// RegisterInterfaces implements InterfaceModule.RegisterInterfaces
|
|
func (a AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry) {
|
|
v1.RegisterInterfaces(registry)
|
|
v1beta1.RegisterInterfaces(registry)
|
|
}
|
|
|
|
// AppModule implements an application module for the gov module.
|
|
type AppModule struct {
|
|
AppModuleBasic
|
|
|
|
keeper *keeper.Keeper
|
|
accountKeeper types.AccountKeeper
|
|
bankKeeper types.BankKeeper
|
|
}
|
|
|
|
// NewAppModule creates a new AppModule object
|
|
func NewAppModule(cdc codec.Codec, keeper *keeper.Keeper, ak types.AccountKeeper, bk types.BankKeeper) AppModule {
|
|
return AppModule{
|
|
AppModuleBasic: AppModuleBasic{cdc: cdc},
|
|
keeper: keeper,
|
|
accountKeeper: ak,
|
|
bankKeeper: bk,
|
|
}
|
|
}
|
|
|
|
func init() {
|
|
appmodule.Register(
|
|
&modulev1.Module{},
|
|
appmodule.Provide(provideModuleBasic, provideModule, provideKeyTable),
|
|
appmodule.Invoke(invokeAddRoutes, invokeSetHooks))
|
|
}
|
|
|
|
func provideModuleBasic() runtime.AppModuleBasicWrapper {
|
|
return runtime.WrapAppModuleBasic(AppModuleBasic{})
|
|
}
|
|
|
|
type govInputs struct {
|
|
depinject.In
|
|
|
|
Config *modulev1.Module
|
|
Cdc codec.Codec
|
|
Key *store.KVStoreKey
|
|
Subspace types.ParamSubspace
|
|
MsgServiceRouter *baseapp.MsgServiceRouter
|
|
AccountKeeper types.AccountKeeper
|
|
BankKeeper types.BankKeeper
|
|
StakingKeeper types.StakingKeeper
|
|
}
|
|
|
|
type govOutputs struct {
|
|
depinject.Out
|
|
|
|
Module runtime.AppModuleWrapper
|
|
Keeper *keeper.Keeper
|
|
HandlerRoute v1beta1.HandlerRoute
|
|
}
|
|
|
|
func provideModule(in govInputs) govOutputs {
|
|
kConfig := types.DefaultConfig()
|
|
if in.Config.MaxMetadataLen != 0 {
|
|
kConfig.MaxMetadataLen = in.Config.MaxMetadataLen
|
|
}
|
|
|
|
k := keeper.NewKeeper(in.Cdc, in.Key, in.Subspace, in.AccountKeeper, in.BankKeeper, in.StakingKeeper, in.MsgServiceRouter, kConfig)
|
|
m := NewAppModule(in.Cdc, k, in.AccountKeeper, in.BankKeeper)
|
|
hr := v1beta1.HandlerRoute{Handler: v1beta1.ProposalHandler, RouteKey: types.RouterKey}
|
|
|
|
return govOutputs{Module: runtime.WrapAppModule(m), Keeper: k, HandlerRoute: hr}
|
|
}
|
|
|
|
func provideKeyTable() paramtypes.KeyTable {
|
|
return v1.ParamKeyTable()
|
|
}
|
|
|
|
func invokeAddRoutes(keeper *keeper.Keeper, routes []v1beta1.HandlerRoute) {
|
|
if keeper == nil || routes == nil {
|
|
return
|
|
}
|
|
|
|
// Default route order is a lexical sort by RouteKey.
|
|
// Explicit ordering can be added to the module config if required.
|
|
slices.SortFunc(routes, func(x, y v1beta1.HandlerRoute) bool {
|
|
return x.RouteKey < y.RouteKey
|
|
})
|
|
|
|
router := v1beta1.NewRouter()
|
|
for _, r := range routes {
|
|
router.AddRoute(r.RouteKey, r.Handler)
|
|
}
|
|
keeper.SetLegacyRouter(router)
|
|
}
|
|
|
|
func invokeSetHooks(keeper *keeper.Keeper, govHooks map[string]types.GovHooksWrapper) error {
|
|
if keeper == nil || govHooks == nil {
|
|
return nil
|
|
}
|
|
|
|
// Default ordering is lexical by module name.
|
|
// Explicit ordering can be added to the module config if required.
|
|
modNames := maps.Keys(govHooks)
|
|
order := modNames
|
|
sort.Strings(order)
|
|
|
|
var multiHooks types.MultiGovHooks
|
|
for _, modName := range order {
|
|
hook, ok := govHooks[modName]
|
|
if !ok {
|
|
return fmt.Errorf("can't find staking hooks for module %s", modName)
|
|
}
|
|
multiHooks = append(multiHooks, hook)
|
|
}
|
|
|
|
keeper.SetHooks(multiHooks)
|
|
return nil
|
|
}
|
|
|
|
// Name returns the gov module's name.
|
|
func (AppModule) Name() string {
|
|
return types.ModuleName
|
|
}
|
|
|
|
// RegisterInvariants registers module invariants
|
|
func (am AppModule) RegisterInvariants(ir sdk.InvariantRegistry) {
|
|
keeper.RegisterInvariants(ir, am.keeper, am.bankKeeper)
|
|
}
|
|
|
|
// Deprecated: Route returns the message routing key for the gov module.
|
|
func (am AppModule) Route() sdk.Route {
|
|
return sdk.Route{}
|
|
}
|
|
|
|
// QuerierRoute returns the gov module's querier route name.
|
|
func (AppModule) QuerierRoute() string {
|
|
return types.QuerierRoute
|
|
}
|
|
|
|
// LegacyQuerierHandler returns no sdk.Querier.
|
|
func (am AppModule) LegacyQuerierHandler(legacyQuerierCdc *codec.LegacyAmino) sdk.Querier {
|
|
return keeper.NewQuerier(am.keeper, legacyQuerierCdc)
|
|
}
|
|
|
|
// RegisterServices registers module services.
|
|
func (am AppModule) RegisterServices(cfg module.Configurator) {
|
|
msgServer := keeper.NewMsgServerImpl(am.keeper)
|
|
v1beta1.RegisterMsgServer(cfg.MsgServer(), keeper.NewLegacyMsgServerImpl(am.accountKeeper.GetModuleAddress(types.ModuleName).String(), msgServer))
|
|
v1.RegisterMsgServer(cfg.MsgServer(), msgServer)
|
|
|
|
legacyQueryServer := keeper.NewLegacyQueryServer(am.keeper)
|
|
v1beta1.RegisterQueryServer(cfg.QueryServer(), legacyQueryServer)
|
|
v1.RegisterQueryServer(cfg.QueryServer(), am.keeper)
|
|
|
|
m := keeper.NewMigrator(am.keeper)
|
|
err := cfg.RegisterMigration(types.ModuleName, 1, m.Migrate1to2)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
err = cfg.RegisterMigration(types.ModuleName, 2, m.Migrate2to3)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
}
|
|
|
|
// InitGenesis performs genesis initialization for the gov module. It returns
|
|
// no validator updates.
|
|
func (am AppModule) InitGenesis(ctx sdk.Context, cdc codec.JSONCodec, data json.RawMessage) []abci.ValidatorUpdate {
|
|
var genesisState v1.GenesisState
|
|
cdc.MustUnmarshalJSON(data, &genesisState)
|
|
InitGenesis(ctx, am.accountKeeper, am.bankKeeper, am.keeper, &genesisState)
|
|
return []abci.ValidatorUpdate{}
|
|
}
|
|
|
|
// ExportGenesis returns the exported genesis state as raw bytes for the gov
|
|
// module.
|
|
func (am AppModule) ExportGenesis(ctx sdk.Context, cdc codec.JSONCodec) json.RawMessage {
|
|
gs := ExportGenesis(ctx, am.keeper)
|
|
return cdc.MustMarshalJSON(gs)
|
|
}
|
|
|
|
// ConsensusVersion implements AppModule/ConsensusVersion.
|
|
func (AppModule) ConsensusVersion() uint64 { return 3 }
|
|
|
|
// EndBlock returns the end blocker for the gov module. It returns no validator
|
|
// updates.
|
|
func (am AppModule) EndBlock(ctx sdk.Context, _ abci.RequestEndBlock) []abci.ValidatorUpdate {
|
|
EndBlocker(ctx, am.keeper)
|
|
return []abci.ValidatorUpdate{}
|
|
}
|
|
|
|
// AppModuleSimulation functions
|
|
|
|
// GenerateGenesisState creates a randomized GenState of the gov module.
|
|
func (AppModule) GenerateGenesisState(simState *module.SimulationState) {
|
|
simulation.RandomizedGenState(simState)
|
|
}
|
|
|
|
// ProposalContents returns all the gov content functions used to
|
|
// simulate governance proposals.
|
|
func (AppModule) ProposalContents(simState module.SimulationState) []simtypes.WeightedProposalContent {
|
|
return simulation.ProposalContents()
|
|
}
|
|
|
|
// RandomizedParams creates randomized gov param changes for the simulator.
|
|
func (AppModule) RandomizedParams(r *rand.Rand) []simtypes.ParamChange {
|
|
return simulation.ParamChanges(r)
|
|
}
|
|
|
|
// RegisterStoreDecoder registers a decoder for gov module's types
|
|
func (am AppModule) RegisterStoreDecoder(sdr sdk.StoreDecoderRegistry) {
|
|
sdr[types.StoreKey] = simulation.NewDecodeStore(am.cdc)
|
|
}
|
|
|
|
// WeightedOperations returns the all the gov module operations with their respective weights.
|
|
func (am AppModule) WeightedOperations(simState module.SimulationState) []simtypes.WeightedOperation {
|
|
return simulation.WeightedOperations(
|
|
simState.AppParams, simState.Cdc,
|
|
am.accountKeeper, am.bankKeeper, am.keeper, simState.Contents,
|
|
)
|
|
}
|