e8cedf243f
github.com/spf13/viper's recent releases introduced a semantic
change in some public API such as viper.IsSet(), which have
broken some of our flags checks. Instead of checking whether
users have changed a flag's default value we should rely on such
defaults and adjust runtime behaviour accordingly. In order to do
so, it's important that we pick sane defaults for all our flags.
The --pruning flag and configuration option now allow for a
fake custom strategy. When users elect custom, then the
pruning-{keep,snapshot}-every options are interpreted and
parsed; else they're ignored.
Zero is pruning-{keep,snapshot}-every default value. When
users choose to set a custom pruning strategy they are
signalling that they want more fine-grainted control, therefore
it's legitimate to expect them to know what they are doing and
enter valid values for both options.
Ref #5964
60 lines
1.2 KiB
Go
60 lines
1.2 KiB
Go
package server
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/spf13/viper"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/cosmos/cosmos-sdk/store"
|
|
)
|
|
|
|
func TestGetPruningOptionsFromFlags(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
initParams func()
|
|
expectedOptions store.PruningOptions
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "pruning",
|
|
initParams: func() {
|
|
viper.Set(flagPruning, store.PruningStrategyNothing)
|
|
},
|
|
expectedOptions: store.PruneNothing,
|
|
},
|
|
{
|
|
name: "granular pruning",
|
|
initParams: func() {
|
|
viper.Set(flagPruning, "custom")
|
|
viper.Set(flagPruningSnapshotEvery, 1234)
|
|
viper.Set(flagPruningKeepEvery, 4321)
|
|
},
|
|
expectedOptions: store.PruningOptions{
|
|
SnapshotEvery: 1234,
|
|
KeepEvery: 4321,
|
|
},
|
|
},
|
|
{
|
|
name: "default",
|
|
initParams: func() {},
|
|
expectedOptions: store.PruneSyncable,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(j *testing.T) {
|
|
viper.Reset()
|
|
viper.SetDefault(flagPruning, "syncable")
|
|
tt.initParams()
|
|
opts, err := GetPruningOptionsFromFlags()
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
return
|
|
}
|
|
require.Equal(t, tt.expectedOptions, opts)
|
|
})
|
|
}
|
|
}
|