23e864bc98
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description ref: #8961 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> Following up on [#9697](https://github.com/cosmos/cosmos-sdk/pull/9697#pullrequestreview-727295733), this PR is the first step for the #8961. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
93 lines
2.4 KiB
Go
93 lines
2.4 KiB
Go
package params_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
|
|
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
|
|
"github.com/cosmos/cosmos-sdk/x/params"
|
|
"github.com/cosmos/cosmos-sdk/x/params/types/proposal"
|
|
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
|
|
)
|
|
|
|
type HandlerTestSuite struct {
|
|
suite.Suite
|
|
|
|
app *simapp.SimApp
|
|
ctx sdk.Context
|
|
govHandler govtypes.Handler
|
|
}
|
|
|
|
func (suite *HandlerTestSuite) SetupTest() {
|
|
suite.app = simapp.Setup(suite.T(), false)
|
|
suite.ctx = suite.app.BaseApp.NewContext(false, tmproto.Header{})
|
|
suite.govHandler = params.NewParamChangeProposalHandler(suite.app.ParamsKeeper)
|
|
}
|
|
|
|
func TestHandlerTestSuite(t *testing.T) {
|
|
suite.Run(t, new(HandlerTestSuite))
|
|
}
|
|
|
|
func testProposal(changes ...proposal.ParamChange) *proposal.ParameterChangeProposal {
|
|
return proposal.NewParameterChangeProposal("title", "description", changes)
|
|
}
|
|
|
|
func (suite *HandlerTestSuite) TestProposalHandler() {
|
|
testCases := []struct {
|
|
name string
|
|
proposal *proposal.ParameterChangeProposal
|
|
onHandle func()
|
|
expErr bool
|
|
}{
|
|
{
|
|
"all fields",
|
|
testProposal(proposal.NewParamChange(stakingtypes.ModuleName, string(stakingtypes.KeyMaxValidators), "1")),
|
|
func() {
|
|
maxVals := suite.app.StakingKeeper.MaxValidators(suite.ctx)
|
|
suite.Require().Equal(uint32(1), maxVals)
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"invalid type",
|
|
testProposal(proposal.NewParamChange(stakingtypes.ModuleName, string(stakingtypes.KeyMaxValidators), "-")),
|
|
func() {},
|
|
true,
|
|
},
|
|
{
|
|
"omit empty fields",
|
|
testProposal(proposal.ParamChange{
|
|
Subspace: govtypes.ModuleName,
|
|
Key: string(govtypes.ParamStoreKeyDepositParams),
|
|
Value: `{"min_deposit": [{"denom": "uatom","amount": "64000000"}]}`,
|
|
}),
|
|
func() {
|
|
depositParams := suite.app.GovKeeper.GetDepositParams(suite.ctx)
|
|
suite.Require().Equal(govtypes.DepositParams{
|
|
MinDeposit: sdk.NewCoins(sdk.NewCoin("uatom", sdk.NewInt(64000000))),
|
|
MaxDepositPeriod: govtypes.DefaultPeriod,
|
|
}, depositParams)
|
|
},
|
|
false,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
tc := tc
|
|
suite.Run(tc.name, func() {
|
|
err := suite.govHandler(suite.ctx, tc.proposal)
|
|
if tc.expErr {
|
|
suite.Require().Error(err)
|
|
} else {
|
|
suite.Require().NoError(err)
|
|
tc.onHandle()
|
|
}
|
|
})
|
|
}
|
|
}
|