6cbbd6da75
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description The draft PR #9222 Closes: #7108 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> - implement proto definition for `Record` - rename `Info.go` to `legacyInfo.go` within `keyring` package - implement CLI `migrate` command that migrates all keys from legacyInfo to proto according to @robert-zaremba migration [algorithm](https://github.com/cosmos/cosmos-sdk/pull/9222/#discussion_r624683839) - remove legacy keybase entirely. - add `Migrate` and `MigrateAll` functions in `keyring.go` for single key and all keys migration - add tests - fix tests --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
75 lines
2.2 KiB
Go
75 lines
2.2 KiB
Go
package server_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/cosmos/cosmos-sdk/crypto/hd"
|
|
"github.com/cosmos/cosmos-sdk/crypto/keyring"
|
|
"github.com/cosmos/cosmos-sdk/server"
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
"github.com/cosmos/cosmos-sdk/types"
|
|
)
|
|
|
|
func TestGenerateCoinKey(t *testing.T) {
|
|
t.Parallel()
|
|
cdc := simapp.MakeTestEncodingConfig().Codec
|
|
addr, mnemonic, err := server.GenerateCoinKey(hd.Secp256k1, cdc)
|
|
require.NoError(t, err)
|
|
|
|
// Test creation
|
|
k, err := keyring.NewInMemory(cdc).NewAccount("xxx", mnemonic, "", hd.NewFundraiserParams(0, types.GetConfig().GetCoinType(), 0).String(), hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
addr1, err := k.GetAddress()
|
|
require.NoError(t, err)
|
|
require.Equal(t, addr, addr1)
|
|
}
|
|
|
|
func TestGenerateSaveCoinKey(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
encCfg := simapp.MakeTestEncodingConfig()
|
|
kb, err := keyring.New(t.Name(), "test", t.TempDir(), nil, encCfg.Codec)
|
|
require.NoError(t, err)
|
|
|
|
addr, mnemonic, err := server.GenerateSaveCoinKey(kb, "keyname", false, hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
|
|
// Test key was actually saved
|
|
k, err := kb.Key("keyname")
|
|
require.NoError(t, err)
|
|
addr1, err := k.GetAddress()
|
|
require.NoError(t, err)
|
|
require.Equal(t, addr, addr1)
|
|
|
|
// Test in-memory recovery
|
|
k, err = keyring.NewInMemory(encCfg.Codec).NewAccount("xxx", mnemonic, "", hd.NewFundraiserParams(0, types.GetConfig().GetCoinType(), 0).String(), hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
addr1, err = k.GetAddress()
|
|
require.NoError(t, err)
|
|
require.Equal(t, addr, addr1)
|
|
}
|
|
|
|
func TestGenerateSaveCoinKeyOverwriteFlag(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
encCfg := simapp.MakeTestEncodingConfig()
|
|
kb, err := keyring.New(t.Name(), "test", t.TempDir(), nil, encCfg.Codec)
|
|
require.NoError(t, err)
|
|
|
|
keyname := "justakey"
|
|
addr1, _, err := server.GenerateSaveCoinKey(kb, keyname, false, hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
|
|
// Test overwrite with overwrite=false
|
|
_, _, err = server.GenerateSaveCoinKey(kb, keyname, false, hd.Secp256k1)
|
|
require.Error(t, err)
|
|
|
|
// Test overwrite with overwrite=true
|
|
addr2, _, err := server.GenerateSaveCoinKey(kb, keyname, true, hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
|
|
require.NotEqual(t, addr1, addr2)
|
|
}
|