c7e2305286
Ref: #9810 Moves all legacy gov code to `v1beta1`. This preserves all existing behavior (i.e. everything still uses v1beta1). It's merely moving things around to get everything in the right place logistically (hence the large diff still) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
88 lines
2.5 KiB
Go
88 lines
2.5 KiB
Go
package cli
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/cosmos/cosmos-sdk/client"
|
|
"github.com/cosmos/cosmos-sdk/client/tx"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
"github.com/cosmos/cosmos-sdk/version"
|
|
govtypes "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
|
|
paramscutils "github.com/cosmos/cosmos-sdk/x/params/client/utils"
|
|
paramproposal "github.com/cosmos/cosmos-sdk/x/params/types/proposal"
|
|
)
|
|
|
|
// NewSubmitParamChangeProposalTxCmd returns a CLI command handler for creating
|
|
// a parameter change proposal governance transaction.
|
|
func NewSubmitParamChangeProposalTxCmd() *cobra.Command {
|
|
return &cobra.Command{
|
|
Use: "param-change [proposal-file]",
|
|
Args: cobra.ExactArgs(1),
|
|
Short: "Submit a parameter change proposal",
|
|
Long: strings.TrimSpace(
|
|
fmt.Sprintf(`Submit a parameter proposal along with an initial deposit.
|
|
The proposal details must be supplied via a JSON file. For values that contains
|
|
objects, only non-empty fields will be updated.
|
|
|
|
IMPORTANT: Currently parameter changes are evaluated but not validated, so it is
|
|
very important that any "value" change is valid (ie. correct type and within bounds)
|
|
for its respective parameter, eg. "MaxValidators" should be an integer and not a decimal.
|
|
|
|
Proper vetting of a parameter change proposal should prevent this from happening
|
|
(no deposits should occur during the governance process), but it should be noted
|
|
regardless.
|
|
|
|
Example:
|
|
$ %s tx gov submit-proposal param-change <path/to/proposal.json> --from=<key_or_address>
|
|
|
|
Where proposal.json contains:
|
|
|
|
{
|
|
"title": "Staking Param Change",
|
|
"description": "Update max validators",
|
|
"changes": [
|
|
{
|
|
"subspace": "staking",
|
|
"key": "MaxValidators",
|
|
"value": 105
|
|
}
|
|
],
|
|
"deposit": "1000stake"
|
|
}
|
|
`,
|
|
version.AppName,
|
|
),
|
|
),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
clientCtx, err := client.GetClientTxContext(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
proposal, err := paramscutils.ParseParamChangeProposalJSON(clientCtx.LegacyAmino, args[0])
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
from := clientCtx.GetFromAddress()
|
|
content := paramproposal.NewParameterChangeProposal(
|
|
proposal.Title, proposal.Description, proposal.Changes.ToParamChanges(),
|
|
)
|
|
|
|
deposit, err := sdk.ParseCoinsNormalized(proposal.Deposit)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
msg, err := govtypes.NewMsgSubmitProposal(content, deposit, from)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
|
|
},
|
|
}
|
|
}
|