cosmos-sdk/x/distribution
Robert Zaremba 7cb85c5cdd
refactor: remove weird casting for staking.Keeper in slashing and distribution (#12973)
## Description

Both slashing and distribution simulator is using ugly casting from the nice interface type to:

 ```go
stakeKeeper := sk.(*stakingkeeper.Keeper)
```

This creates additional dependency for `staking/keeper` package in other modules, and requires type of a specific type (here reference type, in 0.46 it's even worse - because it uses object type).

EXTRA:
 * removed `stakingkeepr.RandomValidator` function (which btw, was also weird, because it was in the keeper module and required Keeper as an argument) and created generic `testutil.RandSliceElem` function.


---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-08-20 21:11:44 +00:00
..
client refactor: x/bank integration and e2e tests (#12779) 2022-08-02 10:10:31 -05:00
exported feat: deprecate x/params usage in x/distr (#12434) 2022-07-08 09:47:34 -04:00
keeper refactor!: Remove proposer-based rewards (#12876) 2022-08-16 08:53:00 -04:00
migrations chore: routine gofumpt (#12571) 2022-07-16 18:22:05 +00:00
simulation refactor: remove weird casting for staking.Keeper in slashing and distribution (#12973) 2022-08-20 21:11:44 +00:00
spec docs: update sdk & tm version links in docs (#12976) 2022-08-20 08:42:13 +02:00
testutil refactor: replace app wiring yaml config by go (#12757) 2022-07-29 16:39:44 -03:00
types refactor: remove weird casting for staking.Keeper in slashing and distribution (#12973) 2022-08-20 21:11:44 +00:00
abci.go refactor!: Remove proposer-based rewards (#12876) 2022-08-16 08:53:00 -04:00
doc.go Merge PR #5417: Update distribution module doc 2019-12-17 13:59:16 -05:00
handler.go refactor: move legacy gov to v1beta1 (#10748) 2021-12-13 18:48:44 +00:00
module_test.go feat: decouple x/distribution from simapp (#12334) 2022-06-22 21:43:33 +02:00
module.go refactor!: Remove proposer-based rewards (#12876) 2022-08-16 08:53:00 -04:00
proposal_handler_test.go feat: decouple x/distribution from simapp (#12334) 2022-06-22 21:43:33 +02:00
README.md docs: Improve markdownlint configuration (#11104) 2022-02-10 12:07:01 +00:00

Distribution

  • Distribution - Fee distribution, and staking token provision distribution.