d9f3eb027d
## Description Refs: #11970 Changes target of `SIGN_MODE_TEXTUAL` rendering to be a structured datatype instead of lines of ASCII text. This avoids the complexities of in-band, signaling and allows more capable signing devices not to be hindered by the limitations of those less capable. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [X] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [X] added `!` to the type prefix if API or client breaking change - [X] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [X] provided a link to the relevant issue or specification - [X] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [X] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [X] included comments for [documenting Go code](https://blog.golang.org/godoc) - [X] updated the relevant documentation or specification - [X] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed NOTE: changelog intentionally omitted - we'll add an entry when #11970 is complete. ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
40 lines
1.0 KiB
Go
40 lines
1.0 KiB
Go
package valuerenderer
|
|
|
|
import (
|
|
"context"
|
|
"encoding/hex"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"google.golang.org/protobuf/reflect/protoreflect"
|
|
)
|
|
|
|
// NewBytesValueRenderer returns a ValueRenderer for Protobuf bytes, which are
|
|
// encoded as capital-letter hexadecimal, without the '0x' prefix.
|
|
func NewBytesValueRenderer() ValueRenderer {
|
|
return bytesValueRenderer{}
|
|
}
|
|
|
|
type bytesValueRenderer struct{}
|
|
|
|
var _ ValueRenderer = bytesValueRenderer{}
|
|
|
|
func (vr bytesValueRenderer) Format(ctx context.Context, v protoreflect.Value) ([]Screen, error) {
|
|
text := strings.ToUpper(hex.EncodeToString(v.Bytes()))
|
|
return []Screen{{Text: text}}, nil
|
|
}
|
|
|
|
func (vr bytesValueRenderer) Parse(_ context.Context, screens []Screen) (protoreflect.Value, error) {
|
|
if len(screens) != 1 {
|
|
return protoreflect.ValueOfBytes([]byte{}), fmt.Errorf("expected single screen: %v", screens)
|
|
}
|
|
formatted := screens[0].Text
|
|
|
|
data, err := hex.DecodeString(string(formatted))
|
|
if err != nil {
|
|
return protoreflect.ValueOfBytes([]byte{}), err
|
|
}
|
|
|
|
return protoreflect.ValueOfBytes(data), nil
|
|
}
|