## Description + fixing `x/bank/migrations/v44.migrateDenomMetadata` - we could potentially put a wrong data in a new key if the old keys have variable length. + linting the code Putting in the same PR because i found the issue when running a linter. Depends on: #10112 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
49 lines
1.5 KiB
Bash
49 lines
1.5 KiB
Bash
#!/usr/bin/env bash
|
|
|
|
# this script is used by Github CI to tranverse all modules an run module tests.
|
|
# the script expects a diff to be generated in order to skip some modules.
|
|
|
|
# Executes go module tests and merges the coverage profile.
|
|
# If GIT_DIFF variable is set then it's used to test if a module has any file changes - if
|
|
# it doesn't have any file changes then we will ignore the module tests.
|
|
execute_mod_tests() {
|
|
go_mod=$1;
|
|
mod_dir=$(dirname "$go_mod");
|
|
mod_dir=${mod_dir:2}; # remove "./" prefix
|
|
root_dir=$(pwd);
|
|
|
|
# TODO: in the future we will need to disable it once we go into multi module setup, because
|
|
# we will have cross module dependencies.
|
|
if [ -n "$GIT_DIFF" ] && ! grep $mod_dir <<< $GIT_DIFF; then
|
|
echo ">>> ignoring module $mod_dir - no changes in the module";
|
|
return;
|
|
fi;
|
|
|
|
echo ">>> running $go_mod tests"
|
|
cd $mod_dir;
|
|
go test -mod=readonly -timeout 30m -coverprofile=${root_dir}/${coverage_file}.tmp -covermode=atomic -tags='norace ledger test_ledger_mock' ./...
|
|
local ret=$?
|
|
echo "test return: " $ret;
|
|
cd -;
|
|
# strip mode statement
|
|
tail -n +1 ${coverage_file}.tmp >> ${coverage_file}
|
|
rm ${coverage_file}.tmp;
|
|
return $ret;
|
|
}
|
|
|
|
# GIT_DIFF=`git status --porcelain`
|
|
|
|
echo "GIT_DIFF: " $GIT_DIFF
|
|
|
|
coverage_file=coverage-go-submod-profile.out
|
|
return_val=0;
|
|
|
|
for f in $(find -name go.mod -not -path "./go.mod"); do
|
|
execute_mod_tests $f;
|
|
if [[ $? -ne 0 ]] ; then
|
|
return_val=2;
|
|
fi;
|
|
done
|
|
|
|
exit $return_val;
|