## Description In Osmosis' simulation, we were observing that a large percent of the time was spent within SimulateParamChangeProposalContent, in particular within the composed key function. This is from a trace of our simulator running for 10 minutes: <img width="931" alt="Screenshot 2021-06-08 at 2 32 28 PM" src="https://user-images.githubusercontent.com/6440154/121238788-16cdd000-c85e-11eb-8251-94537e69f8ce.png"> ~This change lowers the number of calls to ComposedKey() by a factor of 3, and speeds up the underlying ComposedKey function. (sprintf is not particularly efficient for string concatenation, https://dev.to/pmalhaire/concatenate-strings-in-golang-a-quick-benchmark-4ahh ). After these change, the effect of ComposedKey() can no longer be seen in the profiler outputs.~ ~This change does not change the result of the simulator on a given seed.~ See https://github.com/cosmos/cosmos-sdk/pull/9481#issuecomment-857119210 for description of changes. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
184 lines
5.3 KiB
Go
184 lines
5.3 KiB
Go
package simulation
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"math/rand"
|
|
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
|
|
"github.com/tendermint/tendermint/types"
|
|
|
|
"github.com/cosmos/cosmos-sdk/codec"
|
|
"github.com/cosmos/cosmos-sdk/types/simulation"
|
|
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
|
|
)
|
|
|
|
const (
|
|
// Minimum time per block
|
|
minTimePerBlock int64 = 10000 / 2
|
|
|
|
// Maximum time per block
|
|
maxTimePerBlock int64 = 10000
|
|
)
|
|
|
|
// TODO: explain transitional matrix usage
|
|
var (
|
|
// Currently there are 3 different liveness types,
|
|
// fully online, spotty connection, offline.
|
|
defaultLivenessTransitionMatrix, _ = CreateTransitionMatrix([][]int{
|
|
{90, 20, 1},
|
|
{10, 50, 5},
|
|
{0, 10, 1000},
|
|
})
|
|
|
|
// 3 states: rand in range [0, 4*provided blocksize],
|
|
// rand in range [0, 2 * provided blocksize], 0
|
|
defaultBlockSizeTransitionMatrix, _ = CreateTransitionMatrix([][]int{
|
|
{85, 5, 0},
|
|
{15, 92, 1},
|
|
{0, 3, 99},
|
|
})
|
|
)
|
|
|
|
// Params define the parameters necessary for running the simulations
|
|
type Params struct {
|
|
pastEvidenceFraction float64
|
|
numKeys int
|
|
evidenceFraction float64
|
|
initialLivenessWeightings []int
|
|
livenessTransitionMatrix simulation.TransitionMatrix
|
|
blockSizeTransitionMatrix simulation.TransitionMatrix
|
|
}
|
|
|
|
func (p Params) PastEvidenceFraction() float64 {
|
|
return p.pastEvidenceFraction
|
|
}
|
|
|
|
func (p Params) NumKeys() int {
|
|
return p.numKeys
|
|
}
|
|
|
|
func (p Params) EvidenceFraction() float64 {
|
|
return p.evidenceFraction
|
|
}
|
|
|
|
func (p Params) InitialLivenessWeightings() []int {
|
|
return p.initialLivenessWeightings
|
|
}
|
|
|
|
func (p Params) LivenessTransitionMatrix() simulation.TransitionMatrix {
|
|
return p.livenessTransitionMatrix
|
|
}
|
|
|
|
func (p Params) BlockSizeTransitionMatrix() simulation.TransitionMatrix {
|
|
return p.blockSizeTransitionMatrix
|
|
}
|
|
|
|
// RandomParams returns random simulation parameters
|
|
func RandomParams(r *rand.Rand) Params {
|
|
return Params{
|
|
pastEvidenceFraction: r.Float64(),
|
|
numKeys: simulation.RandIntBetween(r, 2, 2500), // number of accounts created for the simulation
|
|
evidenceFraction: r.Float64(),
|
|
initialLivenessWeightings: []int{simulation.RandIntBetween(r, 1, 80), r.Intn(10), r.Intn(10)},
|
|
livenessTransitionMatrix: defaultLivenessTransitionMatrix,
|
|
blockSizeTransitionMatrix: defaultBlockSizeTransitionMatrix,
|
|
}
|
|
}
|
|
|
|
// Param change proposals
|
|
|
|
// ParamChange defines the object used for simulating parameter change proposals
|
|
type ParamChange struct {
|
|
subspace string
|
|
key string
|
|
simValue simulation.SimValFn
|
|
}
|
|
|
|
func (spc ParamChange) Subspace() string {
|
|
return spc.subspace
|
|
}
|
|
|
|
func (spc ParamChange) Key() string {
|
|
return spc.key
|
|
}
|
|
|
|
func (spc ParamChange) SimValue() simulation.SimValFn {
|
|
return spc.simValue
|
|
}
|
|
|
|
// NewSimParamChange creates a new ParamChange instance
|
|
func NewSimParamChange(subspace, key string, simVal simulation.SimValFn) simulation.ParamChange {
|
|
return ParamChange{
|
|
subspace: subspace,
|
|
key: key,
|
|
simValue: simVal,
|
|
}
|
|
}
|
|
|
|
// ComposedKey creates a new composed key for the param change proposal
|
|
func (spc ParamChange) ComposedKey() string {
|
|
return spc.Subspace() + "/" + spc.Key()
|
|
}
|
|
|
|
// Proposal Contents
|
|
|
|
// WeightedProposalContent defines a common struct for proposal contents defined by
|
|
// external modules (i.e outside gov)
|
|
type WeightedProposalContent struct {
|
|
appParamsKey string // key used to retrieve the value of the weight from the simulation application params
|
|
defaultWeight int // default weight
|
|
contentSimulatorFn simulation.ContentSimulatorFn // content simulator function
|
|
}
|
|
|
|
func NewWeightedProposalContent(appParamsKey string, defaultWeight int, contentSimulatorFn simulation.ContentSimulatorFn) simulation.WeightedProposalContent {
|
|
return &WeightedProposalContent{appParamsKey: appParamsKey, defaultWeight: defaultWeight, contentSimulatorFn: contentSimulatorFn}
|
|
}
|
|
|
|
func (w WeightedProposalContent) AppParamsKey() string {
|
|
return w.appParamsKey
|
|
}
|
|
|
|
func (w WeightedProposalContent) DefaultWeight() int {
|
|
return w.defaultWeight
|
|
}
|
|
|
|
func (w WeightedProposalContent) ContentSimulatorFn() simulation.ContentSimulatorFn {
|
|
return w.contentSimulatorFn
|
|
}
|
|
|
|
// Param change proposals
|
|
|
|
// randomConsensusParams returns random simulation consensus parameters, it extracts the Evidence from the Staking genesis state.
|
|
func randomConsensusParams(r *rand.Rand, appState json.RawMessage, cdc codec.JSONCodec) *abci.ConsensusParams {
|
|
var genesisState map[string]json.RawMessage
|
|
err := json.Unmarshal(appState, &genesisState)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
stakingGenesisState := stakingtypes.GetGenesisStateFromAppState(cdc, genesisState)
|
|
consensusParams := &abci.ConsensusParams{
|
|
Block: &abci.BlockParams{
|
|
MaxBytes: int64(simulation.RandIntBetween(r, 20000000, 30000000)),
|
|
MaxGas: -1,
|
|
},
|
|
Validator: &tmproto.ValidatorParams{
|
|
PubKeyTypes: []string{types.ABCIPubKeyTypeEd25519},
|
|
},
|
|
Evidence: &tmproto.EvidenceParams{
|
|
MaxAgeNumBlocks: int64(stakingGenesisState.Params.UnbondingTime / AverageBlockTime),
|
|
MaxAgeDuration: stakingGenesisState.Params.UnbondingTime,
|
|
},
|
|
}
|
|
|
|
bz, err := json.MarshalIndent(&consensusParams, "", " ")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
fmt.Printf("Selected randomly generated consensus parameters:\n%s\n", bz)
|
|
|
|
return consensusParams
|
|
}
|