cosmos-sdk/docs/architecture
Amaury dfe3e7a8d7
Remove ServiceMsgs from ADR-031 (#9139)
* wip

* wip

* wip

* wip on refactoring adr 031 type URLs

* Fix msg_service_router

* Fix gov client queries

* Fix some modules tests

* Remove all instances of "*.Msg/*"

* Uncomment code

* Remove commented code

* // simulation.NewWeightedOperation(

* Fix CopyTx

* Fix more tests

* Fix x/gov test

* proto.MessageName->sdk.MsgName

* Fix authz tests

* Use MsgRoute in feegrant and staking/authz

* Fix more tests

* Fix sims?

* Add norace tag

* Add CL

* rebuild rosetta api test data

* Update ADR

* Rename MsgRoute -> MsgTypeURL

* Fix codec registration

* Remove sdk.GetLegacySignBytes

* Update types/tx_msg.go

* Update x/authz/simulation/operations.go

* Move LegacyMsg to legacytx

* Update CHANGELOG.md

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Remove NewAnyWithCustomTypeURL

* Keep support for ServiceMsgs

* Fix TxBody UnpackInterfaces

* Fix test

* Address review

* Remove support for ServiceMsg typeURLs

* Fix lint

* Update changelog

* Fix tests

* Use sdk.MsgTypeURL everywhere

* Fix tests

* Fix rosetta, run make rosetta-data

* Fix rosetta thanks to froydi

* Address reviews

* Fix test

* Remove stray log

* Update CL

Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2021-04-30 11:00:47 +00:00
..
adr-002-docs-structure.md Fix typo (#5523) 2020-01-15 08:14:25 +01:00
adr-003-dynamic-capability-store.md Fix broken links to ICS specs (#8972) 2021-03-24 10:23:31 +00:00
adr-004-split-denomination-keys.md Update ADR status (#8009) 2020-11-23 16:31:17 +00:00
adr-006-secret-store-replacement.md Update ADR 006 (#5326) 2019-11-19 09:51:39 +00:00
adr-007-specialization-groups.md Merge PR #4827: ADR 007 / 008: Specialization Groups Abstraction / CERT Group 2019-09-30 15:05:29 -04:00
adr-008-dCERT-group.md Merge PR #4827: ADR 007 / 008: Specialization Groups Abstraction / CERT Group 2019-09-30 15:05:29 -04:00
adr-009-evidence-module.md docs: link checker (#5860) 2020-03-24 11:21:30 +01:00
adr-010-modular-antehandler.md Merge PR #5006: Modular AnteDecorator 2019-10-10 08:46:09 -04:00
adr-011-generalize-genesis-accounts.md rename RegisterCodec to RegisterLegacyAminoCodec (#7243) 2020-09-07 14:47:12 +00:00
adr-012-state-accessors.md Rename *codec.Codec to *codec.LegacyAmino (#6991) 2020-08-10 19:41:21 +00:00
adr-013-metrics.md Merge PR #6761: telemetry: use UTC() in wrappers 2020-07-17 15:33:50 -04:00
adr-014-proportional-slashing.md Proportional slashing ADR Update (#6368) 2020-10-05 09:30:50 +02:00
adr-016-validator-consensus-key-rotation.md Merge PR #5233: ADR 016: Validator consensus key rotation 2020-01-05 16:57:18 -05:00
adr-017-historical-header-module.md Fix link to ICS2 on ADR017 (#8975) 2021-03-24 08:30:00 +00:00
adr-018-extendable-voting-period.md Merge PR #5459: ADR 18: Extendable Governance Voting Periods 2020-02-04 11:23:49 -05:00
adr-019-protobuf-state-encoding.md codec: Rename codec and marshaler interfaces (#9226) 2021-04-29 10:46:22 +00:00
adr-020-protobuf-transaction-encoding.md doc secp256r1 (#8899) 2021-03-19 14:22:59 +00:00
adr-021-protobuf-query-encoding.md Update ADR status (#8009) 2020-11-23 16:31:17 +00:00
adr-022-custom-panic-handling.md ADR 022 - Custom baseapp panic handling (#6072) 2020-05-13 11:09:46 -04:00
adr-023-protobuf-naming.md Update ADR status (#8009) 2020-11-23 16:31:17 +00:00
adr-024-coin-metadata.md x/bank: client denom metadata gRPC (#8317) 2021-01-19 17:08:09 -05:00
adr-027-deterministic-protobuf-serialization.md Followup suggestions from ADR-027 updates (#7232) (#7379) 2020-09-28 09:42:57 +00:00
adr-028-public-key-addresses.md ADR-28 derive address functions (#9088) 2021-04-15 21:32:45 +00:00
adr-029-fee-grant-module.md ADR 029: Fee Grant Module (#7106) 2020-10-09 15:09:17 +00:00
adr-030-authz-module.md ADR-033 cosmetic updates (#8676) 2021-02-24 11:45:21 +00:00
adr-031-msg-service.md Remove ServiceMsgs from ADR-031 (#9139) 2021-04-30 11:00:47 +00:00
adr-032-typed-events.md ADR 32: Typed Events (#7474) 2020-10-13 19:51:47 +01:00
adr-033-protobuf-inter-module-comm.md Fix broken relative link in ADR033 (#8977) 2021-03-25 07:12:42 +00:00
adr-034-account-rekeying.md Update adr-034-account-rekeying.md 2020-11-24 13:06:58 -05:00
adr-035-rosetta-api-support.md Rosetta API implementation (#7695) 2021-01-21 09:33:02 +00:00
adr-036-arbitrary-signature.md ADR036: Arbitrary signature (#7727) 2021-04-19 16:18:48 +00:00
adr-037-gov-split-vote.md fix comments and add CHANGELOG 2021-02-06 00:57:12 +10:00
adr-038-state-listening.md codec: Rename codec and marshaler interfaces (#9226) 2021-04-29 10:46:22 +00:00
adr-039-epoched-staking.md Add section for parameterizing the epoch length 2021-02-22 15:37:53 -06:00
adr-041-in-place-store-migrations.md x/upgrade: added consensus version tracking (part of ADR-041) (#8743) 2021-03-19 22:01:29 +00:00
adr-template.md ADR template: add Further Discussions (#8108) 2020-12-09 10:36:48 +00:00
PROCESS.md ADR: add a process proposal (#7621) 2020-10-22 22:40:44 +00:00
README.md remove IBC ADRs (#9191) 2021-04-26 11:05:24 +00:00

order parent
false
order
false

Architecture Decision Records (ADR)

This is a location to record all high-level architecture decisions in the Cosmos-SDK.

An Architectural Decision (AD) is a software design choice that addresses a functional or non-functional requirement that is architecturally significant. An Architecturally Significant Requirement (ASR) is a requirement that has a measurable effect on a software systems architecture and quality. An Architectural Decision Record (ADR) captures a single AD, such as often done when writing personal notes or meeting minutes; the collection of ADRs created and maintained in a project constitute its decision log. All these are within the topic of Architectural Knowledge Management (AKM).

You can read more about the ADR concept in this blog post.

Rationale

ADRs are intended to be the primary mechanism for proposing new feature designs and new processes, for collecting community input on an issue, and for documenting the design decisions. An ADR should provide:

  • Context on the relevant goals and the current state
  • Proposed changes to achieve the goals
  • Summary of pros and cons
  • References
  • Changelog

Note the distinction between an ADR and a spec. The ADR provides the context, intuition, reasoning, and justification for a change in architecture, or for the architecture of something new. The spec is much more compressed and streamlined summary of everything as it stands today.

If recorded decisions turned out to be lacking, convene a discussion, record the new decisions here, and then modify the code to match.

Creating new ADR

Read about the PROCESS.

ADR Table of Contents

Accepted

Proposed