5491be27d0
## Description Closes: #11245 ### 1. Pruning proposal. Proposals are pruned: - after a successful MsgExec (or try_exec) - on voting_period_end + max_execution_period whichever happens first. ### 2. Pruning votes. Votes are pruned: - on MsgExec (or try_exec) if tally is final - on voting_period_end whichever happens first. ### 3. Various group fixes See #11404 for details TODO: - [x] Add vote pruning after Tally, once #11310 is merged - [x] Add tests --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
38 lines
1.1 KiB
Go
38 lines
1.1 KiB
Go
package group_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
"github.com/cosmos/cosmos-sdk/x/group"
|
|
)
|
|
|
|
// TestGogoUnmarshalProposal tests some weird behavior in gogoproto
|
|
// unmarshalling.
|
|
// This test serves as a showcase that we need to be careful when unmarshalling
|
|
// multiple times into the same reference.
|
|
func TestGogoUnmarshalProposal(t *testing.T) {
|
|
cdc := simapp.MakeTestEncodingConfig().Codec
|
|
p1 := group.Proposal{Proposers: []string{"foo"}}
|
|
p2 := group.Proposal{Proposers: []string{"bar"}}
|
|
|
|
p1Bz, err := cdc.Marshal(&p1)
|
|
require.NoError(t, err)
|
|
p2Bz, err := cdc.Marshal(&p2)
|
|
require.NoError(t, err)
|
|
|
|
var p group.Proposal
|
|
err = cdc.Unmarshal(p1Bz, &p)
|
|
require.NoError(t, err)
|
|
err = cdc.Unmarshal(p2Bz, &p)
|
|
require.NoError(t, err)
|
|
|
|
// One would expect that unmarshalling into the same `&p` reference would
|
|
// clear the previous `p` value. But it seems that (at least for array
|
|
// fields), the values are not replaced, but concatenated, which
|
|
// is not an intuitive behavior.
|
|
require.Len(t, p.Proposers, 2)
|
|
}
|