## Description Ref: #9438 This PR performs the major work of swapping out the v1beta1 msg server and query server for the new one which can process a proposal as an array of messages. This PR still retains the legacy servers which simply wrap around the new ones, providing the same interface as before. In order to keep backwards compatibility, a new msg, `MsgExecLegacyContent` has been created which allows `Content` to become a `Msg` type and still be used as part of the new implementation. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
289 lines
8.0 KiB
Go
289 lines
8.0 KiB
Go
package keeper
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strconv"
|
|
|
|
"github.com/armon/go-metrics"
|
|
|
|
storetypes "github.com/cosmos/cosmos-sdk/store/types"
|
|
"github.com/cosmos/cosmos-sdk/telemetry"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
|
|
"github.com/cosmos/cosmos-sdk/x/gov/types"
|
|
"github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
|
|
"github.com/cosmos/cosmos-sdk/x/gov/types/v1beta2"
|
|
)
|
|
|
|
type msgServer struct {
|
|
Keeper
|
|
}
|
|
|
|
// NewMsgServerImpl returns an implementation of the gov MsgServer interface
|
|
// for the provided Keeper.
|
|
func NewMsgServerImpl(keeper Keeper) v1beta2.MsgServer {
|
|
return &msgServer{Keeper: keeper}
|
|
}
|
|
|
|
var _ v1beta2.MsgServer = msgServer{}
|
|
|
|
func (k msgServer) SubmitProposal(goCtx context.Context, msg *v1beta2.MsgSubmitProposal) (*v1beta2.MsgSubmitProposalResponse, error) {
|
|
ctx := sdk.UnwrapSDKContext(goCtx)
|
|
|
|
proposalMsgs, err := msg.GetMsgs()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
proposal, err := k.Keeper.SubmitProposal(ctx, proposalMsgs)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
bytes, err := proposal.Marshal()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// ref: https://github.com/cosmos/cosmos-sdk/issues/9683
|
|
ctx.GasMeter().ConsumeGas(
|
|
3*storetypes.KVGasConfig().WriteCostPerByte*uint64(len(bytes)),
|
|
"submit proposal",
|
|
)
|
|
|
|
defer telemetry.IncrCounter(1, types.ModuleName, "proposal")
|
|
|
|
proposer, _ := sdk.AccAddressFromBech32(msg.GetProposer())
|
|
votingStarted, err := k.Keeper.AddDeposit(ctx, proposal.ProposalId, proposer, msg.GetInitialDeposit())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
ctx.EventManager().EmitEvent(
|
|
sdk.NewEvent(
|
|
sdk.EventTypeMessage,
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, types.AttributeValueCategory),
|
|
sdk.NewAttribute(sdk.AttributeKeySender, msg.GetProposer()),
|
|
),
|
|
)
|
|
|
|
if votingStarted {
|
|
submitEvent := sdk.NewEvent(types.EventTypeSubmitProposal,
|
|
sdk.NewAttribute(types.AttributeKeyVotingPeriodStart, fmt.Sprintf("%d", proposal.ProposalId)),
|
|
)
|
|
|
|
ctx.EventManager().EmitEvent(submitEvent)
|
|
}
|
|
|
|
return &v1beta2.MsgSubmitProposalResponse{
|
|
ProposalId: proposal.ProposalId,
|
|
}, nil
|
|
}
|
|
|
|
func (k msgServer) ExecLegacyContent(goCtx context.Context, msg *v1beta2.MsgExecLegacyContent) (*v1beta2.MsgExecLegacyContentResponse, error) {
|
|
ctx := sdk.UnwrapSDKContext(goCtx)
|
|
|
|
govAcct := k.GetGovernanceAccount(ctx).GetAddress().String()
|
|
if govAcct != msg.Authority {
|
|
return nil, sdkerrors.Wrapf(types.ErrInvalidSigner, "expected %s got %s", govAcct, msg.Authority)
|
|
}
|
|
|
|
content, err := v1beta2.LegacyContentFromMessage(msg)
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrapf(types.ErrInvalidProposalContent, "%+v", err)
|
|
}
|
|
|
|
// Ensure that the content has a respective handler
|
|
if !k.Keeper.legacyRouter.HasRoute(content.ProposalRoute()) {
|
|
return nil, sdkerrors.Wrap(types.ErrNoProposalHandlerExists, content.ProposalRoute())
|
|
}
|
|
|
|
handler := k.Keeper.legacyRouter.GetRoute(content.ProposalRoute())
|
|
if err := handler(ctx, content); err != nil {
|
|
return nil, sdkerrors.Wrapf(types.ErrInvalidProposalContent, "failed to run legacy handler %s, %+v", content.ProposalRoute(), err)
|
|
}
|
|
|
|
return &v1beta2.MsgExecLegacyContentResponse{}, nil
|
|
|
|
}
|
|
|
|
func (k msgServer) Vote(goCtx context.Context, msg *v1beta2.MsgVote) (*v1beta2.MsgVoteResponse, error) {
|
|
ctx := sdk.UnwrapSDKContext(goCtx)
|
|
accAddr, accErr := sdk.AccAddressFromBech32(msg.Voter)
|
|
if accErr != nil {
|
|
return nil, accErr
|
|
}
|
|
err := k.Keeper.AddVote(ctx, msg.ProposalId, accAddr, v1beta2.NewNonSplitVoteOption(msg.Option))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
defer telemetry.IncrCounterWithLabels(
|
|
[]string{types.ModuleName, "vote"},
|
|
1,
|
|
[]metrics.Label{
|
|
telemetry.NewLabel("proposal_id", strconv.Itoa(int(msg.ProposalId))),
|
|
},
|
|
)
|
|
|
|
ctx.EventManager().EmitEvent(
|
|
sdk.NewEvent(
|
|
sdk.EventTypeMessage,
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, types.AttributeValueCategory),
|
|
sdk.NewAttribute(sdk.AttributeKeySender, msg.Voter),
|
|
),
|
|
)
|
|
|
|
return &v1beta2.MsgVoteResponse{}, nil
|
|
}
|
|
|
|
func (k msgServer) VoteWeighted(goCtx context.Context, msg *v1beta2.MsgVoteWeighted) (*v1beta2.MsgVoteWeightedResponse, error) {
|
|
ctx := sdk.UnwrapSDKContext(goCtx)
|
|
accAddr, accErr := sdk.AccAddressFromBech32(msg.Voter)
|
|
if accErr != nil {
|
|
return nil, accErr
|
|
}
|
|
err := k.Keeper.AddVote(ctx, msg.ProposalId, accAddr, msg.Options)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
defer telemetry.IncrCounterWithLabels(
|
|
[]string{types.ModuleName, "vote"},
|
|
1,
|
|
[]metrics.Label{
|
|
telemetry.NewLabel("proposal_id", strconv.Itoa(int(msg.ProposalId))),
|
|
},
|
|
)
|
|
|
|
ctx.EventManager().EmitEvent(
|
|
sdk.NewEvent(
|
|
sdk.EventTypeMessage,
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, types.AttributeValueCategory),
|
|
sdk.NewAttribute(sdk.AttributeKeySender, msg.Voter),
|
|
),
|
|
)
|
|
|
|
return &v1beta2.MsgVoteWeightedResponse{}, nil
|
|
}
|
|
|
|
func (k msgServer) Deposit(goCtx context.Context, msg *v1beta2.MsgDeposit) (*v1beta2.MsgDepositResponse, error) {
|
|
ctx := sdk.UnwrapSDKContext(goCtx)
|
|
accAddr, err := sdk.AccAddressFromBech32(msg.Depositor)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
votingStarted, err := k.Keeper.AddDeposit(ctx, msg.ProposalId, accAddr, msg.Amount)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
defer telemetry.IncrCounterWithLabels(
|
|
[]string{types.ModuleName, "deposit"},
|
|
1,
|
|
[]metrics.Label{
|
|
telemetry.NewLabel("proposal_id", strconv.Itoa(int(msg.ProposalId))),
|
|
},
|
|
)
|
|
|
|
ctx.EventManager().EmitEvent(
|
|
sdk.NewEvent(
|
|
sdk.EventTypeMessage,
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, types.AttributeValueCategory),
|
|
sdk.NewAttribute(sdk.AttributeKeySender, msg.Depositor),
|
|
),
|
|
)
|
|
|
|
if votingStarted {
|
|
ctx.EventManager().EmitEvent(
|
|
sdk.NewEvent(
|
|
types.EventTypeProposalDeposit,
|
|
sdk.NewAttribute(types.AttributeKeyVotingPeriodStart, fmt.Sprintf("%d", msg.ProposalId)),
|
|
),
|
|
)
|
|
}
|
|
|
|
return &v1beta2.MsgDepositResponse{}, nil
|
|
}
|
|
|
|
type legacyMsgServer struct {
|
|
govAcct string
|
|
server v1beta2.MsgServer
|
|
}
|
|
|
|
// NewLegacyMsgServerImpl returns an implementation of the v1beta1 legacy MsgServer interface. It wraps around
|
|
// the current MsgServer
|
|
func NewLegacyMsgServerImpl(govAcct string, v1beta2Server v1beta2.MsgServer) v1beta1.MsgServer {
|
|
return &legacyMsgServer{govAcct: govAcct, server: v1beta2Server}
|
|
}
|
|
|
|
var _ v1beta1.MsgServer = legacyMsgServer{}
|
|
|
|
func (k legacyMsgServer) SubmitProposal(goCtx context.Context, msg *v1beta1.MsgSubmitProposal) (*v1beta1.MsgSubmitProposalResponse, error) {
|
|
contentMsg, err := v1beta2.NewLegacyContent(msg.GetContent(), k.govAcct)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error converting legacy content into proposal message: %w", err)
|
|
}
|
|
|
|
proposal, err := v1beta2.NewMsgSubmitProposal(
|
|
[]sdk.Msg{contentMsg},
|
|
msg.InitialDeposit,
|
|
msg.Proposer,
|
|
)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
resp, err := k.server.SubmitProposal(goCtx, proposal)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &v1beta1.MsgSubmitProposalResponse{ProposalId: resp.ProposalId}, nil
|
|
}
|
|
|
|
func (k legacyMsgServer) Vote(goCtx context.Context, msg *v1beta1.MsgVote) (*v1beta1.MsgVoteResponse, error) {
|
|
_, err := k.server.Vote(goCtx, &v1beta2.MsgVote{
|
|
ProposalId: msg.ProposalId,
|
|
Voter: msg.Voter,
|
|
Option: v1beta2.VoteOption(msg.Option),
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &v1beta1.MsgVoteResponse{}, nil
|
|
}
|
|
|
|
func (k legacyMsgServer) VoteWeighted(goCtx context.Context, msg *v1beta1.MsgVoteWeighted) (*v1beta1.MsgVoteWeightedResponse, error) {
|
|
opts := make([]*v1beta2.WeightedVoteOption, len(msg.Options))
|
|
for idx, opt := range msg.Options {
|
|
opts[idx] = &v1beta2.WeightedVoteOption{
|
|
Option: v1beta2.VoteOption(opt.Option),
|
|
Weight: opt.Weight.String(),
|
|
}
|
|
}
|
|
|
|
_, err := k.server.VoteWeighted(goCtx, &v1beta2.MsgVoteWeighted{
|
|
ProposalId: msg.ProposalId,
|
|
Voter: msg.Voter,
|
|
Options: opts,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &v1beta1.MsgVoteWeightedResponse{}, nil
|
|
}
|
|
|
|
func (k legacyMsgServer) Deposit(goCtx context.Context, msg *v1beta1.MsgDeposit) (*v1beta1.MsgDepositResponse, error) {
|
|
_, err := k.server.Deposit(goCtx, &v1beta2.MsgDeposit{
|
|
ProposalId: msg.ProposalId,
|
|
Depositor: msg.Depositor,
|
|
Amount: msg.Amount,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &v1beta1.MsgDepositResponse{}, nil
|
|
}
|