<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description The draft PR #9222 Closes: #7108 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> - implement proto definition for `Record` - rename `Info.go` to `legacyInfo.go` within `keyring` package - implement CLI `migrate` command that migrates all keys from legacyInfo to proto according to @robert-zaremba migration [algorithm](https://github.com/cosmos/cosmos-sdk/pull/9222/#discussion_r624683839) - remove legacy keybase entirely. - add `Migrate` and `MigrateAll` functions in `keyring.go` for single key and all keys migration - add tests - fix tests --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
70 lines
1.7 KiB
Go
70 lines
1.7 KiB
Go
package errors
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRegisterError(t *testing.T) {
|
|
var error *Error
|
|
// this is the number of errors registered by default in errors.go
|
|
registeredErrorsCount := 16
|
|
assert.Equal(t, len(registry.list()), registeredErrorsCount)
|
|
assert.ElementsMatch(t, registry.list(), ListErrors())
|
|
// add a new Error
|
|
error = RegisterError(69, "nice!", false, "nice!")
|
|
assert.NotNil(t, error)
|
|
// now we have a new error
|
|
registeredErrorsCount++
|
|
assert.Equal(t, len(ListErrors()), registeredErrorsCount)
|
|
// re-register an error should not change anything
|
|
error = RegisterError(69, "nice!", false, "nice!")
|
|
assert.Equal(t, len(ListErrors()), registeredErrorsCount)
|
|
|
|
// test sealing
|
|
assert.Equal(t, registry.sealed, false)
|
|
errors := SealAndListErrors()
|
|
assert.Equal(t, registry.sealed, true)
|
|
assert.Equal(t, len(errors), registeredErrorsCount)
|
|
// add a new error on a sealed registry
|
|
error = RegisterError(1024, "bytes", false, "bytes")
|
|
assert.NotNil(t, error)
|
|
|
|
}
|
|
|
|
func TestError_Error(t *testing.T) {
|
|
var error *Error
|
|
// nil cases
|
|
assert.False(t, ErrOffline.Is(error))
|
|
error = &Error{}
|
|
assert.False(t, ErrOffline.Is(error))
|
|
// wrong type
|
|
assert.False(t, ErrOffline.Is(&MyError{}))
|
|
// test with wrapping an error
|
|
error = WrapError(ErrOffline, "offline")
|
|
assert.True(t, ErrOffline.Is(error))
|
|
|
|
// test equality
|
|
assert.False(t, ErrOffline.Is(ErrBadGateway))
|
|
assert.True(t, ErrBadGateway.Is(ErrBadGateway))
|
|
}
|
|
|
|
func TestToRosetta(t *testing.T) {
|
|
var error *Error
|
|
// nil case
|
|
assert.NotNil(t, ToRosetta(error))
|
|
// wrong type
|
|
assert.NotNil(t, ToRosetta(&MyError{}))
|
|
}
|
|
|
|
type MyError struct {
|
|
}
|
|
|
|
func (e *MyError) Error() string {
|
|
return ""
|
|
}
|
|
func (e *MyError) Is(err error) bool {
|
|
return true
|
|
}
|