<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Revert routing queries through tendermint. The reason this change was made is because of this error: ``` fatal error: concurrent map read and map write ``` The person who identified this error submitted these steps to reproduce ``` User sends a query with grpc Tendermint Commit new blocks and tries to Commit IAVL (which causing IAVL versions map to change) At the same time query tries to read from the same map (iavl.(*MutableTree).VersionExists) to check if requested version is exists Node exits with fatal error: concurrent map read and map write ``` With the recent changes to IAVL submitted by terra (cc @YunSuk-Yeo) the reason for why we need to route through tendermint is no longer present. We should revert it when 0.17.1 of IAVL is cut, which will be later today. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
117 lines
3.1 KiB
Go
117 lines
3.1 KiB
Go
package client
|
|
|
|
import (
|
|
gocontext "context"
|
|
"fmt"
|
|
"reflect"
|
|
"strconv"
|
|
|
|
gogogrpc "github.com/gogo/protobuf/grpc"
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/grpc/encoding"
|
|
"google.golang.org/grpc/encoding/proto"
|
|
"google.golang.org/grpc/metadata"
|
|
|
|
"github.com/cosmos/cosmos-sdk/codec/types"
|
|
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
|
|
grpctypes "github.com/cosmos/cosmos-sdk/types/grpc"
|
|
"github.com/cosmos/cosmos-sdk/types/tx"
|
|
)
|
|
|
|
var _ gogogrpc.ClientConn = Context{}
|
|
|
|
var protoCodec = encoding.GetCodec(proto.Name)
|
|
|
|
// Invoke implements the grpc ClientConn.Invoke method
|
|
func (ctx Context) Invoke(grpcCtx gocontext.Context, method string, req, reply interface{}, opts ...grpc.CallOption) (err error) {
|
|
// Two things can happen here:
|
|
// 1. either we're broadcasting a Tx, in which call we call Tendermint's broadcast endpoint directly,
|
|
// 2. or we are querying for state, in which case we call ABCI's Query.
|
|
|
|
// In both cases, we don't allow empty request args (it will panic unexpectedly).
|
|
if reflect.ValueOf(req).IsNil() {
|
|
return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "request cannot be nil")
|
|
}
|
|
|
|
// Case 1. Broadcasting a Tx.
|
|
if reqProto, ok := req.(*tx.BroadcastTxRequest); ok {
|
|
res, ok := reply.(*tx.BroadcastTxResponse)
|
|
if !ok {
|
|
return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "expected %T, got %T", (*tx.BroadcastTxResponse)(nil), req)
|
|
}
|
|
|
|
broadcastRes, err := TxServiceBroadcast(grpcCtx, ctx, reqProto)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
*res = *broadcastRes
|
|
|
|
return err
|
|
}
|
|
|
|
// Case 2. Querying state.
|
|
reqBz, err := protoCodec.Marshal(req)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// parse height header
|
|
md, _ := metadata.FromOutgoingContext(grpcCtx)
|
|
if heights := md.Get(grpctypes.GRPCBlockHeightHeader); len(heights) > 0 {
|
|
height, err := strconv.ParseInt(heights[0], 10, 64)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if height < 0 {
|
|
return sdkerrors.Wrapf(
|
|
sdkerrors.ErrInvalidRequest,
|
|
"client.Context.Invoke: height (%d) from %q must be >= 0", height, grpctypes.GRPCBlockHeightHeader)
|
|
}
|
|
|
|
ctx = ctx.WithHeight(height)
|
|
}
|
|
|
|
abciReq := abci.RequestQuery{
|
|
Path: method,
|
|
Data: reqBz,
|
|
Height: ctx.Height,
|
|
}
|
|
|
|
res, err := ctx.QueryABCI(abciReq)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = protoCodec.Unmarshal(res.Value, reply)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Create header metadata. For now the headers contain:
|
|
// - block height
|
|
// We then parse all the call options, if the call option is a
|
|
// HeaderCallOption, then we manually set the value of that header to the
|
|
// metadata.
|
|
md = metadata.Pairs(grpctypes.GRPCBlockHeightHeader, strconv.FormatInt(res.Height, 10))
|
|
for _, callOpt := range opts {
|
|
header, ok := callOpt.(grpc.HeaderCallOption)
|
|
if !ok {
|
|
continue
|
|
}
|
|
|
|
*header.HeaderAddr = md
|
|
}
|
|
|
|
if ctx.InterfaceRegistry != nil {
|
|
return types.UnpackInterfaces(reply, ctx.InterfaceRegistry)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// NewStream implements the grpc ClientConn.NewStream method
|
|
func (Context) NewStream(gocontext.Context, *grpc.StreamDesc, string, ...grpc.CallOption) (grpc.ClientStream, error) {
|
|
return nil, fmt.Errorf("streaming rpc not supported")
|
|
}
|