9094794478
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: #8961 SDK allows InitGenesis to return with an empty validator set. In practice, the error for an empty validator set gets thrown in tendermint. To fix this, * Add non-empty validator set check to the `mm.InitGenesis` function. This will break `simapp.Setup` because it relies on an empty validator set [#comment](https://github.com/cosmos/cosmos-sdk/pull/8909#issuecomment-804850834). * Update `simapp.Setup` to use a single validator. * Fix failing tests (Most of them are keeper tests). <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
283 lines
10 KiB
Go
283 lines
10 KiB
Go
package keeper_test
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
|
|
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
"github.com/cosmos/cosmos-sdk/x/slashing/testslashing"
|
|
"github.com/cosmos/cosmos-sdk/x/staking"
|
|
"github.com/cosmos/cosmos-sdk/x/staking/teststaking"
|
|
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
|
|
)
|
|
|
|
func TestUnJailNotBonded(t *testing.T) {
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
|
|
p := app.StakingKeeper.GetParams(ctx)
|
|
p.MaxValidators = 5
|
|
app.StakingKeeper.SetParams(ctx, p)
|
|
|
|
addrDels := simapp.AddTestAddrsIncremental(app, ctx, 6, app.StakingKeeper.TokensFromConsensusPower(ctx, 200))
|
|
valAddrs := simapp.ConvertAddrsToValAddrs(addrDels)
|
|
pks := simapp.CreateTestPubKeys(6)
|
|
tstaking := teststaking.NewHelper(t, ctx, app.StakingKeeper)
|
|
|
|
// create max (5) validators all with the same power
|
|
for i := uint32(0); i < p.MaxValidators; i++ {
|
|
addr, val := valAddrs[i], pks[i]
|
|
tstaking.CreateValidatorWithValPower(addr, val, 100, true)
|
|
}
|
|
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
ctx = ctx.WithBlockHeight(ctx.BlockHeight() + 1)
|
|
|
|
// create a 6th validator with less power than the cliff validator (won't be bonded)
|
|
addr, val := valAddrs[5], pks[5]
|
|
amt := app.StakingKeeper.TokensFromConsensusPower(ctx, 50)
|
|
msg := tstaking.CreateValidatorMsg(addr, val, amt)
|
|
msg.MinSelfDelegation = amt
|
|
res, err := tstaking.CreateValidatorWithMsg(sdk.WrapSDKContext(ctx), msg)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, res)
|
|
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
ctx = ctx.WithBlockHeight(ctx.BlockHeight() + 1)
|
|
|
|
tstaking.CheckValidator(addr, stakingtypes.Unbonded, false)
|
|
|
|
// unbond below minimum self-delegation
|
|
require.Equal(t, p.BondDenom, tstaking.Denom)
|
|
tstaking.Undelegate(sdk.AccAddress(addr), addr, app.StakingKeeper.TokensFromConsensusPower(ctx, 1), true)
|
|
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
ctx = ctx.WithBlockHeight(ctx.BlockHeight() + 1)
|
|
|
|
// verify that validator is jailed
|
|
tstaking.CheckValidator(addr, -1, true)
|
|
|
|
// verify we cannot unjail (yet)
|
|
require.Error(t, app.SlashingKeeper.Unjail(ctx, addr))
|
|
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
ctx = ctx.WithBlockHeight(ctx.BlockHeight() + 1)
|
|
// bond to meet minimum self-delegation
|
|
tstaking.DelegateWithPower(sdk.AccAddress(addr), addr, 1)
|
|
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
ctx = ctx.WithBlockHeight(ctx.BlockHeight() + 1)
|
|
|
|
// verify we can immediately unjail
|
|
require.NoError(t, app.SlashingKeeper.Unjail(ctx, addr))
|
|
|
|
tstaking.CheckValidator(addr, -1, false)
|
|
}
|
|
|
|
// Test a new validator entering the validator set
|
|
// Ensure that SigningInfo.StartHeight is set correctly
|
|
// and that they are not immediately jailed
|
|
func TestHandleNewValidator(t *testing.T) {
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
|
|
addrDels := simapp.AddTestAddrsIncremental(app, ctx, 1, app.StakingKeeper.TokensFromConsensusPower(ctx, 200))
|
|
valAddrs := simapp.ConvertAddrsToValAddrs(addrDels)
|
|
pks := simapp.CreateTestPubKeys(1)
|
|
addr, val := valAddrs[0], pks[0]
|
|
tstaking := teststaking.NewHelper(t, ctx, app.StakingKeeper)
|
|
ctx = ctx.WithBlockHeight(app.SlashingKeeper.SignedBlocksWindow(ctx) + 1)
|
|
|
|
// Validator created
|
|
amt := tstaking.CreateValidatorWithValPower(addr, val, 100, true)
|
|
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
require.Equal(
|
|
t, app.BankKeeper.GetAllBalances(ctx, sdk.AccAddress(addr)),
|
|
sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.GetParams(ctx).BondDenom, InitTokens.Sub(amt))),
|
|
)
|
|
require.Equal(t, amt, app.StakingKeeper.Validator(ctx, addr).GetBondedTokens())
|
|
|
|
// Now a validator, for two blocks
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), 100, true)
|
|
ctx = ctx.WithBlockHeight(app.SlashingKeeper.SignedBlocksWindow(ctx) + 2)
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), 100, false)
|
|
|
|
info, found := app.SlashingKeeper.GetValidatorSigningInfo(ctx, sdk.ConsAddress(val.Address()))
|
|
require.True(t, found)
|
|
require.Equal(t, app.SlashingKeeper.SignedBlocksWindow(ctx)+1, info.StartHeight)
|
|
require.Equal(t, int64(2), info.IndexOffset)
|
|
require.Equal(t, int64(1), info.MissedBlocksCounter)
|
|
require.Equal(t, time.Unix(0, 0).UTC(), info.JailedUntil)
|
|
|
|
// validator should be bonded still, should not have been jailed or slashed
|
|
validator, _ := app.StakingKeeper.GetValidatorByConsAddr(ctx, sdk.GetConsAddress(val))
|
|
require.Equal(t, stakingtypes.Bonded, validator.GetStatus())
|
|
bondPool := app.StakingKeeper.GetBondedPool(ctx)
|
|
expTokens := app.StakingKeeper.TokensFromConsensusPower(ctx, 100)
|
|
// adding genesis validator tokens
|
|
expTokens = expTokens.Add(app.StakingKeeper.TokensFromConsensusPower(ctx, 1))
|
|
require.True(t, expTokens.Equal(app.BankKeeper.GetBalance(ctx, bondPool.GetAddress(), app.StakingKeeper.BondDenom(ctx)).Amount))
|
|
}
|
|
|
|
// Test a jailed validator being "down" twice
|
|
// Ensure that they're only slashed once
|
|
func TestHandleAlreadyJailed(t *testing.T) {
|
|
// initial setup
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
|
|
addrDels := simapp.AddTestAddrsIncremental(app, ctx, 1, app.StakingKeeper.TokensFromConsensusPower(ctx, 200))
|
|
valAddrs := simapp.ConvertAddrsToValAddrs(addrDels)
|
|
pks := simapp.CreateTestPubKeys(1)
|
|
addr, val := valAddrs[0], pks[0]
|
|
power := int64(100)
|
|
tstaking := teststaking.NewHelper(t, ctx, app.StakingKeeper)
|
|
|
|
amt := tstaking.CreateValidatorWithValPower(addr, val, power, true)
|
|
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
|
|
// 1000 first blocks OK
|
|
height := int64(0)
|
|
for ; height < app.SlashingKeeper.SignedBlocksWindow(ctx); height++ {
|
|
ctx = ctx.WithBlockHeight(height)
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), power, true)
|
|
}
|
|
|
|
// 501 blocks missed
|
|
for ; height < app.SlashingKeeper.SignedBlocksWindow(ctx)+(app.SlashingKeeper.SignedBlocksWindow(ctx)-app.SlashingKeeper.MinSignedPerWindow(ctx))+1; height++ {
|
|
ctx = ctx.WithBlockHeight(height)
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), power, false)
|
|
}
|
|
|
|
// end block
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
|
|
// validator should have been jailed and slashed
|
|
validator, _ := app.StakingKeeper.GetValidatorByConsAddr(ctx, sdk.GetConsAddress(val))
|
|
require.Equal(t, stakingtypes.Unbonding, validator.GetStatus())
|
|
|
|
// validator should have been slashed
|
|
resultingTokens := amt.Sub(app.StakingKeeper.TokensFromConsensusPower(ctx, 1))
|
|
require.Equal(t, resultingTokens, validator.GetTokens())
|
|
|
|
// another block missed
|
|
ctx = ctx.WithBlockHeight(height)
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), power, false)
|
|
|
|
// validator should not have been slashed twice
|
|
validator, _ = app.StakingKeeper.GetValidatorByConsAddr(ctx, sdk.GetConsAddress(val))
|
|
require.Equal(t, resultingTokens, validator.GetTokens())
|
|
}
|
|
|
|
// Test a validator dipping in and out of the validator set
|
|
// Ensure that missed blocks are tracked correctly and that
|
|
// the start height of the signing info is reset correctly
|
|
func TestValidatorDippingInAndOut(t *testing.T) {
|
|
|
|
// initial setup
|
|
// TestParams set the SignedBlocksWindow to 1000 and MaxMissedBlocksPerWindow to 500
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
app.SlashingKeeper.SetParams(ctx, testslashing.TestParams())
|
|
|
|
params := app.StakingKeeper.GetParams(ctx)
|
|
params.MaxValidators = 1
|
|
app.StakingKeeper.SetParams(ctx, params)
|
|
power := int64(100)
|
|
|
|
pks := simapp.CreateTestPubKeys(3)
|
|
simapp.AddTestAddrsFromPubKeys(app, ctx, pks, app.StakingKeeper.TokensFromConsensusPower(ctx, 200))
|
|
|
|
addr, val := pks[0].Address(), pks[0]
|
|
consAddr := sdk.ConsAddress(addr)
|
|
tstaking := teststaking.NewHelper(t, ctx, app.StakingKeeper)
|
|
valAddr := sdk.ValAddress(addr)
|
|
|
|
tstaking.CreateValidatorWithValPower(valAddr, val, power, true)
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
|
|
// 100 first blocks OK
|
|
height := int64(0)
|
|
for ; height < int64(100); height++ {
|
|
ctx = ctx.WithBlockHeight(height)
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), power, true)
|
|
}
|
|
|
|
// kick first validator out of validator set
|
|
tstaking.CreateValidatorWithValPower(sdk.ValAddress(pks[1].Address()), pks[1], 101, true)
|
|
validatorUpdates := staking.EndBlocker(ctx, app.StakingKeeper)
|
|
require.Equal(t, 2, len(validatorUpdates))
|
|
tstaking.CheckValidator(valAddr, stakingtypes.Unbonding, false)
|
|
|
|
// 600 more blocks happened
|
|
height = 700
|
|
ctx = ctx.WithBlockHeight(height)
|
|
|
|
// validator added back in
|
|
tstaking.DelegateWithPower(sdk.AccAddress(pks[2].Address()), sdk.ValAddress(pks[0].Address()), 50)
|
|
|
|
validatorUpdates = staking.EndBlocker(ctx, app.StakingKeeper)
|
|
require.Equal(t, 2, len(validatorUpdates))
|
|
tstaking.CheckValidator(valAddr, stakingtypes.Bonded, false)
|
|
newPower := int64(150)
|
|
|
|
// validator misses a block
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), newPower, false)
|
|
height++
|
|
|
|
// shouldn't be jailed/kicked yet
|
|
tstaking.CheckValidator(valAddr, stakingtypes.Bonded, false)
|
|
|
|
// validator misses 500 more blocks, 501 total
|
|
latest := height
|
|
for ; height < latest+500; height++ {
|
|
ctx = ctx.WithBlockHeight(height)
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), newPower, false)
|
|
}
|
|
|
|
// should now be jailed & kicked
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
tstaking.CheckValidator(valAddr, stakingtypes.Unbonding, true)
|
|
|
|
// check all the signing information
|
|
signInfo, found := app.SlashingKeeper.GetValidatorSigningInfo(ctx, consAddr)
|
|
require.True(t, found)
|
|
require.Equal(t, int64(0), signInfo.MissedBlocksCounter)
|
|
require.Equal(t, int64(0), signInfo.IndexOffset)
|
|
// array should be cleared
|
|
for offset := int64(0); offset < app.SlashingKeeper.SignedBlocksWindow(ctx); offset++ {
|
|
missed := app.SlashingKeeper.GetValidatorMissedBlockBitArray(ctx, consAddr, offset)
|
|
require.False(t, missed)
|
|
}
|
|
|
|
// some blocks pass
|
|
height = int64(5000)
|
|
ctx = ctx.WithBlockHeight(height)
|
|
|
|
// validator rejoins and starts signing again
|
|
app.StakingKeeper.Unjail(ctx, consAddr)
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), newPower, true)
|
|
height++
|
|
|
|
// validator should not be kicked since we reset counter/array when it was jailed
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
tstaking.CheckValidator(valAddr, stakingtypes.Bonded, false)
|
|
|
|
// validator misses 501 blocks
|
|
latest = height
|
|
for ; height < latest+501; height++ {
|
|
ctx = ctx.WithBlockHeight(height)
|
|
app.SlashingKeeper.HandleValidatorSignature(ctx, val.Address(), newPower, false)
|
|
}
|
|
|
|
// validator should now be jailed & kicked
|
|
staking.EndBlocker(ctx, app.StakingKeeper)
|
|
tstaking.CheckValidator(valAddr, stakingtypes.Unbonding, true)
|
|
}
|