28541e7ca3
## Description Closes: #10565 Rename mentions of "group account" (in proto files, code, docs, etc.) to "group policy" in group module. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
47 lines
1.6 KiB
Go
47 lines
1.6 KiB
Go
package keeper
|
|
|
|
import (
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
"github.com/cosmos/cosmos-sdk/types/errors"
|
|
authmiddleware "github.com/cosmos/cosmos-sdk/x/auth/middleware"
|
|
"github.com/cosmos/cosmos-sdk/x/group"
|
|
grouperrors "github.com/cosmos/cosmos-sdk/x/group/errors"
|
|
)
|
|
|
|
// doExecuteMsgs routes the messages to the registered handlers. Messages are limited to those that require no authZ or
|
|
// by the account of group policy only. Otherwise this gives access to other peoples accounts as the sdk ant handler is bypassed
|
|
func (s Keeper) doExecuteMsgs(ctx sdk.Context, router *authmiddleware.MsgServiceRouter, proposal group.Proposal, groupPolicyAcc sdk.AccAddress) ([]sdk.Result, error) {
|
|
msgs := proposal.GetMsgs()
|
|
|
|
results := make([]sdk.Result, len(msgs))
|
|
if err := ensureMsgAuthZ(msgs, groupPolicyAcc); err != nil {
|
|
return nil, err
|
|
}
|
|
for i, msg := range msgs {
|
|
handler := s.router.Handler(msg)
|
|
if handler == nil {
|
|
return nil, errors.Wrapf(grouperrors.ErrInvalid, "no message handler found for %q", sdk.MsgTypeURL(msg))
|
|
}
|
|
r, err := handler(ctx, msg)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "message %q at position %d", msg, i)
|
|
}
|
|
if r != nil {
|
|
results[i] = *r
|
|
}
|
|
}
|
|
return results, nil
|
|
}
|
|
|
|
// ensureMsgAuthZ checks that if a message requires signers that all of them are equal to the given account address of group policy.
|
|
func ensureMsgAuthZ(msgs []sdk.Msg, groupPolicyAcc sdk.AccAddress) error {
|
|
for i := range msgs {
|
|
for _, acct := range msgs[i].GetSigners() {
|
|
if !groupPolicyAcc.Equals(acct) {
|
|
return errors.Wrap(errors.ErrUnauthorized, "msg does not have group policy authorization")
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|