LaconicNetwork/cosmos-sdk
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity
58597139fa
cosmos-sdk/x/group/genesis_test.go
Marie Gauthier f52d87003c
feat: Add simulations to group module (#10723) 
## Description

Closes: #9901



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-01-21 10:52:26 +00:00

751 lines
16 KiB
Go
Raw Blame History

package group
import (
"testing"
"time"
"github.com/cosmos/cosmos-sdk/crypto/keys/secp256k1"
sdk "github.com/cosmos/cosmos-sdk/types"
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
"github.com/stretchr/testify/require"
)
var (
memberPub = secp256k1.GenPrivKey().PubKey()
accPub = secp256k1.GenPrivKey().PubKey()
accAddr = sdk.AccAddress(accPub.Address())
memberAddr = sdk.AccAddress(memberPub.Address())
)
func TestGenesisStateValidate(t *testing.T) {
submittedAt := time.Now().UTC()
timeout := submittedAt.Add(time.Second * 1).UTC()
groupPolicy := &GroupPolicyInfo{
Address: accAddr.String(),
GroupId: 1,
Admin: accAddr.String(),
Version: 1,
Metadata: []byte("policy metadata"),
}
err := groupPolicy.SetDecisionPolicy(&ThresholdDecisionPolicy{
Threshold: "1",
Timeout: time.Second,
})
require.NoError(t, err)
// create another group policy to set invalid decision policy for testing
groupPolicy2 := &GroupPolicyInfo{
Address: accAddr.String(),
GroupId: 1,
Admin: accAddr.String(),
Version: 1,
Metadata: []byte("policy metadata"),
}
err = groupPolicy2.SetDecisionPolicy(&ThresholdDecisionPolicy{
Threshold: "1",
Timeout: 0,
})
require.NoError(t, err)
proposal := &Proposal{
ProposalId: 1,
Address: accAddr.String(),
Metadata: []byte("proposal metadata"),
GroupVersion: 1,
GroupPolicyVersion: 1,
Proposers: []string{
memberAddr.String(),
},
SubmittedAt: submittedAt,
Status: ProposalStatusClosed,
Result: ProposalResultAccepted,
VoteState: Tally{
YesCount: "1",
NoCount: "0",
AbstainCount: "0",
VetoCount: "0",
},
Timeout: timeout,
ExecutorResult: ProposalExecutorResultSuccess,
}
err = proposal.SetMsgs([]sdk.Msg{&banktypes.MsgSend{
FromAddress: accAddr.String(),
ToAddress: memberAddr.String(),
Amount: sdk.Coins{sdk.NewInt64Coin("test", 100)},
}})
require.NoError(t, err)
testCases := []struct {
name string
genesisState GenesisState
expErr bool
}{
{
"valid genesisState",
GenesisState{
GroupSeq: 2,
Groups: []*GroupInfo{{GroupId: 1, Admin: accAddr.String(), Metadata: []byte("1"), Version: 1, TotalWeight: "1"}, {GroupId: 2, Admin: accAddr.String(), Metadata: []byte("2"), Version: 2, TotalWeight: "2"}},
GroupMembers: []*GroupMember{{GroupId: 1, Member: &Member{Address: memberAddr.String(), Weight: "1", Metadata: []byte("member metadata")}}, {GroupId: 2, Member: &Member{Address: memberAddr.String(), Weight: "2", Metadata: []byte("member metadata")}}},
GroupPolicySeq: 1,
GroupPolicies: []*GroupPolicyInfo{groupPolicy},
ProposalSeq: 1,
Proposals: []*Proposal{proposal},
Votes: []*Vote{{ProposalId: proposal.ProposalId, Voter: memberAddr.String(), SubmittedAt: submittedAt, Choice: Choice_CHOICE_YES}},
},
false,
},
{
"empty genesisState",
GenesisState{},
false,
},
{
"empty group id",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 0,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
},
true,
},
{
"invalid group admin",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: "invalid admin",
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
},
true,
},
{
"invalid group version",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 0,
TotalWeight: "1",
},
},
},
true,
},
{
"invalid group TotalWeight",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "-1",
},
},
},
true,
},
{
"invalid group policy address",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
{
Address: "invalid address",
GroupId: 1,
Admin: accAddr.String(),
Version: 1,
Metadata: []byte("policy metadata"),
},
},
},
true,
},
{
"invalid group policy admin",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
{
Address: accAddr.String(),
GroupId: 1,
Admin: "invalid admin",
Version: 1,
Metadata: []byte("policy metadata"),
},
},
},
true,
},
{
"invalid group policy's group id",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
{
Address: accAddr.String(),
GroupId: 0,
Admin: accAddr.String(),
Version: 1,
Metadata: []byte("policy metadata"),
},
},
},
true,
},
{
"invalid group policy version",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
{
Address: accAddr.String(),
GroupId: 1,
Admin: accAddr.String(),
Version: 0,
Metadata: []byte("policy metadata"),
},
},
},
true,
},
{
"invalid group policy's decision policy",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
{
Address: accAddr.String(),
GroupId: 1,
Admin: accAddr.String(),
Version: 1,
Metadata: []byte("policy metadata"),
DecisionPolicy: groupPolicy2.DecisionPolicy,
},
},
},
true,
},
{
"invalid group member's group id",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupMembers: []*GroupMember{
{
GroupId: 0,
Member: &Member{
Address: memberAddr.String(),
Weight: "1", Metadata: []byte("member metadata"),
},
},
},
},
true,
},
{
"invalid group member address",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupMembers: []*GroupMember{
{
GroupId: 1,
Member: &Member{
Address: "invalid address",
Weight: "1", Metadata: []byte("member metadata"),
},
},
},
},
true,
},
{
"invalid group member weight",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupMembers: []*GroupMember{
{
GroupId: 1,
Member: &Member{
Address: memberAddr.String(),
Weight: "-1", Metadata: []byte("member metadata"),
},
},
},
},
true,
},
{
"invalid proposal id",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
{
ProposalId: 0,
Address: accAddr.String(),
Metadata: []byte("proposal metadata"),
GroupVersion: 1,
GroupPolicyVersion: 1,
},
},
},
true,
},
{
"invalid group policy address of proposal",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
{
ProposalId: 1,
Address: "invalid address",
Metadata: []byte("proposal metadata"),
GroupVersion: 1,
GroupPolicyVersion: 1,
},
},
},
true,
},
{
"invalid group version of proposal",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
{
ProposalId: 1,
Address: accAddr.String(),
Metadata: []byte("proposal metadata"),
GroupVersion: 0,
GroupPolicyVersion: 1,
},
},
},
true,
},
{
"invalid group policy version",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
{
ProposalId: 1,
Address: accAddr.String(),
Metadata: []byte("proposal metadata"),
GroupVersion: 1,
GroupPolicyVersion: 0,
},
},
},
true,
},
{
"invalid VoteState with negative YesCount",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
{
ProposalId: 1,
Address: accAddr.String(),
Metadata: []byte("proposal metadata"),
GroupVersion: 1,
GroupPolicyVersion: 1,
Proposers: []string{
memberAddr.String(),
},
SubmittedAt: submittedAt,
Status: ProposalStatusClosed,
Result: ProposalResultAccepted,
VoteState: Tally{
YesCount: "-1",
NoCount: "0",
AbstainCount: "0",
VetoCount: "0",
},
},
},
},
true,
},
{
"invalid VoteState with negative NoCount",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
{
ProposalId: 1,
Address: accAddr.String(),
Metadata: []byte("proposal metadata"),
GroupVersion: 1,
GroupPolicyVersion: 1,
Proposers: []string{
memberAddr.String(),
},
SubmittedAt: submittedAt,
Status: ProposalStatusClosed,
Result: ProposalResultAccepted,
VoteState: Tally{
YesCount: "0",
NoCount: "-1",
AbstainCount: "0",
VetoCount: "0",
},
},
},
},
true,
},
{
"invalid VoteState with negative AbstainCount",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
{
ProposalId: 1,
Address: accAddr.String(),
Metadata: []byte("proposal metadata"),
GroupVersion: 1,
GroupPolicyVersion: 1,
Proposers: []string{
memberAddr.String(),
},
SubmittedAt: submittedAt,
Status: ProposalStatusClosed,
Result: ProposalResultAccepted,
VoteState: Tally{
YesCount: "0",
NoCount: "0",
AbstainCount: "-1",
VetoCount: "0",
},
},
},
},
true,
},
{
"invalid VoteState with negative VetoCount",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
{
ProposalId: 1,
Address: accAddr.String(),
Metadata: []byte("proposal metadata"),
GroupVersion: 1,
GroupPolicyVersion: 1,
Proposers: []string{
memberAddr.String(),
},
SubmittedAt: submittedAt,
Status: ProposalStatusClosed,
Result: ProposalResultAccepted,
VoteState: Tally{
YesCount: "0",
NoCount: "0",
AbstainCount: "0",
VetoCount: "-1",
},
},
},
},
true,
},
{
"invalid voter",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
proposal,
},
Votes: []*Vote{
{
ProposalId: proposal.ProposalId,
Voter: "invalid voter",
SubmittedAt: submittedAt,
Choice: Choice_CHOICE_YES,
},
},
},
true,
},
{
"invalid proposal id",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
proposal,
},
Votes: []*Vote{
{
ProposalId: 0,
Voter: memberAddr.String(),
SubmittedAt: submittedAt,
Choice: Choice_CHOICE_YES,
},
},
},
true,
},
{
"vote on proposal that doesn't exist",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
proposal,
},
Votes: []*Vote{
{
ProposalId: 2,
Voter: memberAddr.String(),
SubmittedAt: submittedAt,
Choice: Choice_CHOICE_YES,
},
},
},
true,
},
{
"invalid choice",
GenesisState{
Groups: []*GroupInfo{
{
GroupId: 1,
Admin: accAddr.String(),
Metadata: []byte("1"),
Version: 1,
TotalWeight: "1",
},
},
GroupPolicies: []*GroupPolicyInfo{
groupPolicy,
},
Proposals: []*Proposal{
proposal,
},
Votes: []*Vote{
{
ProposalId: proposal.ProposalId,
Voter: memberAddr.String(),
SubmittedAt: submittedAt,
Choice: Choice_CHOICE_UNSPECIFIED,
},
},
},
true,
},
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
err := tc.genesisState.Validate()
if tc.expErr {
require.Error(t, err)
} else {
require.NoError(t, err)
}
})
}
}
Reference in New Issue View Git Blame Copy Permalink