9094794478
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: #8961 SDK allows InitGenesis to return with an empty validator set. In practice, the error for an empty validator set gets thrown in tendermint. To fix this, * Add non-empty validator set check to the `mm.InitGenesis` function. This will break `simapp.Setup` because it relies on an empty validator set [#comment](https://github.com/cosmos/cosmos-sdk/pull/8909#issuecomment-804850834). * Update `simapp.Setup` to use a single validator. * Fix failing tests (Most of them are keeper tests). <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
77 lines
2.5 KiB
Go
77 lines
2.5 KiB
Go
package distribution_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
|
|
|
|
"github.com/cosmos/cosmos-sdk/crypto/keys/ed25519"
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
"github.com/cosmos/cosmos-sdk/x/bank/testutil"
|
|
"github.com/cosmos/cosmos-sdk/x/distribution"
|
|
"github.com/cosmos/cosmos-sdk/x/distribution/types"
|
|
)
|
|
|
|
var (
|
|
delPk1 = ed25519.GenPrivKey().PubKey()
|
|
delAddr1 = sdk.AccAddress(delPk1.Address())
|
|
|
|
amount = sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(1)))
|
|
)
|
|
|
|
func testProposal(recipient sdk.AccAddress, amount sdk.Coins) *types.CommunityPoolSpendProposal {
|
|
return types.NewCommunityPoolSpendProposal("Test", "description", recipient, amount)
|
|
}
|
|
|
|
func TestProposalHandlerPassed(t *testing.T) {
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
|
|
recipient := delAddr1
|
|
|
|
// add coins to the module account
|
|
macc := app.DistrKeeper.GetDistributionAccount(ctx)
|
|
balances := app.BankKeeper.GetAllBalances(ctx, macc.GetAddress())
|
|
require.NoError(t, testutil.FundModuleAccount(app.BankKeeper, ctx, macc.GetName(), amount))
|
|
|
|
app.AccountKeeper.SetModuleAccount(ctx, macc)
|
|
|
|
account := app.AccountKeeper.NewAccountWithAddress(ctx, recipient)
|
|
app.AccountKeeper.SetAccount(ctx, account)
|
|
require.True(t, app.BankKeeper.GetAllBalances(ctx, account.GetAddress()).IsZero())
|
|
|
|
feePool := app.DistrKeeper.GetFeePool(ctx)
|
|
feePool.CommunityPool = sdk.NewDecCoinsFromCoins(amount...)
|
|
app.DistrKeeper.SetFeePool(ctx, feePool)
|
|
|
|
tp := testProposal(recipient, amount)
|
|
hdlr := distribution.NewCommunityPoolSpendProposalHandler(app.DistrKeeper)
|
|
require.NoError(t, hdlr(ctx, tp))
|
|
|
|
balances = app.BankKeeper.GetAllBalances(ctx, recipient)
|
|
require.Equal(t, balances, amount)
|
|
}
|
|
|
|
func TestProposalHandlerFailed(t *testing.T) {
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
|
|
// reset fee pool
|
|
app.DistrKeeper.SetFeePool(ctx, types.InitialFeePool())
|
|
|
|
recipient := delAddr1
|
|
|
|
account := app.AccountKeeper.NewAccountWithAddress(ctx, recipient)
|
|
app.AccountKeeper.SetAccount(ctx, account)
|
|
require.True(t, app.BankKeeper.GetAllBalances(ctx, account.GetAddress()).IsZero())
|
|
|
|
tp := testProposal(recipient, amount)
|
|
hdlr := distribution.NewCommunityPoolSpendProposalHandler(app.DistrKeeper)
|
|
require.Error(t, hdlr(ctx, tp))
|
|
|
|
balances := app.BankKeeper.GetAllBalances(ctx, recipient)
|
|
require.True(t, balances.IsZero())
|
|
}
|