<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Apply post-merge reviews to a previous PR ref: https://github.com/cosmos/cosmos-sdk/pull/9754#pullrequestreview-713819730 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
171 lines
4.9 KiB
Go
171 lines
4.9 KiB
Go
package tx
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"google.golang.org/protobuf/encoding/protowire"
|
|
|
|
"github.com/cosmos/cosmos-sdk/codec"
|
|
"github.com/cosmos/cosmos-sdk/codec/unknownproto"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
|
|
"github.com/cosmos/cosmos-sdk/types/tx"
|
|
)
|
|
|
|
// DefaultTxDecoder returns a default protobuf TxDecoder using the provided Marshaler.
|
|
func DefaultTxDecoder(cdc codec.ProtoCodecMarshaler) sdk.TxDecoder {
|
|
return func(txBytes []byte) (sdk.Tx, error) {
|
|
// Make sure txBytes follow ADR-027.
|
|
err := rejectNonADR027TxRaw(txBytes)
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrTxDecode, err.Error())
|
|
}
|
|
|
|
var raw tx.TxRaw
|
|
|
|
// reject all unknown proto fields in the root TxRaw
|
|
err = unknownproto.RejectUnknownFieldsStrict(txBytes, &raw, cdc.InterfaceRegistry())
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrTxDecode, err.Error())
|
|
}
|
|
|
|
err = cdc.Unmarshal(txBytes, &raw)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var body tx.TxBody
|
|
|
|
// allow non-critical unknown fields in TxBody
|
|
txBodyHasUnknownNonCriticals, err := unknownproto.RejectUnknownFields(raw.BodyBytes, &body, true, cdc.InterfaceRegistry())
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrTxDecode, err.Error())
|
|
}
|
|
|
|
err = cdc.Unmarshal(raw.BodyBytes, &body)
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrTxDecode, err.Error())
|
|
}
|
|
|
|
var authInfo tx.AuthInfo
|
|
|
|
// reject all unknown proto fields in AuthInfo
|
|
err = unknownproto.RejectUnknownFieldsStrict(raw.AuthInfoBytes, &authInfo, cdc.InterfaceRegistry())
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrTxDecode, err.Error())
|
|
}
|
|
|
|
err = cdc.Unmarshal(raw.AuthInfoBytes, &authInfo)
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrTxDecode, err.Error())
|
|
}
|
|
|
|
theTx := &tx.Tx{
|
|
Body: &body,
|
|
AuthInfo: &authInfo,
|
|
Signatures: raw.Signatures,
|
|
}
|
|
|
|
return &wrapper{
|
|
tx: theTx,
|
|
bodyBz: raw.BodyBytes,
|
|
authInfoBz: raw.AuthInfoBytes,
|
|
txBodyHasUnknownNonCriticals: txBodyHasUnknownNonCriticals,
|
|
}, nil
|
|
}
|
|
}
|
|
|
|
// DefaultJSONTxDecoder returns a default protobuf JSON TxDecoder using the provided Marshaler.
|
|
func DefaultJSONTxDecoder(cdc codec.ProtoCodecMarshaler) sdk.TxDecoder {
|
|
return func(txBytes []byte) (sdk.Tx, error) {
|
|
var theTx tx.Tx
|
|
err := cdc.UnmarshalJSON(txBytes, &theTx)
|
|
if err != nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrTxDecode, err.Error())
|
|
}
|
|
|
|
return &wrapper{
|
|
tx: &theTx,
|
|
}, nil
|
|
}
|
|
}
|
|
|
|
// rejectNonADR027TxRaw rejects txBytes that do not follow ADR-027. This is NOT
|
|
// a generic ADR-027 checker, it only applies decoding TxRaw. Specifically, it
|
|
// only checks that:
|
|
// - field numbers are in ascending order (1, 2, and potentially multiple 3s),
|
|
// - and varints are as short as possible.
|
|
// All other ADR-027 edge cases (e.g. default values) are not applicable with
|
|
// TxRaw.
|
|
func rejectNonADR027TxRaw(txBytes []byte) error {
|
|
// Make sure all fields are ordered in ascending order with this variable.
|
|
prevTagNum := protowire.Number(0)
|
|
|
|
for len(txBytes) > 0 {
|
|
tagNum, wireType, m := protowire.ConsumeTag(txBytes)
|
|
if m < 0 {
|
|
return fmt.Errorf("invalid length; %w", protowire.ParseError(m))
|
|
}
|
|
// TxRaw only has bytes fields.
|
|
if wireType != protowire.BytesType {
|
|
return fmt.Errorf("expected %d wire type, got %d", protowire.BytesType, wireType)
|
|
}
|
|
// Make sure fields are ordered in ascending order.
|
|
if tagNum < prevTagNum {
|
|
return fmt.Errorf("txRaw must follow ADR-027, got tagNum %d after tagNum %d", tagNum, prevTagNum)
|
|
}
|
|
prevTagNum = tagNum
|
|
|
|
// All 3 fields of TxRaw have wireType == 2, so their next component
|
|
// is a varint, so we can safely call ConsumeVarint here.
|
|
// Byte structure: <varint of bytes length><bytes sequence>
|
|
// Inner fields are verified in `DefaultTxDecoder`
|
|
lengthPrefix, m := protowire.ConsumeVarint(txBytes[m:])
|
|
if m < 0 {
|
|
return fmt.Errorf("invalid length; %w", protowire.ParseError(m))
|
|
}
|
|
// We make sure that this varint is as short as possible.
|
|
n := varintMinLength(lengthPrefix)
|
|
if n != m {
|
|
return fmt.Errorf("length prefix varint for tagNum %d is not as short as possible, read %d, only need %d", tagNum, m, n)
|
|
}
|
|
|
|
// Skip over the bytes that store fieldNumber and wireType bytes.
|
|
_, _, m = protowire.ConsumeField(txBytes)
|
|
if m < 0 {
|
|
return fmt.Errorf("invalid length; %w", protowire.ParseError(m))
|
|
}
|
|
txBytes = txBytes[m:]
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// varintMinLength returns the minimum number of bytes necessary to encode an
|
|
// uint using varint encoding.
|
|
func varintMinLength(n uint64) int {
|
|
switch {
|
|
// Note: 1<<N == 2**N.
|
|
case n < 1<<(7):
|
|
return 1
|
|
case n < 1<<(7*2):
|
|
return 2
|
|
case n < 1<<(7*3):
|
|
return 3
|
|
case n < 1<<(7*4):
|
|
return 4
|
|
case n < 1<<(7*5):
|
|
return 5
|
|
case n < 1<<(7*6):
|
|
return 6
|
|
case n < 1<<(7*7):
|
|
return 7
|
|
case n < 1<<(7*8):
|
|
return 8
|
|
case n < 1<<(7*9):
|
|
return 9
|
|
default:
|
|
return 10
|
|
}
|
|
}
|