Closes: #10769 ## Description Solution: - create a `WithBranchedStore ` to handle state snapshot and revert - extract `ConsumeBlockGasMiddleware ` out from `RecoveryTxMiddleware`. - order the middlewares properly. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
122 lines
4.5 KiB
Go
122 lines
4.5 KiB
Go
package middleware
|
|
|
|
import (
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
|
|
"github.com/cosmos/cosmos-sdk/types/tx"
|
|
"github.com/cosmos/cosmos-sdk/types/tx/signing"
|
|
authsigning "github.com/cosmos/cosmos-sdk/x/auth/signing"
|
|
"github.com/cosmos/cosmos-sdk/x/auth/types"
|
|
)
|
|
|
|
// ComposeMiddlewares compose multiple middlewares on top of a tx.Handler. The
|
|
// middleware order in the variadic arguments is from outer to inner.
|
|
//
|
|
// Example: Given a base tx.Handler H, and two middlewares A and B, the
|
|
// middleware stack:
|
|
// ```
|
|
// A.pre
|
|
// B.pre
|
|
// H
|
|
// B.post
|
|
// A.post
|
|
// ```
|
|
// is created by calling `ComposeMiddlewares(H, A, B)`.
|
|
func ComposeMiddlewares(txHandler tx.Handler, middlewares ...tx.Middleware) tx.Handler {
|
|
for i := len(middlewares) - 1; i >= 0; i-- {
|
|
txHandler = middlewares[i](txHandler)
|
|
}
|
|
|
|
return txHandler
|
|
}
|
|
|
|
type TxHandlerOptions struct {
|
|
Debug bool
|
|
|
|
// TxDecoder is used to decode the raw tx bytes into a sdk.Tx.
|
|
TxDecoder sdk.TxDecoder
|
|
|
|
// IndexEvents defines the set of events in the form {eventType}.{attributeKey},
|
|
// which informs Tendermint what to index. If empty, all events will be indexed.
|
|
IndexEvents map[string]struct{}
|
|
|
|
LegacyRouter sdk.Router
|
|
MsgServiceRouter *MsgServiceRouter
|
|
|
|
AccountKeeper AccountKeeper
|
|
BankKeeper types.BankKeeper
|
|
FeegrantKeeper FeegrantKeeper
|
|
SignModeHandler authsigning.SignModeHandler
|
|
SigGasConsumer func(meter sdk.GasMeter, sig signing.SignatureV2, params types.Params) error
|
|
}
|
|
|
|
// NewDefaultTxHandler defines a TxHandler middleware stacks that should work
|
|
// for most applications.
|
|
func NewDefaultTxHandler(options TxHandlerOptions) (tx.Handler, error) {
|
|
if options.TxDecoder == nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrLogic, "txDecoder is required for middlewares")
|
|
}
|
|
|
|
if options.AccountKeeper == nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrLogic, "account keeper is required for middlewares")
|
|
}
|
|
|
|
if options.BankKeeper == nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrLogic, "bank keeper is required for middlewares")
|
|
}
|
|
|
|
if options.SignModeHandler == nil {
|
|
return nil, sdkerrors.Wrap(sdkerrors.ErrLogic, "sign mode handler is required for middlewares")
|
|
}
|
|
|
|
var sigGasConsumer = options.SigGasConsumer
|
|
if sigGasConsumer == nil {
|
|
sigGasConsumer = DefaultSigVerificationGasConsumer
|
|
}
|
|
|
|
return ComposeMiddlewares(
|
|
NewRunMsgsTxHandler(options.MsgServiceRouter, options.LegacyRouter),
|
|
NewTxDecoderMiddleware(options.TxDecoder),
|
|
// Set a new GasMeter on sdk.Context.
|
|
//
|
|
// Make sure the Gas middleware is outside of all other middlewares
|
|
// that reads the GasMeter. In our case, the Recovery middleware reads
|
|
// the GasMeter to populate GasInfo.
|
|
GasTxMiddleware,
|
|
// Recover from panics. Panics outside of this middleware won't be
|
|
// caught, be careful!
|
|
RecoveryTxMiddleware,
|
|
// Choose which events to index in Tendermint. Make sure no events are
|
|
// emitted outside of this middleware.
|
|
NewIndexEventsTxMiddleware(options.IndexEvents),
|
|
// Reject all extension options which can optionally be included in the
|
|
// tx.
|
|
RejectExtensionOptionsMiddleware,
|
|
MempoolFeeMiddleware,
|
|
ValidateBasicMiddleware,
|
|
TxTimeoutHeightMiddleware,
|
|
ValidateMemoMiddleware(options.AccountKeeper),
|
|
ConsumeTxSizeGasMiddleware(options.AccountKeeper),
|
|
// No gas should be consumed in any middleware above in a "post" handler part. See
|
|
// ComposeMiddlewares godoc for details.
|
|
// `DeductFeeMiddleware` and `IncrementSequenceMiddleware` should be put outside of `WithBranchedStore` middleware,
|
|
// so their storage writes are not discarded when tx fails.
|
|
DeductFeeMiddleware(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper),
|
|
TxPriorityMiddleware,
|
|
SetPubKeyMiddleware(options.AccountKeeper),
|
|
ValidateSigCountMiddleware(options.AccountKeeper),
|
|
SigGasConsumeMiddleware(options.AccountKeeper, sigGasConsumer),
|
|
SigVerificationMiddleware(options.AccountKeeper, options.SignModeHandler),
|
|
IncrementSequenceMiddleware(options.AccountKeeper),
|
|
// Creates a new MultiStore branch, discards downstream writes if the downstream returns error.
|
|
// These kinds of middlewares should be put under this:
|
|
// - Could return error after messages executed succesfully.
|
|
// - Storage writes should be discarded together when tx failed.
|
|
WithBranchedStore,
|
|
// Consume block gas. All middlewares whose gas consumption after their `next` handler
|
|
// should be accounted for, should go below this middleware.
|
|
ConsumeBlockGasMiddleware,
|
|
NewTipMiddleware(options.BankKeeper),
|
|
), nil
|
|
}
|