6cbbd6da75
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description The draft PR #9222 Closes: #7108 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> - implement proto definition for `Record` - rename `Info.go` to `legacyInfo.go` within `keyring` package - implement CLI `migrate` command that migrates all keys from legacyInfo to proto according to @robert-zaremba migration [algorithm](https://github.com/cosmos/cosmos-sdk/pull/9222/#discussion_r624683839) - remove legacy keybase entirely. - add `Migrate` and `MigrateAll` functions in `keyring.go` for single key and all keys migration - add tests - fix tests --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
109 lines
2.9 KiB
Go
109 lines
2.9 KiB
Go
package cmd_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"github.com/cosmos/cosmos-sdk/crypto/hd"
|
|
"github.com/cosmos/cosmos-sdk/crypto/keyring"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
"testing"
|
|
|
|
"github.com/spf13/viper"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/tendermint/tendermint/libs/log"
|
|
|
|
"github.com/cosmos/cosmos-sdk/client"
|
|
"github.com/cosmos/cosmos-sdk/client/flags"
|
|
"github.com/cosmos/cosmos-sdk/server"
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
simcmd "github.com/cosmos/cosmos-sdk/simapp/simd/cmd"
|
|
"github.com/cosmos/cosmos-sdk/testutil/testdata"
|
|
"github.com/cosmos/cosmos-sdk/types/module"
|
|
"github.com/cosmos/cosmos-sdk/x/genutil"
|
|
genutiltest "github.com/cosmos/cosmos-sdk/x/genutil/client/testutil"
|
|
)
|
|
|
|
var testMbm = module.NewBasicManager(genutil.AppModuleBasic{})
|
|
|
|
func TestAddGenesisAccountCmd(t *testing.T) {
|
|
_, _, addr1 := testdata.KeyTestPubAddr()
|
|
tests := []struct {
|
|
name string
|
|
addr string
|
|
denom string
|
|
withKeyring bool
|
|
expectErr bool
|
|
}{
|
|
{
|
|
name: "invalid address",
|
|
addr: "",
|
|
denom: "1000atom",
|
|
withKeyring: false,
|
|
expectErr: true,
|
|
},
|
|
{
|
|
name: "valid address",
|
|
addr: addr1.String(),
|
|
denom: "1000atom",
|
|
withKeyring: false,
|
|
expectErr: false,
|
|
},
|
|
{
|
|
name: "multiple denoms",
|
|
addr: addr1.String(),
|
|
denom: "1000atom, 2000stake",
|
|
withKeyring: false,
|
|
expectErr: false,
|
|
},
|
|
{
|
|
name: "with keyring",
|
|
addr: "ser",
|
|
denom: "1000atom",
|
|
withKeyring: true,
|
|
expectErr: false,
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
tc := tc
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
home := t.TempDir()
|
|
logger := log.NewNopLogger()
|
|
cfg, err := genutiltest.CreateDefaultTendermintConfig(home)
|
|
require.NoError(t, err)
|
|
|
|
appCodec := simapp.MakeTestEncodingConfig().Codec
|
|
err = genutiltest.ExecInitCmd(testMbm, home, appCodec)
|
|
require.NoError(t, err)
|
|
|
|
serverCtx := server.NewContext(viper.New(), cfg, logger)
|
|
clientCtx := client.Context{}.WithCodec(appCodec).WithHomeDir(home)
|
|
|
|
if tc.withKeyring {
|
|
path := hd.CreateHDPath(118, 0, 0).String()
|
|
kr, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendMemory, home, nil, appCodec)
|
|
require.NoError(t, err)
|
|
_, _, err = kr.NewMnemonic(tc.addr, keyring.English, path, keyring.DefaultBIP39Passphrase, hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
clientCtx = clientCtx.WithKeyring(kr)
|
|
}
|
|
|
|
ctx := context.Background()
|
|
ctx = context.WithValue(ctx, client.ClientContextKey, &clientCtx)
|
|
ctx = context.WithValue(ctx, server.ServerContextKey, serverCtx)
|
|
|
|
cmd := simcmd.AddGenesisAccountCmd(home)
|
|
cmd.SetArgs([]string{
|
|
tc.addr,
|
|
tc.denom,
|
|
fmt.Sprintf("--%s=home", flags.FlagHome)})
|
|
|
|
if tc.expectErr {
|
|
require.Error(t, cmd.ExecuteContext(ctx))
|
|
} else {
|
|
require.NoError(t, cmd.ExecuteContext(ctx))
|
|
}
|
|
})
|
|
}
|
|
}
|