Cleaning it and moving the breaking "test" code to testutils Related to: https://github.com/cosmos/cosmos-sdk/pull/10956 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
98 lines
2.7 KiB
Go
98 lines
2.7 KiB
Go
package keys
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/cosmos/cosmos-sdk/client"
|
|
"github.com/cosmos/cosmos-sdk/client/flags"
|
|
"github.com/cosmos/cosmos-sdk/crypto/hd"
|
|
"github.com/cosmos/cosmos-sdk/crypto/keyring"
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
"github.com/cosmos/cosmos-sdk/testutil"
|
|
"github.com/cosmos/cosmos-sdk/testutil/testdata"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
)
|
|
|
|
func Test_runDeleteCmd(t *testing.T) {
|
|
// Now add a temporary keybase
|
|
kbHome := t.TempDir()
|
|
cmd := DeleteKeyCommand()
|
|
cmd.Flags().AddFlagSet(Commands(kbHome).PersistentFlags())
|
|
mockIn := testutil.ApplyMockIODiscardOutErr(cmd)
|
|
|
|
yesF, _ := cmd.Flags().GetBool(flagYes)
|
|
forceF, _ := cmd.Flags().GetBool(flagForce)
|
|
|
|
require.False(t, yesF)
|
|
require.False(t, forceF)
|
|
|
|
fakeKeyName1 := "runDeleteCmd_Key1"
|
|
fakeKeyName2 := "runDeleteCmd_Key2"
|
|
|
|
path := sdk.GetConfig().GetFullBIP44Path()
|
|
cdc := simapp.MakeTestEncodingConfig().Codec
|
|
|
|
cmd.SetArgs([]string{"blah", fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome)})
|
|
kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome, mockIn, cdc)
|
|
require.NoError(t, err)
|
|
|
|
_, err = kb.NewAccount(fakeKeyName1, testdata.TestMnemonic, "", path, hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
|
|
_, _, err = kb.NewMnemonic(fakeKeyName2, keyring.English, sdk.FullFundraiserPath, keyring.DefaultBIP39Passphrase, hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
|
|
clientCtx := client.Context{}.
|
|
WithKeyringDir(kbHome).
|
|
WithCodec(cdc)
|
|
|
|
ctx := context.WithValue(context.Background(), client.ClientContextKey, &clientCtx)
|
|
|
|
err = cmd.ExecuteContext(ctx)
|
|
require.Error(t, err)
|
|
require.EqualError(t, err, "blah.info: key not found")
|
|
|
|
// User confirmation missing
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName1,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
err = cmd.Execute()
|
|
require.Error(t, err)
|
|
require.Equal(t, "EOF", err.Error())
|
|
|
|
_, err = kb.Key(fakeKeyName1)
|
|
require.NoError(t, err)
|
|
|
|
// Now there is a confirmation
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName1,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=true", flagYes),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
require.NoError(t, cmd.Execute())
|
|
|
|
_, err = kb.Key(fakeKeyName1)
|
|
require.Error(t, err) // Key1 is gone
|
|
|
|
_, err = kb.Key(fakeKeyName2)
|
|
require.NoError(t, err)
|
|
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName2,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=true", flagYes),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
require.NoError(t, cmd.Execute())
|
|
|
|
_, err = kb.Key(fakeKeyName2)
|
|
require.Error(t, err) // Key2 is gone
|
|
}
|