Matt Kocubinski 4db99fc1a5 fix(math): Dec marshal shouldn't have side effects (#15506) ... ## Description Ref: https://github.com/cosmos/cosmos-sdk/issues/15170 Included in: #15515 Required to resolve a discrepancy between the sign mode being implemented in #15170 and the existing legacy one. When calling tx builder [SetMsgs](4a6a1e3cb8/x/auth/tx/builder.go (L208)) messages are coerced to an any type in [NewAnyWithValue](4a6a1e3cb8/codec/types/any.go (L61)). This marshals a message as proto bytes. If a message has cosmos.Dec typed fields, and they are set to nil, the will be set to 0 during seriazliation in the [Dec.Marshal](88909d6f2b/math/dec.go (L801)) implementation. This side effect *changes* the output of a JSON marshal before and after the call to Dec.Marshal, as shown below. ```go rates := &stakingtypes.CommissionRates{} MarshalJson(rates) // {"rate":"0","max_rate":"0","max_change_rate":"0"} MarshalProto(rates) MarshalJson(rates) //{"rate":"0.000000000000000000","max_rate":"0.000000000000000000","max_change_rate":"0.000000000000000000"} ``` An integration is test is also committed asserting the (now fixed) behavior above. Its asserts should be changed once a release of math is made and `/tests/go.mod` is updated. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... * [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] added `!` to the type prefix if API or client breaking change * [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) * [ ] provided a link to the relevant issue or specification * [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules) * [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) * [ ] added a changelog entry to `CHANGELOG.md` * [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) * [ ] updated the relevant documentation or specification * [ ] reviewed "Files changed" and left comments if necessary * [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... * [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title * [ ] confirmed `!` in the type prefix if API or client breaking change * [ ] confirmed all author checklist items have been addressed * [ ] reviewed state machine logic * [ ] reviewed API design and naming * [ ] reviewed documentation is accurate * [ ] reviewed tests and test coverage * [ ] manually tested (if applicable)		2023-03-22 19:48:36 +00:00
..
e2e	refactor!: remove some legacy amino stuff needed for #11275 (#15299)	2023-03-15 20:10:23 +00:00
fixtures	refactor: remove capability module (#15344)	2023-03-10 12:59:10 +00:00
integration	fix(math): Dec marshal shouldn't have side effects (#15506)	2023-03-22 19:48:36 +00:00
go.mod	build(deps): Bump google.golang.org/grpc from 1.53.0 to 1.54.0 (#15511)	2023-03-22 19:01:51 +00:00
go.sum	build(deps): Bump google.golang.org/grpc from 1.53.0 to 1.54.0 (#15511)	2023-03-22 19:01:51 +00:00
Makefile	fix: fix race conditions from #14332 (#14402)	2022-12-26 16:32:48 +00:00