cosmos-sdk/x/nft
Sishir Giri b65f3fe070
feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces (#12603)
## Description
Most modules right now have a no-op for AppModule.BeginBlock and AppModule.EndBlock. We should move these methods off the AppModule interface so we have less deadcode, and instead move them to extension interfaces. 

1. I added `BeginBlockAppModule` and `EndBlockAppModule` interface.
2. Remove the dead-code from modules that do no implement them
3. Add type casting in the the module code to use the new interface

Closes: #12462



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-07-19 17:19:23 +00:00
..
client feat: migrate x/auth/vesting to use app wiring (#12301) 2022-06-20 13:06:01 +02:00
keeper refactor: Use mocks for x/nft testing (#12407) 2022-07-05 14:38:27 +00:00
module feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces (#12603) 2022-07-19 17:19:23 +00:00
simulation fix: revert changes in x/nft simulations (#12532) 2022-07-12 10:11:50 -04:00
spec docs: remove app wiring from module docs (#12393) 2022-06-30 14:11:25 +01:00
testutil fix: revert changes in x/nft simulations (#12532) 2022-07-12 10:11:50 -04:00
codec.go feat: implement nft module msg server (#10074) 2021-10-27 14:43:47 +00:00
errors.go feat: implement nft module query server (#10462) 2021-11-06 23:05:45 +00:00
event.pb.go docs: adr-43 update and nft proto comments (#10615) 2021-11-29 08:53:04 +00:00
expected_keepers.go feat: implement nft module msg server (#10074) 2021-10-27 14:43:47 +00:00
genesis.go feat: implement nft module msg server (#10074) 2021-10-27 14:43:47 +00:00
genesis.pb.go feat: Introduce Cosmos Scalars (#9933) 2021-09-21 09:46:29 +00:00
keys.go chore: fix warnings in comments/documentation of nft module (#11150) 2022-02-09 10:17:13 +00:00
msgs.go chore: gofumpt (#11839) 2022-05-19 10:55:27 +02:00
nft.pb.go docs: adr-43 update and nft proto comments (#10615) 2021-11-29 08:53:04 +00:00
query.pb.go feat(scripts): wipe API directory before generating (#11342) 2022-03-10 10:29:42 +00:00
query.pb.gw.go fix: dockerfile for building proto (#11452) 2022-03-25 12:35:09 +00:00
tx.pb.go feat: add message option extension to signal msg signers in a language agnostic way (#10977) 2022-01-28 17:01:56 +00:00
validation.go chore: fix warnings in comments/documentation of nft module (#11150) 2022-02-09 10:17:13 +00:00