cosmos-sdk/x/group
Sishir Giri b65f3fe070
feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces (#12603)
## Description
Most modules right now have a no-op for AppModule.BeginBlock and AppModule.EndBlock. We should move these methods off the AppModule interface so we have less deadcode, and instead move them to extension interfaces. 

1. I added `BeginBlockAppModule` and `EndBlockAppModule` interface.
2. Remove the dead-code from modules that do no implement them
3. Add type casting in the the module code to use the new interface

Closes: #12462



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-07-19 17:19:23 +00:00
..
client feat(group)!: read the decision policy from disk in group CLI (#12551) 2022-07-13 19:05:19 +02:00
errors feat: Add server implementation of Group module (#10570) 2021-12-10 11:02:11 +00:00
internal fix: deadlock when querying group members (#12342) 2022-06-28 13:55:54 -04:00
keeper fix: deadlock when querying group members (#12342) 2022-06-28 13:55:54 -04:00
module feat: Move AppModule.BeginBlock and AppModule.EndBlock to extension interfaces (#12603) 2022-07-19 17:19:23 +00:00
simulation refactor: rename depinject imports to cosmossdk.io/depinject (#12479) 2022-07-09 17:46:07 +02:00
spec fix(group): usage valid json as example of proposal.json (#12540) 2022-07-13 14:06:51 +02:00
testutil refactor: depinject without app.yaml (#12394) 2022-06-30 09:34:13 +01:00
codec.go revert: replace all ModuleCdc instances with legacy.Cdc (#11680) 2022-04-20 09:27:40 +00:00
config.go refactor(group): Distinguish Voting period and Execution period for group policies (#11198) 2022-03-02 12:00:59 +00:00
events.pb.go chore(group): State machine audit (#11559) 2022-04-15 10:35:45 +00:00
expected_keepers.go feat: Add server implementation of Group module (#10570) 2021-12-10 11:02:11 +00:00
genesis_test.go chore: gofumpt (#11839) 2022-05-19 10:55:27 +02:00
genesis.go refactor(group): API naming audit (#11515) 2022-04-06 11:16:23 +00:00
genesis.pb.go chore: Bump gov and group to v1 (#11334) 2022-03-11 15:58:01 +00:00
keys.go feat: Add server implementation of Group module (#10570) 2021-12-10 11:02:11 +00:00
msgs_test.go chore: Remove AddedAt from member request on group creation and member update (#11815) 2022-04-29 12:01:20 +00:00
msgs.go chore(types): add MustAccAddressFromBech32 util func (#12201) 2022-06-09 12:26:07 -04:00
proposal_test.go refactor: rename depinject imports to cosmossdk.io/depinject (#12479) 2022-07-09 17:46:07 +02:00
proposal.go chore: gofumpt (#11839) 2022-05-19 10:55:27 +02:00
query.pb.go refactor(group): API naming audit (#11515) 2022-04-06 11:16:23 +00:00
query.pb.gw.go fix: dockerfile for building proto (#11452) 2022-03-25 12:35:09 +00:00
tx.pb.go chore: Remove AddedAt from member request on group creation and member update (#11815) 2022-04-29 12:01:20 +00:00
types_test.go fix(group): Update TresholdDecisionPolicy to handle threshold>totalWeight (#11325) 2022-03-08 16:32:54 +00:00
types.go chore(types): add MustAccAddressFromBech32 util func (#12201) 2022-06-09 12:26:07 -04:00
types.pb.go chore: Remove AddedAt from member request on group creation and member update (#11815) 2022-04-29 12:01:20 +00:00
typesupport.go chore: Remove AddedAt from member request on group creation and member update (#11815) 2022-04-29 12:01:20 +00:00