## Description ref: #11362 I did **NOT** review the following folders, as they contain cryptography which I don't think I'm competent enough to give a useful review: - [ ] `crypto/xsalsa20symmetric` (new in v046, ported from TM i think) - [ ] `crypto/keys/secp256k1` (some new stuff in v046 too) Also performed some manual tests as part of #11939: - [x] Create keys on v0.45, make sure they still work in v0.46 https://github.com/cosmos/cosmos-sdk/issues/11939#issuecomment-1124881492 - [x] Create new keys in v0.46 https://github.com/cosmos/cosmos-sdk/issues/11939#issuecomment-1124881492 - [x] `--multisig` flag works with an address that's not in the keyring (see [repro](https://github.com/cosmos/cosmos-sdk/issues/9553)) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
106 lines
3.2 KiB
Go
106 lines
3.2 KiB
Go
package keys
|
|
|
|
import (
|
|
"bufio"
|
|
"encoding/hex"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/cosmos/cosmos-sdk/client"
|
|
"github.com/cosmos/cosmos-sdk/client/input"
|
|
"github.com/cosmos/cosmos-sdk/crypto/keyring"
|
|
"github.com/cosmos/cosmos-sdk/crypto/types"
|
|
)
|
|
|
|
const (
|
|
flagUnarmoredHex = "unarmored-hex"
|
|
flagUnsafe = "unsafe"
|
|
)
|
|
|
|
// ExportKeyCommand exports private keys from the key store.
|
|
func ExportKeyCommand() *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "export <name>",
|
|
Short: "Export private keys",
|
|
Long: `Export a private key from the local keyring in ASCII-armored encrypted format.
|
|
|
|
When both the --unarmored-hex and --unsafe flags are selected, cryptographic
|
|
private key material is exported in an INSECURE fashion that is designed to
|
|
allow users to import their keys in hot wallets. This feature is for advanced
|
|
users only that are confident about how to handle private keys work and are
|
|
FULLY AWARE OF THE RISKS. If you are unsure, you may want to do some research
|
|
and export your keys in ASCII-armored encrypted format.`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
clientCtx, err := client.GetClientQueryContext(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
buf := bufio.NewReader(clientCtx.Input)
|
|
unarmored, _ := cmd.Flags().GetBool(flagUnarmoredHex)
|
|
unsafe, _ := cmd.Flags().GetBool(flagUnsafe)
|
|
|
|
if unarmored && unsafe {
|
|
return exportUnsafeUnarmored(cmd, args[0], buf, clientCtx.Keyring)
|
|
} else if unarmored || unsafe {
|
|
return fmt.Errorf("the flags %s and %s must be used together", flagUnsafe, flagUnarmoredHex)
|
|
}
|
|
|
|
encryptPassword, err := input.GetPassword("Enter passphrase to encrypt the exported key:", buf)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
armored, err := clientCtx.Keyring.ExportPrivKeyArmor(args[0], encryptPassword)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
cmd.Println(armored)
|
|
|
|
return nil
|
|
},
|
|
}
|
|
|
|
cmd.Flags().Bool(flagUnarmoredHex, false, "Export unarmored hex privkey. Requires --unsafe.")
|
|
cmd.Flags().Bool(flagUnsafe, false, "Enable unsafe operations. This flag must be switched on along with all unsafe operation-specific options.")
|
|
|
|
return cmd
|
|
}
|
|
|
|
func exportUnsafeUnarmored(cmd *cobra.Command, uid string, buf *bufio.Reader, kr keyring.Keyring) error {
|
|
// confirm deletion, unless -y is passed
|
|
if yes, err := input.GetConfirmation("WARNING: The private key will be exported as an unarmored hexadecimal string. USE AT YOUR OWN RISK. Continue?", buf, cmd.ErrOrStderr()); err != nil {
|
|
return err
|
|
} else if !yes {
|
|
return nil
|
|
}
|
|
|
|
hexPrivKey, err := unsafeExportPrivKeyHex(kr.(unsafeExporter), uid)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
cmd.Println(hexPrivKey)
|
|
|
|
return nil
|
|
}
|
|
|
|
// unsafeExporter is implemented by key stores that support unsafe export
|
|
// of private keys' material.
|
|
type unsafeExporter interface {
|
|
// ExportPrivateKeyObject returns a private key in unarmored format.
|
|
ExportPrivateKeyObject(uid string) (types.PrivKey, error)
|
|
}
|
|
|
|
// unsafeExportPrivKeyHex exports private keys in unarmored hexadecimal format.
|
|
func unsafeExportPrivKeyHex(ks unsafeExporter, uid string) (privkey string, err error) {
|
|
priv, err := ks.ExportPrivateKeyObject(uid)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return hex.EncodeToString(priv.Bytes()), nil
|
|
}
|