LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity
2822f71b77
cosmos-sdk/x/distribution
History
Julien Robert 8b32094d1b
test: verify logic for proposer reward (#11517) 
## Description

Closes: #9161

I have added a test to confirm (or not) the proposer reward bug from the above issue.
It seems that there is no bug, and it behaves as it should.
The relevant logic that ensure that is here:

- 7fc7b3f6ff/x/distribution/keeper/allocation.go (L56)
- 7fc7b3f6ff/x/distribution/keeper/allocation.go (L67)

I am still opening this PR as adding this test can't do wrong.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-04-04 15:05:05 +00:00
..
client feat!: add 'amount' field to withdrawal responses #11457 2022-03-28 14:31:47 -04:00
keeper feat!: add 'amount' field to withdrawal responses #11457 2022-03-28 14:31:47 -04:00
migrations style: lint go and markdown (#10060) 2021-10-30 13:43:04 +00:00
simulation feat: replace all ModuleCdc instances with legacy.Cdc (#11240) 2022-02-23 14:13:36 +00:00
spec docs: Code blocks in SDK docs are broken (#11189) 2022-02-14 23:39:35 +01:00
types feat!: add 'amount' field to withdrawal responses #11457 2022-03-28 14:31:47 -04:00
abci_test.go test: verify logic for proposer reward (#11517) 2022-04-04 15:05:05 +00:00
abci.go Merge PR #6761: telemetry: use UTC() in wrappers 2020-07-17 15:33:50 -04:00
doc.go Merge PR #5417: Update distribution module doc 2019-12-17 13:59:16 -05:00
handler.go refactor: move legacy gov to v1beta1 (#10748) 2021-12-13 18:48:44 +00:00
module_test.go feat!: Ensure InitGenesis returns with non-empty validator set (#9697) 2021-10-05 12:02:51 +00:00
module.go fix: Check error for RegisterQueryHandlerClient in all modules RegisterGRPCGatewayRoutes (#10439) 2021-10-28 11:01:25 +00:00
proposal_handler_test.go feat!: Ensure InitGenesis returns with non-empty validator set (#9697) 2021-10-05 12:02:51 +00:00
README.md docs: Improve markdownlint configuration (#11104) 2022-02-10 12:07:01 +00:00

README.md

Distribution

  • Distribution - Fee distribution, and staking token provision distribution.