cosmos-sdk/client
Jayden Lee c71d19939b
fix: change the behavior of offline mode correctly (#15123)
## Description
Closes: #15109 

Change to work only when `FlagAccountNumber` and `FlagSequence` are in offline mode. In other cases, use `AccountRetriever` to populate those values.



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2023-02-23 10:03:20 +00:00
..
config refactor: rename to CometBFT (#14914) 2023-02-06 18:11:14 +00:00
debug refactor: fix lint issues + gofumpt (#15062) 2023-02-19 10:31:49 +00:00
docs fix(confix): wrong key set using set command (#14962) 2023-02-09 06:03:23 +00:00
flags refactor: rename commands to match consensus engine name (#14956) 2023-02-08 20:09:28 +00:00
grpc refactor: rename commands to match consensus engine name (#14956) 2023-02-08 20:09:28 +00:00
input chore: gofumpt (#11839) 2022-05-19 10:55:27 +02:00
keys refactor: fix lint issues + gofumpt (#15062) 2023-02-19 10:31:49 +00:00
pruning refactor!: migrate Cosmos SDK to CometBFT (#14897) 2023-02-05 14:51:33 +01:00
rpc feat: Integrate tendermint Block endpoints into the cli (#14659) 2023-02-14 19:23:45 +01:00
testutil chore: lint tests (#14268) 2022-12-18 23:48:31 +00:00
tx fix: change the behavior of offline mode correctly (#15123) 2023-02-23 10:03:20 +00:00
v2 build(deps): bump to tagged version of CometBFT (#15118) 2023-02-21 23:35:56 +01:00
account_retriever.go chore!: Refactor x/bank CLI Tests (#12706) 2022-08-03 12:08:41 -04:00
broadcast_test.go refactor: rename to CometBFT (#14914) 2023-02-06 18:11:14 +00:00
broadcast.go refactor: rename commands to match consensus engine name (#14956) 2023-02-08 20:09:28 +00:00
cmd_test.go fix(cli): home flag gets ignored when running help (#11645) 2022-04-21 09:27:31 -04:00
cmd.go refactor: simply errors (#15067) 2023-02-20 12:03:40 +00:00
cometbft.go feat: Integrate tendermint Block endpoints into the cli (#14659) 2023-02-14 19:23:45 +01:00
context_test.go fix: correct path required proto testdata (#14991) 2023-02-11 16:59:16 +00:00
context.go refactor: rename to CometBFT (#14914) 2023-02-06 18:11:14 +00:00
grpc_query_test.go chore: rename log pkg and add zerolog (#14955) 2023-02-08 11:32:22 +00:00
grpc_query.go refactor: fix lint issues + gofumpt (#15062) 2023-02-19 10:31:49 +00:00
internal_client_test.go fix(codec): MarshalInterface should err when UnmarshalInterface will fail (#12964) 2022-08-19 18:42:55 +00:00
prompts.go feat: CLI tooling to generate proposal JSONs (#13304) 2022-09-19 14:22:04 +02:00
query.go refactor: simply errors (#15067) 2023-02-20 12:03:40 +00:00
test_helpers.go Replace tmcrypto.PubKey by our own cryptotypes.PubKey (#7419) 2020-11-09 16:01:43 +00:00
tx_config.go feat: add cli for tips transactions (#10311) 2021-12-07 18:02:21 +00:00
utils_test.go client: fix Paginate's arguments validation (#6205) 2020-05-13 13:14:43 +00:00
utils.go refactor: fix lint issues + gofumpt (#15062) 2023-02-19 10:31:49 +00:00