d9f3eb027d
## Description Refs: #11970 Changes target of `SIGN_MODE_TEXTUAL` rendering to be a structured datatype instead of lines of ASCII text. This avoids the complexities of in-band, signaling and allows more capable signing devices not to be hindered by the limitations of those less capable. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [X] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [X] added `!` to the type prefix if API or client breaking change - [X] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [X] provided a link to the relevant issue or specification - [X] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [X] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [X] included comments for [documenting Go code](https://blog.golang.org/godoc) - [X] updated the relevant documentation or specification - [X] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed NOTE: changelog intentionally omitted - we'll add an entry when #11970 is complete. ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
54 lines
1.4 KiB
Go
54 lines
1.4 KiB
Go
package valuerenderer_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"os"
|
|
"testing"
|
|
|
|
"cosmossdk.io/tx/textual/valuerenderer"
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/protobuf/reflect/protoreflect"
|
|
)
|
|
|
|
func TestBytesJsonTestCases(t *testing.T) {
|
|
var testcases []bytesTest
|
|
// Bytes.json contains bytes that are represented in base64 format, and
|
|
// their expected results in hex.
|
|
raw, err := os.ReadFile("../internal/testdata/bytes.json")
|
|
require.NoError(t, err)
|
|
err = json.Unmarshal(raw, &testcases)
|
|
require.NoError(t, err)
|
|
|
|
textual := valuerenderer.NewTextual(mockCoinMetadataQuerier)
|
|
|
|
for _, tc := range testcases {
|
|
data, err := base64.StdEncoding.DecodeString(tc.base64)
|
|
require.NoError(t, err)
|
|
|
|
valrend, err := textual.GetValueRenderer(fieldDescriptorFromName("BYTES"))
|
|
require.NoError(t, err)
|
|
|
|
screens, err := valrend.Format(context.Background(), protoreflect.ValueOfBytes(data))
|
|
require.NoError(t, err)
|
|
require.Equal(t, 1, len(screens))
|
|
require.Equal(t, tc.hex, screens[0].Text)
|
|
|
|
// Round trip
|
|
val, err := valrend.Parse(context.Background(), screens)
|
|
require.NoError(t, err)
|
|
require.Equal(t, tc.base64, base64.StdEncoding.EncodeToString(val.Bytes()))
|
|
}
|
|
}
|
|
|
|
type bytesTest struct {
|
|
hex string
|
|
base64 string
|
|
}
|
|
|
|
func (t *bytesTest) UnmarshalJSON(b []byte) error {
|
|
a := []interface{}{&t.hex, &t.base64}
|
|
return json.Unmarshal(b, &a)
|
|
}
|