* fix: Signature only flag bug on tx sign command 7632 * Update client/context.go Co-authored-by: Cory <cjlevinson@gmail.com> * Update client/context.go Co-authored-by: Cory <cjlevinson@gmail.com> * use named return value and closure (#8111) This is to correctly handle deferred Close() calls on writable files. * set the right 'append' logic for signing transactions * cleanup * update tx.Sign interface by adding overwrite option * Update Changelog * sign command cleanup * implementation and changelog update * fix SignTx and tx.Sign calls * fix: sign didn't write to a file * update flags description * Add tx.Sign tests * fix grpc/server_test.go * Update client/tx/tx.go Co-authored-by: Cory <cjlevinson@gmail.com> * changelog update * Add test to verify matching signatures * cli_test: add integration tests for sign CMD * add output-file flag test * add flagAmino test * Update x/auth/client/cli/tx_sign.go Co-authored-by: Alessio Treglia <alessio@tendermint.com> * Update x/auth/client/cli/tx_sign.go * update amino serialization test * TestSign: adding unit test for signing with different modes * Add test with Multi Signers into Robert's TxSign PR (#8142) * Add test with Multi Signers * remove true false * Use SIGN_MODE_DIRECT * Fix litn * Use correct pubkeys * Correct accNum and seq * Use amino * cleanups * client.Sign: raise error when signing tx with multiple signers in Direct + added more unit tests * add more tests * Update client/tx/tx_test.go Co-authored-by: Cory <cjlevinson@gmail.com> * fix TestGetBroadcastCommand_WithoutOfflineFlag * Any.UnsafeSetCachedValue * fix note packed messages in tx builder * reorder unit tests * Changelog update * cleaning / linting * cli_tes: copy validator object instead of modifying it's shared codec * x/auth cli_test: remove custom codec creation in tests * Update CHANGELOG.md * updates to CHANGELOG.md * remove unused method * add new instance of transaction builder for TestSign Co-authored-by: Cory <cjlevinson@gmail.com> Co-authored-by: SaReN <sahithnarahari@gmail.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Amaury <amaury.martiny@protonmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
183 lines
5.3 KiB
Go
183 lines
5.3 KiB
Go
package client
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"fmt"
|
|
"io"
|
|
"io/ioutil"
|
|
"os"
|
|
"strings"
|
|
|
|
"github.com/gogo/protobuf/jsonpb"
|
|
|
|
"github.com/cosmos/cosmos-sdk/client"
|
|
"github.com/cosmos/cosmos-sdk/client/tx"
|
|
"github.com/cosmos/cosmos-sdk/codec"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
|
|
"github.com/cosmos/cosmos-sdk/x/auth/legacy/legacytx"
|
|
)
|
|
|
|
// Codec defines the x/auth account codec to be used for use with the
|
|
// AccountRetriever. The application must be sure to set this to their respective
|
|
// codec that implements the Codec interface and must be the same codec that
|
|
// passed to the x/auth module.
|
|
//
|
|
// TODO:/XXX: Using a package-level global isn't ideal and we should consider
|
|
// refactoring the module manager to allow passing in the correct module codec.
|
|
var Codec codec.Marshaler
|
|
|
|
// GasEstimateResponse defines a response definition for tx gas estimation.
|
|
type GasEstimateResponse struct {
|
|
GasEstimate uint64 `json:"gas_estimate" yaml:"gas_estimate"`
|
|
}
|
|
|
|
func (gr GasEstimateResponse) String() string {
|
|
return fmt.Sprintf("gas estimate: %d", gr.GasEstimate)
|
|
}
|
|
|
|
// PrintUnsignedStdTx builds an unsigned StdTx and prints it to os.Stdout.
|
|
func PrintUnsignedStdTx(txBldr tx.Factory, clientCtx client.Context, msgs []sdk.Msg) error {
|
|
err := tx.GenerateTx(clientCtx, txBldr, msgs...)
|
|
return err
|
|
}
|
|
|
|
// SignTx signs a transaction managed by the TxBuilder using a `name` key stored in Keybase.
|
|
// The new signature is appended to the TxBuilder when overwrite=false or overwritten otherwise.
|
|
// Don't perform online validation or lookups if offline is true.
|
|
func SignTx(txFactory tx.Factory, clientCtx client.Context, name string, stdTx client.TxBuilder, offline, overwriteSig bool) error {
|
|
info, err := txFactory.Keybase().Key(name)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
addr := sdk.AccAddress(info.GetPubKey().Address())
|
|
if !isTxSigner(addr, stdTx.GetTx().GetSigners()) {
|
|
return fmt.Errorf("%s: %s", sdkerrors.ErrorInvalidSigner, name)
|
|
}
|
|
if !offline {
|
|
txFactory, err = populateAccountFromState(txFactory, clientCtx, addr)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return tx.Sign(txFactory, name, stdTx, overwriteSig)
|
|
}
|
|
|
|
// SignTxWithSignerAddress attaches a signature to a transaction.
|
|
// Don't perform online validation or lookups if offline is true, else
|
|
// populate account and sequence numbers from a foreign account.
|
|
func SignTxWithSignerAddress(txFactory tx.Factory, clientCtx client.Context, addr sdk.AccAddress,
|
|
name string, txBuilder client.TxBuilder, offline, overwrite bool) (err error) {
|
|
|
|
// check whether the address is a signer
|
|
if !isTxSigner(addr, txBuilder.GetTx().GetSigners()) {
|
|
return fmt.Errorf("%s: %s", sdkerrors.ErrorInvalidSigner, name)
|
|
}
|
|
|
|
if !offline {
|
|
txFactory, err = populateAccountFromState(txFactory, clientCtx, addr)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return tx.Sign(txFactory, name, txBuilder, overwrite)
|
|
}
|
|
|
|
// Read and decode a StdTx from the given filename. Can pass "-" to read from stdin.
|
|
func ReadTxFromFile(ctx client.Context, filename string) (tx sdk.Tx, err error) {
|
|
var bytes []byte
|
|
|
|
if filename == "-" {
|
|
bytes, err = ioutil.ReadAll(os.Stdin)
|
|
} else {
|
|
bytes, err = ioutil.ReadFile(filename)
|
|
}
|
|
|
|
if err != nil {
|
|
return
|
|
}
|
|
|
|
return ctx.TxConfig.TxJSONDecoder()(bytes)
|
|
}
|
|
|
|
// NewBatchScanner returns a new BatchScanner to read newline-delimited StdTx transactions from r.
|
|
func NewBatchScanner(cfg client.TxConfig, r io.Reader) *BatchScanner {
|
|
return &BatchScanner{Scanner: bufio.NewScanner(r), cfg: cfg}
|
|
}
|
|
|
|
// BatchScanner provides a convenient interface for reading batch data such as a file
|
|
// of newline-delimited JSON encoded StdTx.
|
|
type BatchScanner struct {
|
|
*bufio.Scanner
|
|
theTx sdk.Tx
|
|
cfg client.TxConfig
|
|
unmarshalErr error
|
|
}
|
|
|
|
// Tx returns the most recent Tx unmarshalled by a call to Scan.
|
|
func (bs BatchScanner) Tx() sdk.Tx { return bs.theTx }
|
|
|
|
// UnmarshalErr returns the first unmarshalling error that was encountered by the scanner.
|
|
func (bs BatchScanner) UnmarshalErr() error { return bs.unmarshalErr }
|
|
|
|
// Scan advances the Scanner to the next line.
|
|
func (bs *BatchScanner) Scan() bool {
|
|
if !bs.Scanner.Scan() {
|
|
return false
|
|
}
|
|
|
|
tx, err := bs.cfg.TxJSONDecoder()(bs.Bytes())
|
|
bs.theTx = tx
|
|
if err != nil && bs.unmarshalErr == nil {
|
|
bs.unmarshalErr = err
|
|
return false
|
|
}
|
|
|
|
return true
|
|
}
|
|
|
|
func populateAccountFromState(
|
|
txBldr tx.Factory, clientCtx client.Context, addr sdk.AccAddress,
|
|
) (tx.Factory, error) {
|
|
|
|
num, seq, err := clientCtx.AccountRetriever.GetAccountNumberSequence(clientCtx, addr)
|
|
if err != nil {
|
|
return txBldr, err
|
|
}
|
|
|
|
return txBldr.WithAccountNumber(num).WithSequence(seq), nil
|
|
}
|
|
|
|
// GetTxEncoder return tx encoder from global sdk configuration if ones is defined.
|
|
// Otherwise returns encoder with default logic.
|
|
func GetTxEncoder(cdc *codec.LegacyAmino) (encoder sdk.TxEncoder) {
|
|
encoder = sdk.GetConfig().GetTxEncoder()
|
|
if encoder == nil {
|
|
encoder = legacytx.DefaultTxEncoder(cdc)
|
|
}
|
|
|
|
return encoder
|
|
}
|
|
|
|
func ParseQueryResponse(bz []byte) (sdk.SimulationResponse, error) {
|
|
var simRes sdk.SimulationResponse
|
|
if err := jsonpb.Unmarshal(strings.NewReader(string(bz)), &simRes); err != nil {
|
|
return sdk.SimulationResponse{}, err
|
|
}
|
|
|
|
return simRes, nil
|
|
}
|
|
|
|
func isTxSigner(user sdk.AccAddress, signers []sdk.AccAddress) bool {
|
|
for _, s := range signers {
|
|
if bytes.Equal(user.Bytes(), s.Bytes()) {
|
|
return true
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|