cosmos-sdk/baseapp
Amaury 01832e6239
refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979)
## Description

We decided to remove middlewares, and revert to antehandlers (exactly like in v045) for this release. A better middleware solution will be implemented after v046.

ref: #11955 

Because this refactor is big, so I decided to cut it into two. This PR is part 1 of 2:
- part 1: Revert baseapp and middlewares to v0.45.4
- part 2: Add posthandler, tips, priority

---
 Suggestion for reviewers:

This PR might still be hard to review though. I think it's easier to actually review the diff between v0.45.4 and this PR:
- `git difftool -d v0.45.4..am/revert-045-baseapp baseapp`
  - most important parts to review: runTx, runMsgs
- `git difftool -d v0.45.4..am/revert-045-baseapp x/auth/ante`
  - only cosmetic changes
- `git difftool -d v0.45.4..am/revert-045-baseapp simapp`



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-05-20 09:27:27 +00:00
..
abci_test.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
abci.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
baseapp_test.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
baseapp.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
block_gas_test.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
grpcrouter_helpers.go fix: remove grpc replace directive (#11089) 2022-02-04 10:54:32 +00:00
grpcrouter_test.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
grpcrouter.go feat: implement ABCI Query via gRPC (#11642) 2022-04-25 17:54:27 -04:00
grpcserver.go ci: improve error checking (errcheck linter) (#11195) 2022-04-13 06:46:51 +00:00
msg_service_router_test.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
msg_service_router.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
options.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
params_test.go chore: bump TM to v0.35.0 release candidate (#10210) 2021-11-16 11:24:38 -08:00
params.go chore: bump TM to v0.35.0 release candidate (#10210) 2021-11-16 11:24:38 -08:00
queryrouter_test.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
queryrouter.go x/ibc: alter id requirements (#6227) 2020-05-15 17:24:31 +00:00
recovery_test.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
recovery.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
router_test.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
router.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
state.go Merge PR #4748: Write-Through Inter-Block Cache 2019-09-04 13:33:32 -04:00
streaming.go feat: ADR-038 Part 2: StreamingService interface, file writing implementation, and configuration (#8664) 2021-10-24 21:37:37 +00:00
test_helpers.go refactor: Revert middlewares to antehandlers (part 1/2: baseapp) (#11979) 2022-05-20 09:27:27 +00:00
util_test.go refactor!: abstractions for snapshot and pruning; snapshot intervals eventually pruned; unit tests (#11496) 2022-04-21 15:30:36 -04:00