Commit Graph

64 Commits

Author SHA1 Message Date
yukionfire
67b5a5d268
chore(x): replace fmt.Errorf without parameters with errors.New (#21032) 2024-07-23 08:10:09 +00:00
Marko
28fa3b8dfc
chore: use comet api pkg instead of comet alias (#20614) 2024-06-11 08:46:04 +00:00
Marko
0dfb54e36a
refactor! : bump comet to v1 (#19726)
Co-authored-by: yihuang <yi.codeplayer@gmail.com>
2024-05-06 14:12:00 +00:00
Julián Toledano
f4af84f89f
refactor(x/group)!: remove Address.String() (#19916) 2024-04-02 13:59:30 +00:00
Julián Toledano
160c41842e
refactor(x/gov)!: remove Accounts.String() (#19850)
Co-authored-by: son trinh <trinhleson2000@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2024-03-26 10:29:47 +00:00
Julián Toledano
25aea8af8a
refactor!: remove global config from x/auth and client (#19447) 2024-03-06 13:14:16 +00:00
Julien Robert
b304cf7556
refactor!: kill basic manager (#19512) 2024-02-22 14:44:49 +00:00
Marko
21e69bad04
refactor(bank): add go module (#18279) 2023-10-27 09:25:04 +00:00
Marko
388ff4fc7e
refactor: move gov into own go.mod (#18197) 2023-10-23 14:17:04 +00:00
Emmanuel T Odeke
912c74248b
refactor(x/group): spin out Go module (#17937)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2023-10-20 14:33:04 +00:00
atheeshp
b8b32cf494
feat(x/group): autocli tx support (#18102) 2023-10-12 15:07:26 +00:00
atheeshp
6f53f7c4a3
feat(x/bank): autocli tx support (#17868)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-10-05 14:39:45 +00:00
Félix C. Morency
6b868a1e4e
docs(x/group): fix submit-proposal help json example (#17546) 2023-08-25 15:37:09 +00:00
Julien Robert
c6b0bb62ac
refactor(client): use address codec (#17503) 2023-08-23 10:43:47 +00:00
Julien Robert
5de37005fe
feat(gov,group): allow draft-proposal to skip metatada prompt (#17220) 2023-08-01 11:02:14 +00:00
Julien Robert
7eb85db2cf
feat(group): autocli query support (#17006) 2023-07-17 12:57:47 +00:00
ruthishvitwit
fd7e549a3c
chore: enable errcheck linter (#16406) 2023-07-12 08:58:27 +00:00
Julien Robert
8c72f66396
refactor!: remove types/math aliases (#16798) 2023-06-30 17:09:03 +00:00
Jacob Gadikian
6afece635c
style: add gci linter (#16605) 2023-06-22 15:35:51 +00:00
Marko
571c13ea84
refactor(bank): migrate bech32 encoding (#15567) 2023-05-24 17:03:43 +00:00
Matt Kocubinski
86b88b1ace
refactor!: use x/tx/signing in client.TxConfig (#15822) 2023-04-20 16:20:21 +00:00
Julien Robert
c0eade17fe
test: fix module cli tests (#15882) 2023-04-19 14:24:07 +00:00
Julien Robert
10d7d15f04
refactor(group): move ValidateBasic logic to msgServer (#15785)
Co-authored-by: Marko <marbar3778@yahoo.com>
2023-04-18 14:26:33 +00:00
Marko
d6762e930d
refactor(groups): remove global bech32 (#15707)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-04-14 16:25:22 +00:00
samricotta
e2c91fc1d7
refactor(genutil,group,mint): remove aliases from types/math.go (#15824)
## Description

Closes part of: https://github.com/cosmos/cosmos-sdk/issues/14405



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

* [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] added `!` to the type prefix if API or client breaking change
* [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] provided a link to the relevant issue or specification
* [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
* [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
* [ ] added a changelog entry to `CHANGELOG.md`
* [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] updated the relevant documentation or specification
* [ ] reviewed "Files changed" and left comments if necessary
* [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] confirmed all author checklist items have been addressed 
* [ ] reviewed state machine logic
* [ ] reviewed API design and naming
* [ ] reviewed documentation is accurate
* [ ] reviewed tests and test coverage
* [ ] manually tested (if applicable)
2023-04-13 12:34:47 +00:00
atheeshp
9e5e8ea89d
chore: CLI metadata help text (#15071) 2023-02-20 14:09:49 +00:00
Julien Robert
80dd55f79b
refactor: rename to CometBFT (#14914) 2023-02-06 18:11:14 +00:00
atheeshp
fd7bbd7e8d
fix: x/group pagination from CLI (#14923) 2023-02-06 13:56:00 +00:00
Julien Robert
41a3dfeced
refactor!: migrate Cosmos SDK to CometBFT (#14897) 2023-02-05 14:51:33 +01:00
atheeshp
a2797c8cd4
feat: add query groups in x/group (#14879)
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
2023-02-03 10:00:46 +00:00
Julien Robert
701aaa8c32
feat: Add support for []string and []int in draft-proposal prompt. (#14483) 2023-01-05 17:04:56 +00:00
Likhita Polavarapu
0a7bcd22cb
chore: Replace testify with gotest.tools in genutil integration tests (#14479) 2023-01-05 09:11:20 +00:00
Marko
7b1233327c
refactor: add title and summary to groups proposal (#14465) 2023-01-04 20:01:31 +00:00
Likhita Polavarapu
7cc1c351d2
refactor: x/group audit changes (#14278) 2022-12-24 00:13:54 +01:00
Matt Kocubinski
b46d838502
refactor: x/group 0.47 audit (#14290) 2022-12-13 20:59:52 +00:00
Julien Robert
08be7ee74b
refactor: extract MockTendermintRPC to testutil/cli 2022-11-03 22:40:52 +00:00
Jacob Gadikian
af816057f2
chore: run make format (#13375) 2022-09-24 00:22:03 +02:00
Julien Robert
df40c0a9d1
refactor!: remove broadcast mode block (#12659) 2022-09-23 15:16:31 +00:00
Julien Robert
7eb259fd86
feat: add draft-proposal for x/group (#13353)
* feat: add `draft-proposal` for x/group

* add changelog

* extract useful function

* add `GetMsgFromTypeURL` tests
2022-09-22 00:53:02 +02:00
likhita-809
fdf5a7b161
fix: Add withdraw proposal cmd to group's CLI tx cmds (#13214)
* add withdraw proposal cmd to group's cli tx cmds

* add changelog
2022-09-09 09:18:36 +02:00
Julien Robert
6d0ef15b0a
refactor: migrate to cosmos/gogoproto (#13070) 2022-09-08 17:27:48 +00:00
likhita-809
2efee04e4f
refactor(group): CLI tests using Tendermint Mock (#13067) 2022-09-05 14:31:30 +00:00
Jacob Gadikian
0943a70215
chore: fix linting issues exposed by fixing golangci-lint (#12895)
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-08-11 22:00:24 +02:00
Julien Robert
a2744eabc4
feat(group)!: read the decision policy from disk in group CLI (#12551) 2022-07-13 19:05:19 +02:00
Julien Robert
401d17bb59
fix(group): usage valid json as example of proposal.json (#12540) 2022-07-13 14:06:51 +02:00
Aleksandr Bezobchuk
c6315ec1b1
chore: simplify and refactor linting (#12318)
## Description

- Use tools methodology to use canonically versioned tools/binaries (e.g. golangci-lint)
  - This makes it so that all environments and developers use the same versions of tools (no need to rely on hacky docker containers)
- Update makefile
- Address linting errors

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-06-21 17:49:36 +00:00
Jacob Gadikian
b0e82f9640
chore: Db linting (#12141)
* mainly sdk.int to cosmossdk.io/math

* staking keys

* fumpt

* var-naming linter errors and a fumpt

* Update CHANGELOG.md

* Update .golangci.yml

* Update CHANGELOG.md

* Update test_helpers.go

* Update test_helpers.go

* fumpt and lint

* this lints the db module, and makes it easier to use.  It adds breaking name changes

* DBConnection -> Connection

* previous commit contained a merge error

* Update test_helpers.go

* Update test_helpers.go

* db renamings

* merge master

* changelog

* DBWriter -> Writer

* consistent multistore reciever

* standard recievers for multistore v2alpha1

* general cleanup of linting issues

* more linter fixes

* remove prealloc linter

* nolint the secp256k1 import

* nolint the secp256k1 package

* completenolint resulting in a diff that has only nolints
2022-06-08 19:02:01 +02:00
Marie Gauthier
bc1aa0645c
chore: Remove AddedAt from member request on group creation and member update (#11815)
## Description

Closes: #11794

- Remove `AddedAt` from member request on group creation and member update
- Set member `AddedAt` field properly on member update.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-04-29 12:01:20 +00:00
Amaury
53a6f199fe
chore(group): State machine audit (#11559)
## Description

ref: #10968 

I would like to have some eyes to:

- Make sure the state machine vulnerabiities are indeed bugs that should be fixed:
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846091449
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846093388
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846096172
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r849306060
- Some open questions:
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846090420
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r846094966
  - [x] https://github.com/cosmos/cosmos-sdk/pull/11559#discussion_r851193426

Other code changes are small: some small refactors to make code clearer, less panics, better error messages...

depends on:
- [x] #11560 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-04-15 10:35:45 +00:00
Noam
fd97fa880f
docs: update groups spec & cli instructions (#11516)
## Description

Fixes group spec and CLI instructions that were still using timeout instead of voting_period

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-04-08 13:01:43 +00:00