Commit Graph

297 Commits

Author SHA1 Message Date
mergify[bot]
2b42efcfc0
refactor(x/gov): refactor q gov proposer (backport #18025) (#18432)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-11-10 10:09:22 +00:00
mergify[bot]
d9134ee760
chore(x/gov): improve PromptMetadata readability (backport #17859) (#17864)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-09-25 10:11:28 +00:00
mergify[bot]
af29f5521d
chore(x/gov): update proposal.json go doc (backport #17397) (#17402)
Co-authored-by: johnzhu0907 <90296451+johnzhu0907@users.noreply.github.com>
2023-08-16 07:37:02 +00:00
mergify[bot]
397b9ce1a9
refactor(client): use cmtservice for comet-validator-set command (backport #17187) (#17257)
Co-authored-by: zakir <80246097+zakir-code@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-08-02 09:21:23 +00:00
mergify[bot]
f42be248f5
feat(gov,group): allow draft-proposal to skip metatada prompt (backport #17220) (#17242)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-08-01 11:41:53 +00:00
mergify[bot]
5f608b6e94
feat(client/v2): combine autocli and custom cmd within a module (backport #17088) (#17131)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-07-25 21:54:41 +00:00
mergify[bot]
93a995ca0c
feat(gov): autocli query support (backport #16987) (#16999)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-07-14 09:43:56 +00:00
Julien Robert
c452721442
style: add gci linter (#16758)
Co-authored-by: Jacob Gadikian <faddat@users.noreply.github.com>
2023-06-29 09:46:37 +00:00
Julien Robert
c0eade17fe
test: fix module cli tests (#15882) 2023-04-19 14:24:07 +00:00
Marko
f5993b1c62
refactor(gov): remove global bech32 (#15682) 2023-04-06 08:56:12 +00:00
Jacob Gadikian
0c905e8707
style: bank & autocli (#15659)
Co-authored-by: Sam Ricotta <samanthalricotta@gmail.com>
Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>
2023-04-02 00:20:59 +00:00
samricotta
43a4db5a9e
refactor: remove aliases from types/math.go in gov module (#15625)
Co-authored-by: Marko <marbar3778@yahoo.com>
2023-03-31 16:12:28 +00:00
Marko
51f3e70a12
style: more linting (#15618) 2023-03-30 13:00:18 +00:00
Marko
c1ea84d583
style: more linting (#15616) 2023-03-30 12:05:50 +00:00
Julien Robert
41c8529ff9
chore: bump cometbft to v0.37.0-rc3 (#15220) 2023-03-01 16:30:41 +01:00
Aleksandr Bezobchuk
41690532be
refactor: Refactor TxSearch (#14758)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-02-24 16:08:53 +00:00
samricotta
eb98685508
feat: constitution (#15125) 2023-02-22 18:41:59 +01:00
atheeshp
9e5e8ea89d
chore: CLI metadata help text (#15071) 2023-02-20 14:09:49 +00:00
Julien Robert
c17c3caab8
refactor: rename commands to match consensus engine name (#14956) 2023-02-08 20:09:28 +00:00
Julien Robert
80dd55f79b
refactor: rename to CometBFT (#14914) 2023-02-06 18:11:14 +00:00
Julien Robert
41a3dfeced
refactor!: migrate Cosmos SDK to CometBFT (#14897) 2023-02-05 14:51:33 +01:00
Julien Robert
4251905d56
feat!: upstream expedited proposals (#14720) 2023-02-03 00:25:28 +01:00
Julien Robert
5ec3d2b875
feat!: use gov v1 proposals in upgrade cli (#14880) 2023-02-02 13:55:48 +01:00
Julien Robert
8dbdfea9ef
refactor: remove .Type() and .Route() from msgs (#14751) 2023-01-24 17:03:06 +00:00
Daniel Wedul
6674402216
feat(gov,cli): Create AddGovPropFlagsToCmd and ReadGovPropFlags. (#14718) 2023-01-24 09:23:37 +00:00
Sai Kumar
a4cf8e8c6f
feat(cli): cancel gov proposal by proposer before voting period ends (#13010)
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marko <marbar3778@yahoo.com>
Closes https://github.com/cosmos/cosmos-sdk/issues/11554
2023-01-20 13:07:09 +00:00
Julien Robert
701aaa8c32
feat: Add support for []string and []int in draft-proposal prompt. (#14483) 2023-01-05 17:04:56 +00:00
Marko
08361d5ff8
refactor: add title, summary and proposer to proposal struct of gov (#14390) 2022-12-26 23:24:08 +00:00
Jacob Gadikian
be8c5a09c2
chore: lint tests (#14268) 2022-12-18 23:48:31 +00:00
Likhita Polavarapu
f1062c7f2c
refactor: x/gov audit changes (#14174)
* make proto changes

* wip

* wip

* wip

* `make lint-fix`

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-12-07 00:51:34 +00:00
Julien Robert
4f7d9ea233
refactor: clean-up test helpers and tmcli (#13805) 2022-11-09 11:13:27 +00:00
Julien Robert
08be7ee74b
refactor: extract MockTendermintRPC to testutil/cli 2022-11-03 22:40:52 +00:00
Likhita Polavarapu
ad0e41d7c7
refactor(gov): CLI tests using Tendermint Mock (#13717)
## Description

Closes: #13480 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-11-03 09:27:04 +00:00
Facundo Medica
91ca57bcef
feat!: (x/gov) store an index of proposals that are in voting period (#13576)
* (x/gov) feat: move parts of Proposal into separate storages

* fix some

* fix others

* fix unit tests

* fix unit tests

* fix conflicts

* progress

* do not overwrite messages

* remove change

* simplify methods

* static data

* fix tests

* fix tests

* fix tests

* rollback some changes

* rollback some changes

* progress

* progress

* progress

* progress

* progress

* progress

* add delete

* fix tests

* use SetProposalWithoutContents whenever possible

* add migrations

* fix godoc

* gofumpt

* add changelog

* rolling back changes

* rolling back changes

* progress

* progress

* progress

* progress

* fix tests

* fix cl

* fix cl

* fix

* fix test error

* add store key in readme

* add store key in readme
2022-10-26 14:52:00 +00:00
Emmanuel T Odeke
481569ce4f
fix: all: fix resource leaks found by staticmajor (#13394)
Fixes resource leaks in which a .Close, .Stop method
wasn't invoked in return routes such as with errors.

Found by https://github.com/cosmos/cosmos-sdk/pull/13392
2022-10-06 20:11:40 +00:00
Julien Robert
91d66f30e1
refactor!: extract simulation helpers out of simapp (#13402) 2022-09-27 21:19:44 +02:00
Julien Robert
df40c0a9d1
refactor!: remove broadcast mode block (#12659) 2022-09-23 15:16:31 +00:00
Julien Robert
7eb259fd86
feat: add draft-proposal for x/group (#13353)
* feat: add `draft-proposal` for x/group

* add changelog

* extract useful function

* add `GetMsgFromTypeURL` tests
2022-09-22 00:53:02 +02:00
Emmanuel T Odeke
a2118afc21
fix: x/gov/client/cli: update & tighten Prompt.Parse tests (#13350)
Adds more rigorous checks to ensure that the output
is as expected with range failures. While here also
added control tests to ensure that we can parse integers
within range of int.

Updates #13346
2022-09-21 05:59:11 +00:00
Emmanuel T Odeke
56a49aba46
fix: x/gov/client/cli: fix integer overflow in parsing int prompted values (#13347)
Reported by cosmos/gosec in https://github.com/cosmos/cosmos-sdk/security/code-scanning/5730.
This change checks for errors from strconv.Atoi in which case we were
susceptible to out of range errors, this change also adds tests to
prevent regressions.

Fixes #13346
2022-09-21 01:26:50 +02:00
Julien Robert
7252f4a758
feat: CLI tooling to generate proposal JSONs (#13304) 2022-09-19 14:22:04 +02:00
Julien Robert
6d0ef15b0a
refactor: migrate to cosmos/gogoproto (#13070) 2022-09-08 17:27:48 +00:00
Julien Robert
1dee068932
chore: downgrade to tendermint v0.34.x (#12958) 2022-08-20 02:33:07 +02:00
Jacob Gadikian
0943a70215
chore: fix linting issues exposed by fixing golangci-lint (#12895)
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-08-11 22:00:24 +02:00
Roman
07f7035f8d
feat!: initial deposit requirement for proposals (#12771)
* feat!: initial deposit requirement for proposals

* changelog

* fix genesis sim tests

* msg server test and err check

* fix e2e gov tests

* fix param tests

* fix sim and migration tests

* remove redundant check

* uncomment tests and revert the consensus version change

* migrations comment

* fix comment in simulation genesis

* restore zero ratio check

* remove gogoproto tag from new param

* upgrading.md

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2022-08-02 20:40:00 +02:00
atheeshp
30c5f20227
feat: deprecate x/params usage in x/gov (#12631)
## Description

Closes: #12495



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-08-01 16:53:04 +00:00
Julien Robert
f770f8cac6
refactor!: make simapp.MakeTestEncodingConfig private (#12747)
* feat: make `simapp.MakeTestEncodingConfig` private

* fix legacy build

* update changelog and upgrading.md

* updates docs
2022-07-27 17:23:56 +02:00
Matt Kocubinski
159ab4f8e8
refactor: move module cli tests up to simapp (#12718)
## Description

Ref: #11899 

Moves CLI test runners up to simapp while keeping test specification in the module, breaking the dependency from `x/module -> simapp` brought on by the current iteration of CLI / integration / network-backed tests.



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-07-26 22:00:54 +00:00
Matt Kocubinski
d4a9d4d321
refactor(testutil): remove dependency on simapp (#12624)
## Description

Closes: #12546 

Removes `simapp` as a dependency from `testutil/network` by abstracting `simapp` construction behind a factory fn (now in `simapp`), then requiring callers of `network.DefaultConfig` to pass in the factory fn directly.

This patch is an intermediate step to removing all dependencies on `simapp`.  Follow up work may include moving all of the tests using `network.DefaultConfig` updated here up to `simapp`, or possibly just the runners.



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-07-20 07:34:58 +00:00
Jacob Gadikian
b0e82f9640
chore: Db linting (#12141)
* mainly sdk.int to cosmossdk.io/math

* staking keys

* fumpt

* var-naming linter errors and a fumpt

* Update CHANGELOG.md

* Update .golangci.yml

* Update CHANGELOG.md

* Update test_helpers.go

* Update test_helpers.go

* fumpt and lint

* this lints the db module, and makes it easier to use.  It adds breaking name changes

* DBConnection -> Connection

* previous commit contained a merge error

* Update test_helpers.go

* Update test_helpers.go

* db renamings

* merge master

* changelog

* DBWriter -> Writer

* consistent multistore reciever

* standard recievers for multistore v2alpha1

* general cleanup of linting issues

* more linter fixes

* remove prealloc linter

* nolint the secp256k1 import

* nolint the secp256k1 package

* completenolint resulting in a diff that has only nolints
2022-06-08 19:02:01 +02:00