Commit Graph

28 Commits

Author SHA1 Message Date
Marko
22231f7c6d
refactor(x/slashing): remove extra get (#22376) 2024-10-28 13:40:42 +00:00
Akhil Kumar P
496cd0de9b
refactor(x/slashing): audit QA (#21477) 2024-09-02 11:13:52 +00:00
Julián Toledano
67ed23b8be
refactor(x/slashing): audit x/slashing changes (#21270)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2024-08-13 19:49:59 +00:00
Marko
080229f300
chore: remove cockroach db errors (#20386) 2024-05-15 06:35:08 +00:00
Julien Robert
5e7aae0db1
refactor(core,x/**): simplify core service api and embed environment in keepers (#20071) 2024-04-17 18:18:16 +00:00
Dev Ojha
8cb798d7bf
perf!: Make slashing not write sign info every block (#19458)
Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
2024-02-20 16:51:02 +00:00
Marko
e46d526b46
refactor(x/slashing): migrate slashing to use env var (#19440) 2024-02-15 09:42:51 +00:00
atheeshp
eaf92c225c
fix(x/slashing): consensus failure after cons key rotation (#19038) 2024-01-12 14:42:26 +00:00
Dev Ojha
0b01347b8a
perf: Don't deserialize params for every validator in slashing (#18959)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2024-01-06 07:49:46 +00:00
Marko
86eaeed519
refactor(slashing): spinout to new go module (#18201) 2023-10-25 15:28:32 +00:00
Marko
93770f59d9
refactor(x/slashing): remove global bech32 usage (#18115) 2023-10-17 10:33:52 +00:00
Marko
6615ff4f76
refactor!: deprecate blocktime on context (#17738) 2023-09-18 13:55:21 +00:00
Marko
266edc0a93
refactor: remove staking infraction type dep from evidence and slashing (#17335)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2023-08-12 15:45:41 +00:00
Likhita Polavarapu
a61e11ebab
refactor(x/slashing): migrate ValidatorSigningInfo to collections (#17023) 2023-07-18 16:15:33 +00:00
ruthishvitwit
fd7e549a3c
chore: enable errcheck linter (#16406) 2023-07-12 08:58:27 +00:00
Jacob Gadikian
6afece635c
style: add gci linter (#16605) 2023-06-22 15:35:51 +00:00
Facundo Medica
1be7d9805e
refactor(x/staking)!: KVStoreService, return errors and use context.Context (#16324)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2023-06-16 18:40:44 +00:00
Facundo Medica
903d99e707
refactor(x/slashing)!: use kvStoreService, context.Context and return errors (#16246) 2023-05-30 09:45:18 +00:00
Aleksandr Bezobchuk
6cee22df52
feat!: Comet v0.38 Integration (#15519)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-05-24 16:09:19 +00:00
Simon Noetzlin
97e4978f0f
feat: update the slashing and evidence modules to work with ICS (#15908)
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Jacob Gadikian <faddat@users.noreply.github.com>
2023-04-25 16:34:44 +00:00
Aleksandr Bezobchuk
4684c854d4
refactor!: x/slashing missed block window (#15580) 2023-04-10 16:58:41 +00:00
Julien Robert
419de8de82
refactor: revert API breaking change on Slash (#14363) 2022-12-20 12:12:05 +01:00
Marko
84675a6bf1
feat!: IS rebase (#13122)
* feat: IS rebase (squash da53124..b45dd5f)

* clean up docs

* fix: fix IS tests (#13420)

* revert key update

* add hook error handling

* impl feedback

* add changelog

* implements style nits
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* more nits

* fix tests
Co-authored-by: Simon <sainoe@users.noreply.github.com>

* add godoc

* add godoc

Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-10-09 12:21:20 +02:00
Tyler
2188dd0f3c
feat: add coins burned to slash event (#9458)
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Adds the amount of coins slashed from the validator to the `Slash` event. Additionally, before this PR, the jail/slash events were emitted **BEFORE** the slash/jail functions were even ran, which could result in a false positive event if an error occurred in these functions. ~~These events were moved to the end of the functions that implement the logic for them instead.~~ This PR moves the events to be emitted after the logic is executed. 

Closes: #9138 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

- +Add `amount_slashed` to slash event
- +Slash now returns the amount of tokens burned
- +Events moved to be emitted after the logic is executed
- +Add test to test the slash return amount
~~- +Add EventType `Jail` to separate it from the `Slash` event~~
~~- +Move slash/jail events into the functions that execute the logic for it~~
~~- -Remove `Reason` attribute from slash event (didn't appear to be consistent with what was happening in code)~~

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [x] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - @ryanchristo 
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [x] reviewed state machine logic - not applicable
- [x] reviewed API design and naming - @ryanchristo 
- [x] reviewed documentation is accurate - @ryanchristo 
- [x] reviewed tests and test coverage - @ryanchristo 
- [ ] manually tested (if applicable)
2021-07-05 14:33:30 +00:00
Marko
810605689d
further reduce logging (#8752) 2021-03-02 15:39:46 +00:00
Aleksandr Bezobchuk
5291a8ff31
Refactor Logging using Zerolog (#8072)
* init commit

* server: use flags

* server: godoc++

* updates

* baseapp: update logging

* logging updates

* x/bank: update logging

* logging updates

* lint++

* logging updates

* logging updates

* logging updates

* logging updates

* cl++
2020-12-03 23:17:21 +00:00
Marie Gauthier
90e9370bd8
Replace tmcrypto.PubKey by our own cryptotypes.PubKey (#7419)
* WIP on removing tm pub/privkey

* Fix part of crypto tests

* Add PrivKeyLedgerSecp256K1 proto type

* Use BasePrivKey for ledger priv key type

* Refacto continued

* First round

* x/staking

* Continue porting

* x/* done

* Make build pass

* More conversion

* Remove IntoTmPubKey

* Fix test

* Remove crypto.PubKey in some other places

* Revert ledger changes

* Fix comment

* Remove useless function

* Add To/FromTmPublicKey

* Add migrate tests

* Fix test

* Fix another test

* Rename tm conversion functions

* Less code

* Rename BasePrivKey to LedgerPrivKey

* Add changelog

* Rename functions

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-11-09 16:01:43 +00:00
Anil Kumar Kammari
883c1a2bc1
Merge PR #5627: Regen Network/Slashing protobuf 2020-02-20 01:04:13 +01:00