Commit Graph

8 Commits

Author SHA1 Message Date
Julián Toledano
25aea8af8a
refactor!: remove global config from x/auth and client (#19447) 2024-03-06 13:14:16 +00:00
Julien Robert
b304cf7556
refactor!: kill basic manager (#19512) 2024-02-22 14:44:49 +00:00
Emmanuel T Odeke
912c74248b
refactor(x/group): spin out Go module (#17937)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2023-10-20 14:33:04 +00:00
Julien Robert
460bd0ad26
refactor: remove unnecessary depinject usage (#15529) 2023-03-23 16:18:41 +00:00
Marko
755c99ac44
refactor: use proto.Message instead of ProtoMarshler (#14208) 2022-12-08 19:38:38 +00:00
Julien Robert
52bc0c16d3
refactor: rename depinject imports to cosmossdk.io/depinject (#12479) 2022-07-09 17:46:07 +02:00
likhita-809
5d3fd85396
feat: decouple x/group from simapp (#12277) 2022-06-18 00:43:39 +02:00
Amaury
5491be27d0
feat(group): Prune expired proposals and votes (#11315)
## Description

Closes: #11245

### 1. Pruning proposal.

Proposals are pruned:
- after a successful MsgExec (or try_exec)
- on voting_period_end + max_execution_period

whichever happens first.

### 2. Pruning votes.

Votes are pruned:
  - on MsgExec (or try_exec) if tally is final
  - on voting_period_end

whichever happens first. 

### 3. Various group fixes

See #11404 for details

TODO:
- [x] Add vote pruning after Tally, once #11310  is merged
- [x] Add tests



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-03-28 04:44:01 +00:00