Commit Graph

326 Commits

Author SHA1 Message Date
Julien Robert
6a2329fc93
refactor(x/gov): log error when deposit refund error (#18976) 2024-01-08 21:13:46 +00:00
Julien Robert
41c84d6190
feat(x/gov): multiple choice proposals (#18762) 2024-01-08 11:55:37 +00:00
lilas
14037aef00
refactor(x/gov): reduce "if block" indentation (#18918) 2023-12-30 11:28:11 +00:00
Julien Robert
e1e8c46c21
feat(x/gov): add max cancel voting period param (#18856) 2023-12-28 10:37:27 +00:00
Julien Robert
eb3ea8db8a
feat(x/gov): optimistic proposals (#18620)
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
2023-12-20 21:49:03 +00:00
Likhita Polavarapu
38f40c42f2
refactor: remove panic usage in keeper methods (#18636) 2023-12-12 09:51:23 +00:00
Julien Robert
8b894f73b1
feat(gov): add proposal types and spam votes (#18532) 2023-12-11 11:41:06 +00:00
Marko
7f540e26f9
refactor(bank): remove .String() calls (#18175)
Co-authored-by: Facundo <facundomedica@gmail.com>
2023-12-11 10:51:18 +00:00
Marko
a7ececc34d
refactor(staking): move delegation and validator interfaces to ./types (#18198)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2023-11-30 21:18:42 +00:00
Julien Robert
3853e7ff70
ci: optimize linter script (#18480) 2023-11-16 12:57:32 +00:00
emidev98
caf76300c0
chore(x/gov): clean validation code (#18449) 2023-11-12 15:28:08 +00:00
emidev98
89296ccdd3
feat(x/gov): extend governance config (#18428) 2023-11-10 15:17:56 +00:00
Emmanuel T Odeke
05261cc46e
refactor(x/auth): spin out go.mod (#18351) 2023-11-07 11:42:58 +00:00
Facundo Medica
177e7f4595
feat(x/gov): implement a minimum amount per deposit (#18146)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-11-02 10:51:19 +00:00
Geoff Lee
661d201d6b
remove unncessary comma from value of proposal_messages event (#18300) 2023-10-30 09:26:22 +00:00
Marko
21e69bad04
refactor(bank): add go module (#18279) 2023-10-27 09:25:04 +00:00
Marko
2a6640d488
refactor(staking): add go.mod (#18257) 2023-10-26 07:39:34 +00:00
Marko
388ff4fc7e
refactor: move gov into own go.mod (#18197) 2023-10-23 14:17:04 +00:00
Julien Robert
2fbc547ce9
feat(x/gov): limit deposited coins to accepted proposal denom (#18189) 2023-10-20 16:05:12 +00:00
Julien Robert
4121869cb7
refactor(x/gov)!: let hooks return an error (#18173) 2023-10-19 12:59:10 +00:00
Julien Robert
fe99b0c2f8
feat(x/gov): add autocli options for tx (#18036) 2023-10-12 11:57:41 +00:00
Julien Robert
45b44e678c
fix(x/gov): set default constitution in gov migration (#17953) 2023-10-06 08:16:25 +00:00
Marko
5e53fb2242
refactor(x/gov): remove gov vote and proposal based telemetry (#17910) 2023-09-27 18:55:19 +00:00
Likhita Polavarapu
9dd34510e2
feat: Move CommunityPool to its own module (#17657) 2023-09-27 09:09:04 +00:00
Marko
d5c78a637e
chore: remove params dep from crisis, gov and mint (#17837) 2023-09-22 09:35:20 +00:00
Marko
6615ff4f76
refactor!: deprecate blocktime on context (#17738) 2023-09-18 13:55:21 +00:00
Marko
72991994dd
chore: cleanup sdk.Context (#17717) 2023-09-13 21:40:14 +00:00
Marko
81d9ce9af5
feat(x/bank): introduce msg burn to bank keeper (#17569)
Co-authored-by: likhita-809 <likhita@vitwit.com>
2023-09-08 15:59:04 +00:00
Oleg Kovalov
7ff1ae999a
chore: fix nolint comments (#17644) 2023-09-06 21:32:11 +00:00
Likhita Polavarapu
97661429e0
docs: Add k/v docs in structs using collections (#17609) 2023-09-04 22:24:19 +00:00
Marko
3781c462a9
chore: minor bech32 global removal (#17469)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2023-08-22 12:45:54 +00:00
Marko
e60c583d28
refactor: migrate away from using valBech32 globals (2/2) (#17157)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2023-08-14 08:04:24 +00:00
Julien Robert
77be10bd95
refactor: remove collections.ErrInvalidIterator when unecessary (#17364) 2023-08-11 14:32:17 +00:00
Devon Bear
85d9791edf
feat(x/gov): Emit VoterAddr (#17354) 2023-08-11 07:51:17 +00:00
atheeshp
f907a27d31
refactor(x/staking): migrate delegation key to collections (#17162) 2023-08-09 07:15:12 +00:00
Thomas Bruyelle
8aaa776f82
test(gov): add missing assertion on TestTally (#17180) 2023-07-28 15:48:30 +00:00
Marko
58855c6859
refactor: remove global valaddress bech32 codec calls (1/2) (#17098)
Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-07-26 19:01:21 +00:00
Thomas Bruyelle
7daf40a270
test(gov): add test for Tally function (#17142) 2023-07-26 14:33:09 +00:00
Julien Robert
5442197d6b
chore: cherry-pick some inj changes (#17109) 2023-07-24 13:07:06 +00:00
Marko
c23505b037
refactor(staking): use validator & address codecs in staking (#16958) 2023-07-19 11:01:32 +00:00
Julien Robert
8cf483a419
feat(gov): autocli query support (#16987) 2023-07-14 09:07:50 +00:00
testinginprod
9e098ca9e6
fix(query): filtered collections pagination (#16905)
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: unknown unknown <unknown@unknown>
2023-07-13 15:44:51 +00:00
ruthishvitwit
fd7e549a3c
chore: enable errcheck linter (#16406) 2023-07-12 08:58:27 +00:00
atheeshp
a89764241f
chore: gov audit (secondary reviewer) (#16870) 2023-07-07 11:36:33 +00:00
Likhita Polavarapu
7017490830
chore: x/gov Audit changes (#16822) 2023-07-05 14:06:37 +00:00
Likhita Polavarapu
9dcf870778
fix: delete all votes when proposal is cancelled (#16824) 2023-07-05 08:31:23 +00:00
Jacob Gadikian
f0aec3f30d
style: use thelper (#16777) 2023-07-03 13:33:05 +00:00
Julien Robert
8c72f66396
refactor!: remove types/math aliases (#16798) 2023-06-30 17:09:03 +00:00
Julien Robert
ae39e8e631
build(deps): use hashicorp/go-metrics instead of armon/go-metrics (#16790) 2023-06-30 14:21:57 +00:00
Jacob Gadikian
6afece635c
style: add gci linter (#16605) 2023-06-22 15:35:51 +00:00
atheeshp
7e0148805a
chore: remove x/gov dependencies in x/distr (#16587)
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
2023-06-19 11:27:10 +00:00
Facundo Medica
1be7d9805e
refactor(x/staking)!: KVStoreService, return errors and use context.Context (#16324)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2023-06-16 18:40:44 +00:00
Matt Kocubinski
dc6985e29c
refactor: x/gov and x/mint no longer depend on each other (#16580) 2023-06-16 10:00:14 +00:00
testinginprod
5235593e72
refactor(distribution)!: use collections for DelegatorWithdrawAddress state management. (#16440)
Co-authored-by: unknown unknown <unknown@unknown>
2023-06-08 10:18:04 +00:00
Julien Robert
3608dabf77
chore: implement feedback of automerged prs (#16308) 2023-05-26 10:42:18 +00:00
testinginprod
b62a28aac0
refactor(gov)!: finalize collections migration (#16268)
Co-authored-by: unknown unknown <unknown@unknown>
2023-05-26 09:49:12 +00:00
Aaron Craelius
82659a7477
refactor!: deprecate sdk.Msg.GetSigners (#15284)
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
2023-05-25 18:35:09 +00:00
Julien Robert
2c702e6563
feat(gov,group): improve metadata checks and add docs (#16235) 2023-05-22 11:54:42 +00:00
Marko
c8ab555174
refactor(bech32): remove embedding of addresscodec (#16197) 2023-05-22 10:20:45 +00:00
Likhita Polavarapu
b20bd5d932
test(x/gov): write integration tests (#16194) 2023-05-19 09:42:33 +00:00
testinginprod
91d14c04ac
refactor(gov)!: use collections for Proposal state management (part 1) (#16171)
Co-authored-by: unknown unknown <unknown@unknown>
2023-05-16 09:55:08 +00:00
testinginprod
deba79d7aa
refactor(gov)!: use collections for Vote state management. (#16164)
Co-authored-by: unknown unknown <unknown@unknown>
2023-05-16 03:42:03 +00:00
testinginprod
71468d2d5a
refactor(gov)!: use collections for deposit state management (#16127)
Co-authored-by: unknown unknown <unknown@unknown>
2023-05-15 15:58:56 +00:00
testinginprod
f7418c6db2
refactor(gov)!: use collections for constitution and params state (#16118)
Co-authored-by: unknown unknown <unknown@unknown>
2023-05-12 08:15:37 +00:00
testinginprod
3185542a7a
refactor(gov)!: decouple gRPC query methods from Keeper (#16106)
Co-authored-by: unknown unknown <unknown@unknown>
2023-05-11 16:04:46 +00:00
bjwswang
250c478543
refactor: duplicate message verification at msg server and keeper (#16098)
Signed-off-by: bjwswang <bjwswang@gmail.com>
2023-05-11 10:43:48 +00:00
Marko
044fe13789
refactor(math)!: remove aliases in math (#16040)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-05-07 17:25:59 +00:00
Facundo Medica
4f00acfc24
refactor(x/gov)!: Use KVStoreService, context.Context, return errors, better iterators (#15988)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-05-05 10:13:56 +00:00
samricotta
e77156858f
refactor(staking, slashing, signing, misc): remove aliases from types/math.go (#15902) 2023-04-25 08:55:17 +00:00
atheeshp
debf1fa4d2
refactor(x/gov): move ValidateBasic to msg server (#15832)
Co-authored-by: Marko <marbar3778@yahoo.com>
2023-04-17 15:31:59 +00:00
Julien Robert
e4dbf1b7b4
refactor(auth,vesting): move ValidateBasic logic to msgServer (#15786) 2023-04-12 14:37:06 +00:00
Julien Robert
df161c214c
feat: optional validate basic (#15735) 2023-04-07 13:13:15 +00:00
Marko
90e2a2ae89
style: linting (#15704)
## Description

closing in on completion of linting

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

* [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] added `!` to the type prefix if API or client breaking change
* [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] provided a link to the relevant issue or specification
* [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
* [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
* [ ] added a changelog entry to `CHANGELOG.md`
* [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] updated the relevant documentation or specification
* [ ] reviewed "Files changed" and left comments if necessary
* [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] confirmed all author checklist items have been addressed 
* [ ] reviewed state machine logic
* [ ] reviewed API design and naming
* [ ] reviewed documentation is accurate
* [ ] reviewed tests and test coverage
* [ ] manually tested (if applicable)
2023-04-06 23:25:23 +00:00
Marko
f5993b1c62
refactor(gov): remove global bech32 (#15682) 2023-04-06 08:56:12 +00:00
samricotta
43a4db5a9e
refactor: remove aliases from types/math.go in gov module (#15625)
Co-authored-by: Marko <marbar3778@yahoo.com>
2023-03-31 16:12:28 +00:00
Marko
51f3e70a12
style: more linting (#15618) 2023-03-30 13:00:18 +00:00
Marko
c1ea84d583
style: more linting (#15616) 2023-03-30 12:05:50 +00:00
Jacob Gadikian
37ba88872d
style: enable strict gofumpt (#15579) 2023-03-28 18:59:21 +00:00
Facundo Medica
0282cfe71e
test: regression test on VotingPeriodProposalKey deletion (#15368)
## Description

Follow up to #15356 adding a test in which we activate the voting period, delete the proposal and try to vote in the deleted proposal (this vote would have passed before and now it gets rejected).



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2023-03-14 09:40:23 +00:00
Facundo Medica
90c9c9a9eb
fix: delete VotingPeriodProposalKey when deleting proposal (#15356) 2023-03-10 22:55:34 +00:00
Julien Robert
2f4654e40c
chore: clean-up of #15151 (#15219) 2023-03-01 11:07:07 +00:00
Marko
44495e7a79
refactor: add burnable params to governance (#15151) 2023-02-28 20:44:46 +00:00
Marko
17ba80df7c
chore: use message router interface (#15213) 2023-02-28 12:40:16 +01:00
Mark Rushakoff
ff3fed22bb
test(x/gov): fix flaky TestActivateVotingPeriod test (#15153) 2023-02-24 18:14:26 +00:00
Matt Kocubinski
4c51b77bf5
chore: fix misc linter errors (#15145) 2023-02-23 22:42:52 +00:00
samricotta
eb98685508
feat: constitution (#15125) 2023-02-22 18:41:59 +01:00
Facundo Medica
4a6a1e3cb8
refactor: fix lint issues + gofumpt (#15062) 2023-02-19 10:31:49 +00:00
Marko
1dad6891e2
chore: add message router interface (#15035) 2023-02-15 10:00:28 -08:00
Facundo Medica
dfb3271cdd
fix: x/gov ChargeDeposit delete deposits (#15033) 2023-02-14 16:26:15 -05:00
Julien Robert
a7ac29e3f4
chore: rename log pkg and add zerolog (#14955) 2023-02-08 11:32:22 +00:00
Marko
281017ae90
refactor: use cosmos-sdk/log throughout (#14909)
## Description

removes the dependency of tendermint/utils/log from countless locations. This is in effort of reducing Tendermint's lib usage in the sdk 

this is nonbreaking as the interface is the same. To eliminate tm/utils/log in the sdk we need a few more things. Once we have fully removed the tendermint logger, I would propose we break the interface and define our own for our use case, when we pass the logger to tendermint in the node.New() function we can wrap our logger for its use case 

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2023-02-07 10:54:48 +00:00
Julien Robert
80dd55f79b
refactor: rename to CometBFT (#14914) 2023-02-06 18:11:14 +00:00
Julien Robert
41a3dfeced
refactor!: migrate Cosmos SDK to CometBFT (#14897) 2023-02-05 14:51:33 +01:00
Julien Robert
4251905d56
feat!: upstream expedited proposals (#14720) 2023-02-03 00:25:28 +01:00
Julien Robert
2b64d74e5f
chore(gov): move args in gov new proposal constructor (#14782) 2023-01-25 18:34:51 +01:00
Likhita Polavarapu
7559d9ecd3
refactor: create go.mod for store (#14746)
Co-authored-by: Marko <marbar3778@yahoo.com>
2023-01-25 13:31:56 +00:00
Emil Georgiev
e9fbb01f3a
fix: replace IsEqual with Equal (#14739)
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: Marko <marbar3778@yahoo.com>
Closes https://github.com/cosmos/cosmos-sdk/issues/3246
2023-01-24 09:50:34 +00:00
Sai Kumar
a4cf8e8c6f
feat(cli): cancel gov proposal by proposer before voting period ends (#13010)
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marko <marbar3778@yahoo.com>
Closes https://github.com/cosmos/cosmos-sdk/issues/11554
2023-01-20 13:07:09 +00:00
Noel Ukwa
c822836501
refactor: migrate calls from alias file to appropriate store/types (#14455)
Co-authored-by: Marko <marbar3778@yahoo.com>
Closes https://github.com/cosmos/cosmos-sdk/issues/14406
2023-01-10 15:31:06 +00:00
Marko
7b1233327c
refactor: add title and summary to groups proposal (#14465) 2023-01-04 20:01:31 +00:00