Commit Graph

66 Commits

Author SHA1 Message Date
XiaoBei
c40cf3e737
refactor: use errors.New to replace fmt.Errorf with no parameters (#21394) 2024-08-25 11:41:31 +00:00
Lucas Francisco López
ee04cee0ca
refactor(x/distribution): audit QA (#21316)
Co-authored-by: Randy Grok <98407738+randygrok@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Cosmos SDK <113218068+github-prbot@users.noreply.github.com>
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
2024-08-17 19:49:32 +00:00
Julien Robert
5e7aae0db1
refactor(core,x/**): simplify core service api and embed environment in keepers (#20071) 2024-04-17 18:18:16 +00:00
Likhita Polavarapu
a248d05f70
feat(x/distribution): add env bundler to distribution module (#19445)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2024-02-27 22:18:13 +00:00
Naveen
4b8f32657b
fix(x/distribution): vulnerable incrementReferenceCount in distribution (#19301)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
2024-02-07 09:25:33 +00:00
Marko
a7ececc34d
refactor(staking): move delegation and validator interfaces to ./types (#18198)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2023-11-30 21:18:42 +00:00
Julien Robert
7aa5635baa
fix(x/distribution): fully deprecate distribution community pool (#18539)
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
2023-11-30 11:18:12 +00:00
Marko
2a6640d488
refactor(staking): add go.mod (#18257) 2023-10-26 07:39:34 +00:00
Marko
4352ab1f34
refactor(distribution): spin out go.mod (#18199) 2023-10-24 15:13:04 +00:00
Marko
e60c583d28
refactor: migrate away from using valBech32 globals (2/2) (#17157)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2023-08-14 08:04:24 +00:00
Facundo Medica
60605de779
refactor(x/distribution)!: migrate to collections (#17115)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-07-31 08:41:22 +00:00
Julien Robert
8c72f66396
refactor!: remove types/math aliases (#16798) 2023-06-30 17:09:03 +00:00
Jacob Gadikian
6afece635c
style: add gci linter (#16605) 2023-06-22 15:35:51 +00:00
testinginprod
43d345dc2f
refactor(distribution)!: use collections for ValidatorHistoricalRewards state (#16607)
Co-authored-by: unknown unknown <unknown@unknown>
2023-06-22 08:47:21 +00:00
Facundo Medica
1be7d9805e
refactor(x/staking)!: KVStoreService, return errors and use context.Context (#16324)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2023-06-16 18:40:44 +00:00
testinginprod
0529dbcd20
refactor(distribution)!: use collections for ValidatorOutstandingRewards state management (#16590)
Co-authored-by: unknown unknown <unknown@unknown>
2023-06-16 13:54:20 +00:00
testinginprod
99913cdce0
refactor(distribution)!: use collections for validator accumulated commission state (#16571)
Co-authored-by: unknown unknown <unknown@unknown>
2023-06-15 14:12:42 +00:00
testinginprod
2d1d68d3fd
refactor(distribution)!: use collections for ValidatorCurrentRewards (#16459)
Co-authored-by: unknown unknown <unknown@unknown>
2023-06-09 09:19:37 +00:00
testinginprod
f851e188b3
refactor(distribution)!: make FeePool state use collections (#16302)
Co-authored-by: unknown unknown <unknown@unknown>
2023-05-26 09:51:37 +00:00
Facundo Medica
428e19f4f0
refactor(x/distribution)!: Use KVStoreService, context.Context and return errors instead of panic (#15948) 2023-04-27 13:26:51 +00:00
samricotta
81d3b186be
refactor: remove aliases from types/math.go in crisis and distribution (#15674) 2023-04-05 11:19:22 +00:00
Jacob Gadikian
cb31043d35
chore: math lib update and type fixes (#12791)
## Description

Upgrades the math library in the repo root and find/replaces many usages of sdk.Dec, sdk.ZeroDec, sdk.OneDec, sdk.NewDec with their legacy-ified-math-lib replacements.

Note for review: I assume that I did not find 100% of usages

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-08-02 11:16:40 +00:00
Aleksandr Bezobchuk
4f04beae34
refactor!: create math go sub module (#11788) 2022-04-28 14:05:21 -04:00
Amaury Martiny
33e7297c79
Use enum instead of int32 for BondStatus (#7499)
* Migrate staking module

* Add gov legacy

* Add comments

* Add x/distrib

* x/crisis

* x/mint

* Fix test

* migrate x/genutil

* Fix lint

* Fix staking constants

* Fix test

* Update x/genutil/legacy/v040/migrate.go

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

* Add migrate script instead of change BondStatus constants

* Change staking bondStatus to enum

* Fix test

* Fix another test

* Remove staking exported

* fix references

* Better constants

* Fix build

* Fix lint

* Remove buf version

* Fix tests

* Fix test

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2020-10-12 13:56:02 +00:00
mergify[bot]
9acd722db2
x/distribution: simapp for testing (#5725)
* migrate first distribution test to use simapp

* refactor test TestAllocateTokensTruncation

* migrate allocation test for distribution

* migrate TestCalculateRewardsBasic to simapp in distribution

* migrate TestCalculateRewardsAfterSlash to simapp in distribution

* migrate TestCalculateRewardsAfterManySlashes to use simapp

* migrate TestCalculateRewardsMultiDelegator to use ssimapp

* migrate TestWithdrawDelegationRewardsBasic to simapp

* migrate TestCalculateRewardsAfterManySlashesInSameBlock to simapp

* migrate TestCalculateRewardsMultiDelegatorMultiSlash

* migrate old delegation test

* migrate keeper test to simapp

* refactor all distribution to use simapp

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-03-05 14:00:45 +00:00
Marko
56c5868975
Merge PR #5610: proto: migrate x/distr to use hybrid codec 2020-02-11 09:58:37 -05:00
Ferenc Fabian
066dd1114f Merge PR #5449: Add New constructor for the DecCoin 2020-01-03 15:44:53 -05:00
Xuefeng Zhu
3428291a61 Merge PR #5160: Simply Dec and Int sign check
* Simply Dec and Int sign check

* address comment
2019-10-14 16:05:42 -04:00
frog power 4000
ce0c0946b6 Merge PR #4654: Validator slash event stored by period and height 2019-07-01 12:03:34 -04:00
Federico Kunze
9c65e47329 Merge PR #4485: rename expected pkg to exported
* rename expected pkg to exported

* rename pkg
2019-06-05 13:42:25 -04:00
Federico Kunze
d322e23425 Merge PR #4417: cleanup staking references from types pkg
* cleanup staking references from types pkg

* check interface on runtime

* fixes

* rename validator set from slashing keeper

* final cleanup

* fix test

* fix querier

* fix tests

* rename interfaces

* update bond status

* fixes

* expected pkg

* ensure expected keepers match used funcs

* cha cha cha
2019-06-04 15:06:58 -07:00
frog power 4000
38e3fdfcea Merge PR #4094: Account for Rounding Errors in Distribution Calculations 2019-04-10 18:53:42 -04:00
Christopher Goes
4c50380181
Merge PR #3750: Outstanding per-validator rewards; correctly handle same-BeginBlock redelegation-double-slash 2019-03-06 19:54:12 +01:00
frog power 4000
a814e5ce66
Merge PR #3679: Consistent Operators
* Minus->Sub Plus->Add Div->Quo

* pending

* Update PENDING.md

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* fix

* typo
2019-02-21 12:35:55 -05:00
frog power 4000
ab9de3a7f1
Merge PR #3680: Convenience ToDec()
* NewDecFromInt -> ToDec

* pending

* Update PENDING.md

Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>

* test typo

* typo
2019-02-21 03:05:31 -05:00
Jack Zampolin
af60c75dd3 Merge PR #3352: Reenable simulation tests 2019-01-24 22:01:32 +01:00
Christopher Goes
b5e245fee3
Merge PR #3333: F1 storage efficiency improvements 2019-01-23 12:37:03 +01:00
Christopher Goes
2942f83ff5
Merge PR #3099: F1 fee distribution 2019-01-16 22:38:05 +01:00
frog power 4000
78a21353da Rename stake/ to staking/ (#3280) 2019-01-11 12:08:01 -08:00
Hendrik Hofstadt
2be19b9d33 Merge PR #3163: Withdraw commission on self bond removal
* Withdraw commission on self bond removal
* Update PENDING.md
2018-12-19 17:05:33 +01:00
Jae Kwon
bc51fa93b6
Fix updateValidatorDistInfoFromPool (#3046)
Fixes regression introduced by #2984.
Continuiation of #3033 , which didn't fix the simulation issues.
(candidate) Complete solution for #3019, 9002 halt bug.

From #2984, it isn't sufficient to take the fee pool rewards of a validator. Since we don't track delegator accums (as we do with validator accums), and because onValidatorModified >updateValidatorDistInfoFromPool is also being called upon delegation updates (or at least I believe this is the reason), it is necessary to also withdraw self delegation.

TODO: I don't think self-delegation should be required to be modified here... consider using a delegation hook to do the self-delegation withdraw part instead, e.g. splitting the updateValidatorDistInfoFromPool function into two. It might not result in cleaner code, however. Think hard.
2018-12-08 07:18:04 -08:00
Alexander Bezobchuk
6395e2a7ab Merge PR #2984: Removal of Mandatory Self-Delegation Reward
* Some minor cleanup and reformatting to make things easier to understand

* Update onDelegationSharesModified hook

* Add pending log

* Address PR comments

* Fix linting
2018-12-04 17:53:52 -05:00
Jae Kwon
d1e76221d8
Jae/simulator improvements (#2900)
* Make simulator operations predetermined
* Use new dbm.ReverseIterator API
* Simulation speed improvements
* Pin exact revisions, not branches
* Rename 'MountStoresIAVL' to 'MountStores'
* Zero Power Block fees to community pool
2018-11-27 00:14:22 -08:00
Christopher Goes
ad121f1498 Add a flag to export for zero-height start (#2827)
Closes #2812

This PR adds the flag --for-zero-height to gaiad export, which runs several alterations to the application state to prepare for restarting a new chain in a consistent fashion.

It also:

* Moves Gaia's export code to cmd/gaia/app/export.go for cleaner separation.
* Fixes an inconsistency where we treated the initChainer as happening at height -1 - it should now happen at height 0, since the first header sent by Tendermint has height 1.
* Runs the runtime invariant checks on start (in initChainer)
* Adds a few auxiliary functions to clear slashing periods
* Removes the Height field from Delegation objects in x/stake, which was not used anywhere
2018-11-26 04:21:23 -08:00
frog power 4000
7cb1ba625e blockly minting (#2825)
* update mechanism to use average block time
* correctly sets accum height for zero-delegations
* update Decimal Format()
* clip withdrawal tokens
* PositiveDelegationInvariant
* DelegatorSharesInvariant
* DelAccumInvariants
2018-11-26 04:13:47 -08:00
Alexander Bezobchuk
50926fffff Update to TM v0.26.0 - Part I (#2679)
* Update to TM v0.26.0
2018-11-04 18:28:38 -08:00
Rigel
d71f38bdac Merge PR #2597: Add distribution accum invariants 2018-10-26 13:42:53 +02:00
Jae Kwon
f756b40a01 LastValidatorPower is also an Int 2018-10-24 00:04:06 -07:00
Christopher Goes
3d270babc0 Store last total power as sdk.Int, not sdk.Dec 2018-10-23 20:48:50 +02:00
Jae Kwon
1cc74320df Replicate Rigel's changes but w/ modifications as discussed + some name changes 2018-10-22 01:46:47 -07:00