Commit Graph

30 Commits

Author SHA1 Message Date
Alessio Treglia
aeee097b2f
spring cleanup (#5991)
* Make format

* Fix golangci-lint warnings

Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-04-14 19:13:15 +00:00
Alessio Treglia
e8cedf243f
fix all bits broken by viper API changes (#5982)
github.com/spf13/viper's recent releases introduced a semantic
change in some public API such as viper.IsSet(), which have
broken some of our flags checks. Instead of checking whether
users have changed a flag's default value we should rely on such
defaults and adjust runtime behaviour accordingly. In order to do
so, it's important that we pick sane defaults for all our flags.

The --pruning flag and configuration option now allow for a
fake custom strategy. When users elect custom, then the
pruning-{keep,snapshot}-every options are interpreted and
parsed; else they're ignored.
Zero is pruning-{keep,snapshot}-every default value. When
users choose to set a custom pruning strategy they are
signalling that they want more fine-grainted control, therefore
it's legitimate to expect them to know what they are doing and
enter valid values for both options.

Ref #5964
2020-04-14 17:24:27 +02:00
Alessio Treglia
ca19fbc5f8
types/rest: add convenience functions for error checking (#5900) 2020-04-01 09:50:22 +02:00
Aleksandr Bezobchuk
6135912e53
JSON Proto changes 2020-03-26 12:46:10 -04:00
Aleksandr Bezobchuk
2978de90e1
Fix MarshalIndentFromJSON 2020-03-25 15:59:29 -04:00
Aleksandr Bezobchuk
3e0cf99e81
Finish remaining x/bank REST handlers 2020-03-25 14:23:34 -04:00
Aleksandr Bezobchuk
17b68fb365
Prep PostProcessResponseBare and PostProcessResponse 2020-03-25 13:20:29 -04:00
Alessio Treglia
3db39cda3c
Fix various linter warnings (#5824) 2020-03-18 12:59:08 +00:00
Alessio Treglia
2de4775a25
types/rest: add unit tests (#5779)
* types/rest: add unit tests

Drop unused functions:
- ParseQueryParamBool()
- ParseInt64OrReturnBadRequest()

* Fix test

* Disable parallelism

* Reintroduce @fedekunze ParseQueryParamBool

* Don't count Name() calls to fix flaky tests
2020-03-10 18:53:25 +00:00
Alessio Treglia
8a74dcafb5
Merge PR #5656: Make golangci-lint happy again 2020-02-17 17:30:18 +01:00
Alexander Bezobchuk
9b3296be79
Merge PR #5655: Fix TestParseHTTPArgs 2020-02-17 14:46:48 +01:00
Gerry Agbobada
235aa6c091
Merge PR #5648: Add min-height and max-height filters to TxSearch 2020-02-17 04:17:34 -05:00
Federico Kunze
5a0a36a8c9
Merge Pr #5585: client and types additions for IBC 2020-01-30 10:13:42 -05:00
Marko
b9490f2d93 Merge PR #5203: Add more linters 2019-10-17 09:47:35 -04:00
Marko
6684cdf3e5 Merge PR #5048: Fix linters and add golint 2019-09-16 13:11:17 -04:00
Marko
3a4f1fc4d4 Merge PR #4881: Linting Galore 2019-08-19 12:06:27 -04:00
Alexander Bezobchuk
4b354a782b
Merge PR #4840: Various Updates for Gaia 2019-08-03 09:56:15 -04:00
Alexander Bezobchuk
451535bd79
Merge PR #4837: Cleanup node_info Endpoint 2019-08-02 11:52:55 -04:00
Jack Zampolin
0ba74bb4b7 Merge PR #4777: Fix Height Queries 2019-07-25 17:45:13 -07:00
colin axner
8d8fd9df1a generalize query response with height (#4573)
Addition to #4536, no longer specific to account queries.
Allows for validator endpoints to return height in the response.

Closes: #4609
2019-07-01 17:48:13 +01:00
Alessio Treglia
97d10210be Merge PR #4510: Negative height paramter's value leads to undefined behavior 2019-06-07 14:11:50 -04:00
colin axner
c777fb9108 Merge PR #4505: Support height queries in REST client 2019-06-07 09:02:07 -04:00
Alexander Bezobchuk
3180e68c7b
Merge PR #4499: Remove Client Codec Redundancy 2019-06-06 11:43:15 -04:00
Alexander Bezobchuk
925070ae38
Merge PR #4292: Fix Signing Infos Endpoint 2019-05-09 13:38:15 -04:00
Alessio Treglia
85021d4ca9
No packages must depend on cmd/gaia/ (#4048)
Preparation work for moving gaia out of the SDK.
2019-04-04 15:36:39 +01:00
Karoly Albert Szabo
5bb6090e38 Add route for querying signing_info for all validators (#3952)
Also remove duplicate pagination:
- move function to extract query params into types/rest
- adjust pagination values locally until available in tendermint for validators

Code cleanup:
- helper function in test
- fix pagination description in swagger.yaml
- uint instead of int when possible

Closes: #3226
Closes: #3991
2019-03-28 18:43:33 +00:00
Alexander Bezobchuk
0611d2eda2 Merge PR #3688: JSON Decode Log in REST Client 2019-02-22 12:54:31 +01:00
Alexander Bezobchuk
992dc8b2dc Merge PR #3691: Minor Error Message Cleanup
* cleanup error messages

* Add pending log entry

* Rename Message to Error in ErrorResponse
2019-02-21 03:49:57 -05:00
Alexander Bezobchuk
e39debd359 Merge PR #3674: Remove password/keybase from REST Client 2019-02-19 10:15:39 -08:00
Alessio Treglia
1aa6c197ff Merge PR #3580: Code cleanup of client types 2019-02-14 08:53:36 -08:00