dependabot[bot]
d1e5a443ca
build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.11.1 to 0.12.0 ( #14012 )
...
Bumps [github.com/cosmos/ledger-cosmos-go](https://github.com/cosmos/ledger-cosmos-go ) from 0.11.1 to 0.12.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/cosmos/ledger-cosmos-go/releases ">github.com/cosmos/ledger-cosmos-go's releases</a>.</em></p>
<blockquote>
<h2>Update deps</h2>
<ul>
<li>Update dependencies:</li>
<li>Depends on zondax/ledger-go instead of cosmos/ledger-go</li>
<li>Include updates from zondax/ledger-go and zondax/hid (fixing mac build issue)</li>
<li>Update copyrights</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/a105dbb4ed2a90eb8dce275c96016e7bc4eb52d2 "><code>a105dbb</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/cosmos/ledger-cosmos-go/issues/34 ">#34</a> from cosmos/updates</li>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/543eb77c2c3ff632d31b910ba28560103a268e7a "><code>543eb77</code></a> update deps</li>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/d852bb596e978c69b94c3b91abfcefe64e97de0b "><code>d852bb5</code></a> update copyright</li>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/036a277666f380f5fdf94890eebfb046d5b6d34e "><code>036a277</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/cosmos/ledger-cosmos-go/issues/25 ">#25</a> from cosmos/dependabot/go_modules/github.com/stretchr/...</li>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/940cd3bd0d0902338bfc47763ff044014e176391 "><code>940cd3b</code></a> Bump github.com/stretchr/testify from 1.7.1 to 1.8.0</li>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/e736b9afa7d17a53588cb18f2ad379f1da6717ff "><code>e736b9a</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/cosmos/ledger-cosmos-go/issues/26 ">#26</a> from Zondax/update/ledger-go</li>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/998c2b9ed77d5c9a8bf2908a49a51a2bc2eab360 "><code>998c2b9</code></a> update ledger-go to 0.12.2</li>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/343ae35a1aabf193e7cf1bdc5497e0dc1d46acda "><code>343ae35</code></a> Bump github.com/stretchr/testify from 1.3.0 to 1.7.1 (<a href="https://github-redirect.dependabot.com/cosmos/ledger-cosmos-go/issues/20 ">#20</a>)</li>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/af7b6f9472df0cac4d7be0b38ac67cf53417032e "><code>af7b6f9</code></a> migrate to github actions (<a href="https://github-redirect.dependabot.com/cosmos/ledger-cosmos-go/issues/19 ">#19</a>)</li>
<li><a href="https://github.com/cosmos/ledger-cosmos-go/commit/9d8c40fbe73676066462fa6f323f875325935d24 "><code>9d8c40f</code></a> all: use named returns for proper defers + fix fmt.Errorf misuse (<a href="https://github-redirect.dependabot.com/cosmos/ledger-cosmos-go/issues/18 ">#18</a>)</li>
<li>See full diff in <a href="https://github.com/cosmos/ledger-cosmos-go/compare/v0.11.1...v0.12.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2022-11-25 12:03:05 +00:00
Julien Robert
ae91105fec
ci: configure monorepo sonarcloud ( #13944 )
2022-11-23 10:47:18 +00:00
dependabot[bot] and github-actions
c7d49217d6
build(deps): Bump google.golang.org/grpc from 1.50.1 to 1.51.0 ( #13953 )
...
* build(deps): Bump google.golang.org/grpc from 1.50.1 to 1.51.0
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.50.1 to 1.51.0.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.50.1...v1.51.0 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump google.golang.org/grpc from 1.50.1 to 1.51.0 for all modules
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-11-21 17:46:07 +01:00
d8391cb679
build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.1 to 2.3.2 ( #13926 )
...
* build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.1 to 2.3.2
Bumps [github.com/btcsuite/btcd/btcec/v2](https://github.com/btcsuite/btcd ) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/btcsuite/btcd/releases )
- [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES )
- [Commits](https://github.com/btcsuite/btcd/compare/btcec/v2.3.1...btcec/v2.3.2 )
---
updated-dependencies:
- dependency-name: github.com/btcsuite/btcd/btcec/v2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.1 to 2.3.2 for all modules
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr >
2022-11-18 17:21:29 +00:00
dependabot[bot] and github-actions
6dbf113efd
build(deps): Bump golang.org/x/crypto from 0.2.0 to 0.3.0 ( #13907 )
...
* build(deps): Bump golang.org/x/crypto from 0.2.0 to 0.3.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/golang/crypto/releases )
- [Commits](https://github.com/golang/crypto/compare/v0.2.0...v0.3.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump golang.org/x/crypto from 0.2.0 to 0.3.0 for all modules
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-11-17 17:39:09 +00:00
dependabot[bot]
5e1635ed9d
build(deps): Bump github.com/otiai10/copy in /tools/cosmovisor ( #13859 )
...
Bumps [github.com/otiai10/copy](https://github.com/otiai10/copy ) from 1.7.0 to 1.9.0.
- [Release notes](https://github.com/otiai10/copy/releases )
- [Commits](https://github.com/otiai10/copy/compare/v1.7.0...v1.9.0 )
---
updated-dependencies:
- dependency-name: github.com/otiai10/copy
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-14 17:42:54 +01:00
Julien Robert
d9bc5acac8
fix: .String() panics when pubkey is set on a BaseAccount ( #13838 )
2022-11-14 14:56:18 +00:00
Julián Toledano
b00cc29baa
fix: populate oldest_block_identifier and wrap jsonrpc errors ( #13832 )
...
## Description
Closes:
#13830
#13827
- Rosetta `/network/status` response:
* populates `oldest_block_identifier` with `EarliestBlockHeight` from rpc syncInfo
* tries to populate `genesis_block_identifier` with block of height 1
* if block is not queryable, sets value of `InitialHeight` from genesis doc
* if not queryable sets same value as `oldest_block_identifier`
- Wrap `github.com/tendermint/tendermint/rpc/jsonrpc/types` errors to rosetta errors
- Split services into its own go files (account, block, mempool, network)
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting ))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules )
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing )
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc )
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-11-12 10:39:37 +00:00
dependabot[bot] and github-actions
d32d89663f
build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.0 to 2.3.1 ( #13828 )
...
* build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.0 to 2.3.1
Bumps [github.com/btcsuite/btcd/btcec/v2](https://github.com/btcsuite/btcd ) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/btcsuite/btcd/releases )
- [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES )
- [Commits](https://github.com/btcsuite/btcd/compare/btcec/v2.3.0...btcec/v2.3.1 )
---
updated-dependencies:
- dependency-name: github.com/btcsuite/btcd/btcec/v2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.0 to 2.3.1 for all modules
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-11-10 16:27:56 +00:00
dependabot[bot]
ff168c2738
build(deps): Bump github.com/prometheus/client_golang from 1.13.1 to 1.14.0 ( #13796 )
2022-11-08 19:40:32 +00:00
dependabot[bot] and github-actions
79add5e4ff
build(deps): Bump github.com/spf13/viper from 1.13.0 to 1.14.0 ( #13798 )
...
* build(deps): Bump github.com/spf13/viper in /simapp
Bumps [github.com/spf13/viper](https://github.com/spf13/viper ) from 1.13.0 to 1.14.0.
- [Release notes](https://github.com/spf13/viper/releases )
- [Commits](https://github.com/spf13/viper/compare/v1.13.0...v1.14.0 )
---
updated-dependencies:
- dependency-name: github.com/spf13/viper
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump github.com/spf13/viper from 1.13.0 to 1.14.0 in /simapp for all modules
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-11-08 18:22:03 +01:00
dependabot[bot] and github-actions
c3c39b9955
build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.2.1 to 2.3.0 in /tools/rosetta ( #13769 )
...
* build(deps): Bump github.com/btcsuite/btcd/btcec/v2 in /tools/rosetta
Bumps [github.com/btcsuite/btcd/btcec/v2](https://github.com/btcsuite/btcd ) from 2.2.1 to 2.3.0.
- [Release notes](https://github.com/btcsuite/btcd/releases )
- [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES )
- [Commits](https://github.com/btcsuite/btcd/compare/btcec/v2.2.1...btcec/v2.3.0 )
---
updated-dependencies:
- dependency-name: github.com/btcsuite/btcd/btcec/v2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.2.1 to 2.3.0 in /tools/rosetta for all modules
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-11-04 14:51:58 +00:00
Julien Robert
4b26d9e27d
chore: use tagged rosetta version ( #13765 )
...
* chore: use tagged rosetta version
* add unit test in CI, bump tm and update changelog
* update rosetta data
* update action
2022-11-04 15:41:21 +01:00
sleepy ramen
39c5c079cd
fix: misc fixes for cosmos-rosetta ( #13583 )
...
### Description
Closes:
https://github.com/cosmos/cosmos-sdk/issues/13083
https://github.com/cosmos/cosmos-sdk/issues/11402
https://github.com/cosmos/cosmos-sdk/issues/10678
https://github.com/cosmos/cosmos-sdk/issues/12358
https://github.com/cosmos/cosmos-sdk/issues/10776
https://github.com/cosmos/cosmos-sdk/issues/12934
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting ))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules )
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing )
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc )
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-11-04 11:48:45 +00:00
e12a398367
build(deps): Bump github.com/prometheus/client_golang from 1.13.0 to 1.13.1 ( #13735 )
...
* build(deps): Bump github.com/prometheus/client_golang
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang ) from 1.13.0 to 1.13.1.
- [Release notes](https://github.com/prometheus/client_golang/releases )
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.13.1/CHANGELOG.md )
- [Commits](https://github.com/prometheus/client_golang/compare/v1.13.0...v1.13.1 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump github.com/prometheus/client_golang from 1.13.0 to 1.13.1 for all modules
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr >
2022-11-02 20:53:47 +00:00
dependabot[bot] and github-actions
797cb49ddc
build(deps): Bump github.com/btcsuite/btcd from 0.22.2 to 0.22.3 ( #13718 )
...
* build(deps): Bump github.com/btcsuite/btcd from 0.22.2 to 0.22.3
Bumps [github.com/btcsuite/btcd](https://github.com/btcsuite/btcd ) from 0.22.2 to 0.22.3.
- [Release notes](https://github.com/btcsuite/btcd/releases )
- [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES )
- [Commits](https://github.com/btcsuite/btcd/compare/v0.22.2...v0.22.3 )
---
updated-dependencies:
- dependency-name: github.com/btcsuite/btcd
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump github.com/btcsuite/btcd from 0.22.2 to 0.22.3 for all modules
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-11-01 17:52:01 +01:00
8e41b52e02
build(deps): Bump github.com/cosmos/iavl from 0.19.3 to 0.19.4 ( #13678 )
...
* build(deps): Bump github.com/cosmos/iavl from 0.19.3 to 0.19.4
Bumps [github.com/cosmos/iavl](https://github.com/cosmos/iavl ) from 0.19.3 to 0.19.4.
- [Release notes](https://github.com/cosmos/iavl/releases )
- [Changelog](https://github.com/cosmos/iavl/blob/v0.19.4/CHANGELOG.md )
- [Commits](https://github.com/cosmos/iavl/compare/v0.19.3...v0.19.4 )
---
updated-dependencies:
- dependency-name: github.com/cosmos/iavl
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump github.com/cosmos/iavl from 0.19.3 to 0.19.4 for all modules
* revert tm upgrade
* updates
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr >
2022-10-28 07:19:09 +00:00
dependabot[bot]
ad08ec484a
build(deps): Bump github.com/spf13/cobra from 1.6.0 to 1.6.1 ( #13648 )
2022-10-25 18:45:40 +00:00
dependabot[bot] and github-actions
d3010793ea
build(deps): Bump github.com/stretchr/testify from 1.8.0 to 1.8.1 in /tools/cosmovisor ( #13637 )
...
* build(deps): Bump github.com/stretchr/testify in /tools/cosmovisor
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify ) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/stretchr/testify/releases )
- [Commits](https://github.com/stretchr/testify/compare/v1.8.0...v1.8.1 )
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
* build(deps): Bump github.com/stretchr/testify from 1.8.0 to 1.8.1 in /tools/cosmovisor for all modules
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-10-24 20:33:20 +02:00
Julien Robert
209797f3be
chore: make format, make proto-update-deps, add 0.45.10 in changelog ( #13623 )
2022-10-24 15:23:12 +02:00
Julien Robert
3b62a95ad0
ci: fix can't release cosmovisor ( #13618 )
...
* ci: fix can't release cosmovisor
* fix tests
* update date
* update zip
2022-10-24 12:55:58 +02:00
Julien Robert
7d6601e1fb
refactor: clean-up SDK tools ( #13603 )
2022-10-21 15:15:20 +00:00
Jacob Gadikian
40180cda8f
ci: make makefile and ci match ( #13208 )
2022-09-09 06:28:49 +02:00
Aleksandr Bezobchuk
c6315ec1b1
chore: simplify and refactor linting ( #12318 )
...
## Description
- Use tools methodology to use canonically versioned tools/binaries (e.g. golangci-lint)
- This makes it so that all environments and developers use the same versions of tools (no need to rely on hacky docker containers)
- Update makefile
- Address linting errors
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting ))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules )
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing )
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc )
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json ) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-06-21 17:49:36 +00:00
Alessio Treglia
cdf2b7a7c5
gometalinter -> golangci-lint migration ( #3933 )
...
{,scripts/}Makefile:
- Remove gometalinter, install golangci-lint.
- Remove distinction between tools and devtools.
Just tools is enough.
- test_lint -> lint
Migrating away from underscore separated names.
- Remove unnecessary targets.
- Drop tendermint/lint. Incompatbile with golangci-lint
and no longer necessary anyway.
- Fix misleading message in go-mod-cache.
- New ci-target to avoid download tools twice.
- Run tests with -mod=readonly.
Port tools/gometalinter.json to .golangci.yml
Update CircleCI config accordingly.
Closes : #3896
2019-03-19 17:52:43 +01:00
Alessio Treglia
6ce4d5efd1
replace dep with go mod ( #3907 )
...
Replace sha1sum with jack's gosum and get rid of
vendor-deps.
Also don't compute hash on vendor/ contents.
Instead hash go.sum.
Disable unconvert lint check. It does not
work very well with go mod.
Remove update_vendor_deps once and for all.
Upgrade to go 1.12
Closes : #3919 #3630
2019-03-18 13:45:25 +01:00
Christopher Goes
dbd4f30b39
Merge branch 'develop' into dev/lock_tools
2018-10-11 08:48:15 +02:00
Christopher Goes
0ef1582aeb
Disable unparam
2018-10-11 01:53:17 +02:00
ValarDragon
9e334afad0
Lock binary dependencies to a specific commits / versions
...
This is basically copying over @anton's great script!
Also had to run `make format` to make this pass `test_lint`.
This PR also makes the make commands for tools further align
with the tendermint implementation.
2018-10-09 23:52:36 -07:00
HaoyangLiu
9f67e8af20
Merge PR #2215 : Add swagger-ui for gaiacli lite-server
2018-10-04 13:00:24 +02:00
Christopher Goes
17983460b8
Merge PR #2219 : Update to Tendermint 0.24 (except NextValSet offsets)
2018-10-03 17:48:23 +02:00
Alexander Bezobchuk
611e287375
Merge PR #2401 : Remove remnants of gocyclo
2018-09-25 13:45:04 -04:00
ValarDragon
9b26ccfa76
tools: Remove gocyclo
...
We can investigate re-introducing our own fork #postlaunch.
Closes #2211
2018-09-03 21:31:20 -07:00
rigelrozanski
423d0c4a18
Merge remote-tracking branch 'origin/develop' into cwgoes/a-random-walk-down-proof-of-stake
2018-07-19 01:56:42 -04:00
Dev Ojha
6cfef64382
Merge PR #1732 : tools: add make {get, update, check}_dev_tools
...
This is so that validators can have a more minimal install, but we
can still install linters for developers. (And any other future dev
tools)
2018-07-18 10:20:24 +02:00
Christopher Goes
a4e7216b36
Fix gocyclo check
2018-07-17 02:29:46 +02:00
ValarDragon
0c5358c267
Continue reducing code complexity:
...
* Adds a Min function to Int, and uses that in the slash function
* Adds a getHeight helper function to iavlstore
* Adds a splitPath function to baseapp
* Changes cyclo param from 10 to 11
2018-07-09 15:29:16 -07:00
ValarDragon
a768543d92
tools: Add code complexity linter, gocyclo
...
Gocyclo is a code complexity linter. It uses cyclomatic complexity.
Cyclomatic complexity essentially measures the number of different
paths code could go through. (The conditional in a for loop counts
as adding one path) It looks at this on a per-function level. The
idea that this would be enforcing is that if there are too many
different paths code can go through in a function, it needs to be
better split up. (A function with too many code paths is hard to
reason about)
The complexity which we want the linter to start failing on is
configurable. The default is 10. Change the "Cyclo" parameter in
`tools/gometalinter.json` to try other values.
2018-07-09 15:29:16 -07:00
ValarDragon
08e98d3124
tools: Switch gometalinter to use a config file
2018-07-07 12:00:06 -07:00
Dev Ojha
097dd8a164
tools: Add unparam linter ( #1443 )
...
* tools: Add unparam linter
unparam detects unused parameters in functions, and a parameter to
a function which only ever takes on one value. The latter is an
indication that more tests are required.
There are many nolints in this PR, as I believe that writing tests
to fix alot of these situations is out of scope for this PR / it
will be changed in future commits. There are some nolints for
when we have to comply to normal api's.
* crypto/keys no longer used by x/gov/client/rest/rest.go
2018-06-29 18:22:24 -04:00
Dev Ojha
ac3adff1e8
Merge PR #1438 : Tools: Add errcheck linter
...
This linter ensures that all errors are checked.
This is disabled in the client directories, since its not needed on
those writes
2018-06-29 00:52:10 +02:00
Dev Ojha
3e14868bd6
Merge PR #1429 : tools: Add ineffassign linter
...
* tools: Add ineffassign linter
This errors on assignments that don't actually do anything. i.e.
x, err := myFunc(1)
y, err = myFunc(2)
This will call out that the first function's call error was never
used.
* Fix makefile, add misspell to makefile
2018-06-28 19:12:02 +02:00
Dev Ojha
2755c66545
Merge PR #1424 : tools: add unconvert linter
...
unconvert checks for unnecessary type conversions
2018-06-28 18:08:29 +02:00
Dev Ojha
15bba919e2
Merge PR #1341 : Switch gometalinter to stable
...
* Switch gometalinter to stable
* Delete empty folder
2018-06-22 22:08:50 +02:00
Dev Ojha
7f1169db4d
Merge PR #1337 : tools: Fix makefile install scripts
...
Previously, the install scripts weren't installing golint and gometalinter.
This commit fixes this, and installs tendermints linter, and the HEAD of
the gometalinter repository. Now make all should work.
2018-06-22 20:01:44 +02:00
Pin Zhang
fe3236da61
Fix bug: make will fail if the path contains whitespace
2018-03-09 13:06:36 +08:00
Ethan Buchman
b5471212cf
dont import metalinter
2018-03-08 19:48:17 +00:00
Ethan Buchman
f25c9fc06a
tools: get_tools
2018-03-08 19:48:17 +00:00
Adrian Brink
e3c68e2640
Dep now works. Metalinter is broken
2018-03-08 19:48:17 +00:00
Adrian Brink
c42f036318
Fix build, just tools/ missing
2018-03-08 19:48:17 +00:00