Commit Graph

3777 Commits

Author SHA1 Message Date
Likhita Polavarapu
d01aa5b4a8
refactor(authz): CLI tests using Tendermint Mock (#13517)
## Description

Closes: #13487 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-10-14 10:37:08 +00:00
Tyler
81d033e701
perf(x/auth): only check memo when memo is present (#13528) 2022-10-13 19:49:11 +00:00
Julien Robert
89c65f4d58
feat: overwrite default denom in init cmd (#13535)
* feat: overwrite default denom in `init` cmd

* add changelog

* wording

* `make format`

* update comment
2022-10-13 18:24:28 +02:00
Aleksandr Bezobchuk
7781cdb3d2
refactor: Improve AllocateTokens #13524 2022-10-12 22:03:45 +02:00
Likhita Polavarapu
e5e97c3ec3
fix something (#13514) 2022-10-12 08:48:51 +02:00
Marko
dabcedce71
refactor: remove epoching module (#13503)
* remove epoching module

* remvoe mention in readme
2022-10-11 12:42:04 +00:00
Amaury
56709d4e1d
fix!: Fix some Amino registrations (#13502)
* fix!: Fix some Amino registrations

* add cl

* revert proto changes
2022-10-11 10:40:54 +00:00
atheeshp
ad07de8a68
feat: x/auth deterministic tests (#13329)
* add tests for `accounts`

* add more tests

* add tests

* review changes

* refactor

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes
2022-10-11 05:22:00 +00:00
Aaron Craelius
f3a558c6b4
refactor!: require exported app wiring providers (#13292) 2022-10-10 20:27:44 +00:00
Aleksandr Bezobchuk
c60c55616d
feat: gRPC query for operator and chain configuration (#13485) 2022-10-10 19:12:00 +00:00
Julien Robert
214b11dcba
feat: add github links in docs (#13491)
* feat: add github links in docs

* apply proto theme

* fix toc
2022-10-10 20:02:32 +02:00
Julien Robert
a74989ddf4
feat: migrate to docusaurus (#13471) 2022-10-10 14:01:53 +00:00
Marko
84675a6bf1
feat!: IS rebase (#13122)
* feat: IS rebase (squash da53124..b45dd5f)

* clean up docs

* fix: fix IS tests (#13420)

* revert key update

* add hook error handling

* impl feedback

* add changelog

* implements style nits
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* more nits

* fix tests
Co-authored-by: Simon <sainoe@users.noreply.github.com>

* add godoc

* add godoc

Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-10-09 12:21:20 +02:00
Julien Robert
6efbedb1c7
feat: let sign-batch read multiple files (#13454)
* feat: let `sign-batch` read multiple files

* add changelog

* fix gosec issue

* simplify
2022-10-07 15:12:28 +00:00
Emmanuel T Odeke
481569ce4f
fix: all: fix resource leaks found by staticmajor (#13394)
Fixes resource leaks in which a .Close, .Stop method
wasn't invoked in return routes such as with errors.

Found by https://github.com/cosmos/cosmos-sdk/pull/13392
2022-10-06 20:11:40 +00:00
Julien Robert
74ce07eb26
docs: improve documentation navigation and redirection (#13455) 2022-10-06 15:51:10 +02:00
Amaury
ff39d243d4
refactor: Improve x/bank deterministic tests (#13450)
* refactor: Improve x/bank deterministic tests

* typo

* Less changes

* Rename var

* Fix SpendableBalances

* Fix pagination tests

* Fix TestGRPCQueryTotalSupply

* Remove explicit SetupTest()

* Fix TestGRPCSendEnabled

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2022-10-06 12:05:56 +00:00
Amaury
90bd3161a1
refactor: Improve and clarify API around AccountAddressById (#13460)
* Revert "chore: change id to use uint64 in `AccountAddressByID` (#13411)"

This reverts commit 3d0e214446.

* Add since

* Update CLI command

* make proto-gen

* id->accNum

* No API breaking changes

* improve err msg

* Update CHANGELOG.md

Co-authored-by: Julien Robert <julien@rbrt.fr>

* Update CHANGELOG.md

Co-authored-by: Julien Robert <julien@rbrt.fr>

Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-10-06 11:05:25 +00:00
Marko
306a9a7170
feat!: consensus module (#12905) 2022-10-05 18:06:24 +00:00
emidev98
c2f0c0f785
feat: context on simulate error (#13435) 2022-10-03 22:36:56 +00:00
Julien Robert
80ce491734
refactor: move x/{moduleName}/test{ModuleName} to x/{moduleName}/testutil (#13427)
* refactor: move `x/{moduleName}/test{ModuleName}` to `x/{moduleName}/testutil`

* updates

* updates
2022-10-02 10:42:52 -04:00
Marko
c221d7f1de
chore: minor cleanup of types (#13430) 2022-10-02 15:03:03 +02:00
atheeshp
60ab6086d2
feat: x/bank deterministic tests (#13362)
* feat: `x/bank` deterministic tests

* fix tests

* add all balances regressions

* refactor

* `spendable coins` tests

* total supply regressions

* `SupplyOf` regressions

* params regressions

* add few more tests

* `denomOwners` tests

* refactor

* review changes
2022-09-29 09:24:37 +00:00
atheeshp
3d0e214446
chore: change id to use uint64 in AccountAddressByID (#13411) 2022-09-28 12:42:53 -04:00
Julien Robert
91d66f30e1
refactor!: extract simulation helpers out of simapp (#13402) 2022-09-27 21:19:44 +02:00
Julien Robert
53519ea5b3
refactor: simplify hooks implementation (#13396) 2022-09-27 20:37:26 +02:00
Julien Robert
684ee627d1
fix: attempt at fixing flaky e2e tests (#13401)
* fix: attempt at fixing flaky e2e tests

* `make format`

* add links
2022-09-27 13:39:04 -04:00
omahs
6f337b4d74
docs: fix typos (#13399) 2022-09-27 09:30:41 +00:00
Sai Kumar
445a99f710
feat(cli): add --append flag to sign-batch cli cmd (#13147)
* feat(cli): add `multi-msg-sign`

* chore: update the changelog

* chore: fix the lint issue

* chore: address the pr comments

* chore: address the pr comments

* refactor: refactored `sign-batch` to generate single signed tx

* chore: updated the changelog

* fix: fix the lint

* test: fix the tests on auth

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2022-09-27 00:31:58 +02:00
Emmanuel T Odeke
abdf61e292
fix: all: remove map iteration non-determinism with keys + sorting (#13377) 2022-09-24 16:20:54 +00:00
Jacob Gadikian
af816057f2
chore: run make format (#13375) 2022-09-24 00:22:03 +02:00
likhita-809
09b0f58932
feat: make helper function for adding accounts to genesis state (#13298) 2022-09-23 19:25:36 +00:00
Julien Robert
df40c0a9d1
refactor!: remove broadcast mode block (#12659) 2022-09-23 15:16:31 +00:00
Julien Robert
7eb259fd86
feat: add draft-proposal for x/group (#13353)
* feat: add `draft-proposal` for x/group

* add changelog

* extract useful function

* add `GetMsgFromTypeURL` tests
2022-09-22 00:53:02 +02:00
Emmanuel T Odeke
a2118afc21
fix: x/gov/client/cli: update & tighten Prompt.Parse tests (#13350)
Adds more rigorous checks to ensure that the output
is as expected with range failures. While here also
added control tests to ensure that we can parse integers
within range of int.

Updates #13346
2022-09-21 05:59:11 +00:00
Emmanuel T Odeke
9c2aef342d
chore: all: use golang.org/x/exp/maps.(Keys, Values) where necessary (#13349)
Uses golang.org/x/exp/maps.(Keys, Values) to sort out flagged
potential non-determinism issues due to map iteration which is
randomized in maps.

These were flagged by cosmos/gosec in

* https://github.com/cosmos/cosmos-sdk/security/code-scanning/724
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/725
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/726
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/727
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/728
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/729
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/782
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/813
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/814
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/816

which complained about potential non-determinism in
map iteration in which we only want appends in map iteration loops,
this change instead uses golang.org/x/exp/maps.Keys to retrieve
the keys then sort.Strings which simplifies the helper code.

This change fixes issues in:
* orm/model/ormdb: non-determinism in ExportJSON
* store/internal/proofs
* types/module
* x/auth/keeper
* x/bank
* x/genutil/client/cli

Fixes #13348
2022-09-21 02:08:13 +00:00
Emmanuel T Odeke
56a49aba46
fix: x/gov/client/cli: fix integer overflow in parsing int prompted values (#13347)
Reported by cosmos/gosec in https://github.com/cosmos/cosmos-sdk/security/code-scanning/5730.
This change checks for errors from strconv.Atoi in which case we were
susceptible to out of range errors, this change also adds tests to
prevent regressions.

Fixes #13346
2022-09-21 01:26:50 +02:00
Julien Robert
79f277c111
fix: fix buf commit link (#13345) 2022-09-20 21:21:45 +02:00
Aleksandr Bezobchuk
c1c23a75d9
fix: ensure withdraw_rewards events are always emitted on reward withdrawal (#13323) 2022-09-20 10:23:21 +00:00
likhita-809
7ebbfa0b30
refactor(nft): CLI tests using Tendermint Mock (#13256)
* wip: move nft cli tests to e2e tests

* wip: add cli tests using Tendermint Mock

* cleanup genutil test file

* remove unncessary test cases

* address review comments

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2022-09-19 13:01:49 +00:00
Julien Robert
7252f4a758
feat: CLI tooling to generate proposal JSONs (#13304) 2022-09-19 14:22:04 +02:00
Marko
d04392c5e2
chore: cleanup changelog (#13320) 2022-09-16 10:48:43 -04:00
Aaron Craelius
d9ef976412
feat(x/auth): define simplified account query service (#13210) 2022-09-16 09:12:41 +00:00
yihuang
6c4f94b671
fix: keep the balance query endpoint compatible with legacy blocks (#13301)
* keep the balance query endpoint compatible with legacy blocks

Closes: #13296

A temporary solution before the proxy tool developed, since the balance endpoint is too important.

* Update CHANGELOG.md

* Apply suggestions from code review

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Marko <marbar3778@yahoo.com>
2022-09-16 09:57:42 +02:00
atheeshp
ceffc5e01c
feat: x/auth determinism tests for Account query (#13255)
* WIP: rapid tests

* remove commented code

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* review changes

* `go mod tidy`
2022-09-16 09:22:09 +02:00
Amaury
340c01bf5a
fix!: Fix group amino codec (#13307)
* fix!: Fix group amino codec

* changelog
2022-09-15 17:06:43 +00:00
Aaron Craelius
5deb137f7a
feat: add proto annotation for Msg services (#13178)
* feat: add proto annotation for Msg services

* add annotation to Msg services

* proto gen

* add CHANGELOG entry

* expand doc string

* codegen

* revert

* proto-gen

* revert
2022-09-14 09:27:45 +00:00
Matt Kocubinski
b96bed5534
feat: add mempool interfaces (#13249)
* working out interfaces

* integration to checkTx

* use struct fields directly in sz calculation

* fix typo

* nil guard on mempool

* Remove tx builder method

* impl with panic
2022-09-13 21:25:44 +02:00
atheeshp
04858ea2ea
fix: sequence in sign-batch (#13200)
## Description

Closes: #13199 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-09-13 13:35:51 +00:00
Marko
a79eafa0b1
build docker without build-linux (#13257) 2022-09-13 10:08:38 +00:00