Commit Graph

1237 Commits

Author SHA1 Message Date
Jacob Gadikian
be8c5a09c2
chore: lint tests (#14268) 2022-12-18 23:48:31 +00:00
dependabot[bot]
1fa568733f
build(deps): Bump cosmossdk.io/core from 0.3.3 to 0.3.4 (#14344)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-16 18:34:00 +00:00
Emmanuel T Odeke
65b4fbc170
fix: client/tx: improve user experience on errors in BroadcastTx (#14254)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Marko <marbar3778@yahoo.com>
2022-12-16 16:00:05 +00:00
dependabot[bot]
aa771cc8ce
build(deps): Bump cosmossdk.io/core from 0.3.2 to 0.3.3 (#14325)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-12-15 21:20:55 +01:00
Julien Robert
5573a2f26b
feat: Add AutoCLI Sane Kebab Case (#14316) 2022-12-15 16:18:06 +00:00
Julien Robert
32bd61c9c0
fix: fix grpc flag conflict (#14244) 2022-12-10 21:42:22 +00:00
Julien Robert
4e2196fcc3
fix: app config and simapp (v1,v2) fixes (#14209) 2022-12-08 23:08:40 +01:00
Aaron Craelius
7d0a8dc714
feat: add --grpc client option (#14051)
* feat: add --grpc client option

* updates

* default to TLS credentials

* add min version because of gosec lint

Co-authored-by: Marko <marbar3778@yahoo.com>
2022-12-07 10:56:49 +00:00
Julián Toledano
6188f6e798
refactor!: key presentation outside keyring (#14151)
* refactor: move key presentation to client/keys

* refactor: move key presentation to client/keys

* update: changelog

Co-authored-by: Ezequiel Raynaudo <raynaudo.ee@gmail.com>
2022-12-07 10:22:19 +00:00
dependabot[bot]
4cfc79ad4e
build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-alpha8 to 1.0.0-beta.1 (#14122)
* build(deps): Bump github.com/cosmos/cosmos-proto

Bumps [github.com/cosmos/cosmos-proto](https://github.com/cosmos/cosmos-proto) from 1.0.0-alpha8 to 1.0.0-beta.1.
- [Release notes](https://github.com/cosmos/cosmos-proto/releases)
- [Commits](https://github.com/cosmos/cosmos-proto/compare/v1.0.0-alpha8...v1.0.0-beta.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-proto
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-alpha8 to 1.0.0-beta.1 for all modules

* updates

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-12-01 17:33:41 +00:00
Amaury
fb4d964f7e
refactor: don't break SignModeHandler API (#14087)
* refactor: Make SignModeHandler update not API breaking

* changelog

* fix tests

* add comment

* Revert rosetta

* address reviews

* shorter name

* Fix test build
2022-12-01 16:20:10 +01:00
Julien Robert
6239cdfddb
chore: clean-up deprecated function usage (#14078) 2022-11-30 01:10:50 +01:00
Amaury
fffc9d07d5
refactor!: Add context arg to sign mode handler GetSignBytes (#13701)
* refactor!: Add context arg to sign mode handler `GetSignBytes`

* fix build

* fix tests

* Fix goling

* fix lint

* Fix lint

* Fix test

* Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* Fix tests

* Fix rosetta deps

* fix

* go mod tidy all

* go mod tidy

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-11-29 18:49:51 +00:00
Julien Robert
e5038d8d76
chore: bumps math and api deps (#14035)
* chore: bumps math and api deps

* updates
2022-11-27 23:11:25 +01:00
Julien Robert
cfa224c04e
chore: add group and gov/v1 in swagger (#13984)
Co-authored-by: Marko <marbar3778@yahoo.com>
2022-11-24 00:24:38 +01:00
Julien Robert
ae91105fec
ci: configure monorepo sonarcloud (#13944) 2022-11-23 10:47:18 +00:00
dependabot[bot]
c7d49217d6
build(deps): Bump google.golang.org/grpc from 1.50.1 to 1.51.0 (#13953)
* build(deps): Bump google.golang.org/grpc from 1.50.1 to 1.51.0

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.50.1 to 1.51.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.50.1...v1.51.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): Bump google.golang.org/grpc from 1.50.1 to 1.51.0 for all modules

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-11-21 17:46:07 +01:00
Julien Robert
d9bc5acac8
fix: .String() panics when pubkey is set on a BaseAccount (#13838) 2022-11-14 14:56:18 +00:00
Julien Robert
4f7d9ea233
refactor: clean-up test helpers and tmcli (#13805) 2022-11-09 11:13:27 +00:00
Jacob Kim
f8e40d7c05
refactor: remove client/keys.KeysCdc (#13781) 2022-11-09 07:23:55 +00:00
Amaury
b49f948b36
feat: Add proto annotations for Amino JSON (#13501)
* add legacy_amino_name

* make-proto-gen

* remove useless omitempty

* add annotations

* Add proto annotations

* Add more annotations

* update cosmos-proto

* Add message scalar?

* Add comments

* Fix comment

* lint proto files

* proto-gen

* go mod tidy

* Add multisig encoding

* Add field name

* Format proto

* proto-gen

* Update proto/cosmos/msg/v1/msg.proto

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Add dont_omitempty whenever we have nullable=false

* proto-gen

* Remove problematic annotations

* put legacy_amino in subpackage

* proto-gen

* Fixes

* legacy_amino.v1

* add non-working proto

* Generate in separate package

* Remove `cosmos.msg` prefix

* make proto-gen

* remove v1 too

* make proto-format

* Add field option

* format

* proto-gen

* Use underscores

* update legacy_amino -> amino

* update to `key_field`

* make proto-format

* make proto-gen

Co-authored-by: Aaron Craelius <aaron@regen.network>
2022-11-07 22:51:51 +00:00
Aaron Craelius
b9e65b6d41
feat: add autocli app wiring + remote info support (#13281) 2022-11-01 21:34:59 +00:00
dependabot[bot]
84bd246e64
build(deps): Bump cosmossdk.io/api from 0.2.3 to 0.2.4 (#13713)
* build(deps): Bump cosmossdk.io/api from 0.2.3 to 0.2.4

Bumps [cosmossdk.io/api](https://github.com/cosmos/cosmos-sdk) from 0.2.3 to 0.2.4.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/cosmos/cosmos-sdk/compare/api/v0.2.3...api/v0.2.4)

---
updated-dependencies:
- dependency-name: cosmossdk.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): Bump cosmossdk.io/api from 0.2.3 to 0.2.4 for all modules

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-10-31 15:59:30 -04:00
Marko
348734a137
chore: proto format (#13685) 2022-10-28 17:40:48 +02:00
dependabot[bot]
be6b93d95c
build(deps): Bump cosmossdk.io/api from 0.2.2 to 0.2.3 (#13676) 2022-10-27 16:45:35 +00:00
Ari Rubinstein
f73e426b22
fix: prevent simple inclusion of a valid mnemonic (#13670) 2022-10-27 00:43:22 +02:00
dependabot[bot]
1d202c919c
build(deps): Bump cosmossdk.io/api from 0.2.1 to 0.2.2 in /simapp (#13666)
* build(deps): Bump cosmossdk.io/api from 0.2.1 to 0.2.2 in /simapp

Bumps [cosmossdk.io/api](https://github.com/cosmos/cosmos-sdk) from 0.2.1 to 0.2.2.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/cosmos/cosmos-sdk/compare/api/v0.2.1...api/v0.2.2)

---
updated-dependencies:
- dependency-name: cosmossdk.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): Bump cosmossdk.io/api from 0.2.1 to 0.2.2 in /simapp for all modules

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-10-26 19:16:43 +02:00
dependabot[bot]
ad08ec484a
build(deps): Bump github.com/spf13/cobra from 1.6.0 to 1.6.1 (#13648) 2022-10-25 18:45:40 +00:00
Julien Robert
209797f3be
chore: make format, make proto-update-deps, add 0.45.10 in changelog (#13623) 2022-10-24 15:23:12 +02:00
Marko
04db139e8a
chore: move pruning to store (#13609)
* move pruning to store

* add changelog entry

Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-10-24 14:02:17 +02:00
dependabot[bot]
f6b6143e66
build(deps): Bump google.golang.org/grpc from 1.50.0 to 1.50.1 in /api (#13573) 2022-10-17 20:31:47 +02:00
Aaron Craelius
de49cb4b1c
refactor!: rename autocli package (#13547) 2022-10-14 07:12:00 +00:00
Aaron Craelius
fa2cb40892
feat: implement autocli customization (#13251)
* feat: implement autocli customization

* WIP

* integrate simple options

* skip positional fields

* WIP

* WIP

* WIP

* trying to simplify diff, fixing errors

* WIP

* WIP

* tests passing again

* positional params working

* add TODO

* WIP on tests

* WIP on tests

* working tests

* doc strings

* docs

* tests

* tests

* simplify API

* proper validation

* fix import

* address review comments

* address review comments

Co-authored-by: Marko <marbar3778@yahoo.com>
2022-10-13 21:25:26 +00:00
dependabot[bot]
7122ded4ee
build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-alpha7 to 1.0.0-alpha8 (#13543)
* build(deps): Bump github.com/cosmos/cosmos-proto

Bumps [github.com/cosmos/cosmos-proto](https://github.com/cosmos/cosmos-proto) from 1.0.0-alpha7 to 1.0.0-alpha8.
- [Release notes](https://github.com/cosmos/cosmos-proto/releases)
- [Commits](https://github.com/cosmos/cosmos-proto/compare/v1.0.0-alpha7...v1.0.0-alpha8)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-proto
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-alpha7 to 1.0.0-alpha8 for all modules

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-10-13 19:25:47 +00:00
dependabot[bot]
9678f313ad
build(deps): Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 (#13507)
* build(deps): Bump github.com/spf13/cobra from 1.5.0 to 1.6.0

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](https://github.com/spf13/cobra/compare/v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 for all modules

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-10-11 18:28:42 +02:00
Aleksandr Bezobchuk
c60c55616d
feat: gRPC query for operator and chain configuration (#13485) 2022-10-10 19:12:00 +00:00
dependabot[bot]
b3abb8d5c3
build(deps): Bump gotest.tools/v3 from 3.3.0 to 3.4.0 in /core (#13494) 2022-10-10 19:10:15 +02:00
Jacob Gadikian
74efb1350a
fix: Update tendermint rpc client support for ibc-go compatibility (#13482) 2022-10-09 22:38:52 -04:00
dependabot[bot]
fbd81ba0b7
build(deps): Bump google.golang.org/grpc from 1.49.0 to 1.50.0 (#13467)
* build(deps): Bump google.golang.org/grpc from 1.49.0 to 1.50.0

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.49.0 to 1.50.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.49.0...v1.50.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): Bump google.golang.org/grpc from 1.49.0 to 1.50.0 for all modules

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2022-10-06 19:41:52 +02:00
Amaury
90bd3161a1
refactor: Improve and clarify API around AccountAddressById (#13460)
* Revert "chore: change id to use uint64 in `AccountAddressByID` (#13411)"

This reverts commit 3d0e214446.

* Add since

* Update CLI command

* make proto-gen

* id->accNum

* No API breaking changes

* improve err msg

* Update CHANGELOG.md

Co-authored-by: Julien Robert <julien@rbrt.fr>

* Update CHANGELOG.md

Co-authored-by: Julien Robert <julien@rbrt.fr>

Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-10-06 11:05:25 +00:00
Julien Robert
9bae8a817f
build(deps): bump go minimum version to go 1.19 (#13397) 2022-09-27 21:02:02 +02:00
Julien Robert
df40c0a9d1
refactor!: remove broadcast mode block (#12659) 2022-09-23 15:16:31 +00:00
Julien Robert
79f277c111
fix: fix buf commit link (#13345) 2022-09-20 21:21:45 +02:00
Julien Robert
7252f4a758
feat: CLI tooling to generate proposal JSONs (#13304) 2022-09-19 14:22:04 +02:00
Aaron Craelius
ae21d8c780
refactor!: autocli go.mod and package naming (#13294) 2022-09-14 23:11:11 +02:00
dependabot[bot]
85422881cf
build(deps): Bump github.com/cosmos/gogoproto from 1.4.1 to 1.4.2 (#13291)
Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.1 to 1.4.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/cosmos/gogoproto/releases">github.com/cosmos/gogoproto's releases</a>.</em></p>
<blockquote>
<h2>v1.4.2</h2>
<h3>Features</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/cosmos/gogoproto/pull/13">#13</a> Add <code>AllFileDescriptors</code> function.</li>
</ul>
<h3>Improvements</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/cosmos/gogoproto/pull/8">#8</a> Fix typo in <code>doc.go</code>.</li>
<li><a href="https://github-redirect.dependabot.com/cosmos/gogoproto/pull/8">#8</a> Support for merging messages implementing Merger which are embedded by value.</li>
<li><a href="https://github-redirect.dependabot.com/cosmos/gogoproto/pull/8">#8</a> Use reflect.Value.String() for String kinds in proto equal.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md">github.com/cosmos/gogoproto's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/cosmos/gogoproto/releases/tag/v1.4.2">v1.4.2</a> - 2022-09-14</h2>
<h3>Features</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/cosmos/gogoproto/pull/13">#13</a> Add <code>AllFileDescriptors</code> function.</li>
</ul>
<h3>Improvements</h3>
<ul>
<li><a href="https://github-redirect.dependabot.com/cosmos/gogoproto/pull/8">#8</a> Fix typo in <code>doc.go</code>.</li>
<li><a href="https://github-redirect.dependabot.com/cosmos/gogoproto/pull/8">#8</a> Support for merging messages implementing Merger which are embedded by value.</li>
<li><a href="https://github-redirect.dependabot.com/cosmos/gogoproto/pull/8">#8</a> Use reflect.Value.String() for String kinds in proto equal.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="739310d858"><code>739310d</code></a> docs: add changelog (<a href="https://github-redirect.dependabot.com/cosmos/gogoproto/issues/15">#15</a>)</li>
<li><a href="4f8afe8bcd"><code>4f8afe8</code></a> feat: add AllFileDescriptors function (<a href="https://github-redirect.dependabot.com/cosmos/gogoproto/issues/13">#13</a>)</li>
<li><a href="27e5769808"><code>27e5769</code></a> ci: fix proto registry workflow (<a href="https://github-redirect.dependabot.com/cosmos/gogoproto/issues/12">#12</a>)</li>
<li><a href="c3a0399b5e"><code>c3a0399</code></a> feat: cherry-pick improvements from <code>gogo/protobuf</code> (<a href="https://github-redirect.dependabot.com/cosmos/gogoproto/issues/8">#8</a>)</li>
<li><a href="ed9594ccc9"><code>ed9594c</code></a> chore: bump protobuf (<a href="https://github-redirect.dependabot.com/cosmos/gogoproto/issues/9">#9</a>)</li>
<li>See full diff in <a href="https://github.com/cosmos/gogoproto/compare/v1.4.1...v1.4.2">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/cosmos/gogoproto&package-manager=go_modules&previous-version=1.4.1&new-version=1.4.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
2022-09-14 19:19:00 +00:00
dependabot[bot]
85a1aa3ba0
build(deps): Bump cosmossdk.io/api from 0.2.0 to 0.2.1 in /orm (#13250)
* build(deps): Bump cosmossdk.io/api from 0.2.0 to 0.2.1 in /orm

Bumps [cosmossdk.io/api](https://github.com/cosmos/cosmos-sdk) from 0.2.0 to 0.2.1.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/cosmos/cosmos-sdk/compare/v0.2.0...api/v0.2.1)

---
updated-dependencies:
- dependency-name: cosmossdk.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* go mod tidy all

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-09-12 17:46:01 +00:00
Aaron Craelius
b41fd3fbf5
feat: add auto-cli customization options (#11763)
* feat(cli/v2): add command & flag proto options

* WIP

* docs

* update

* change name to use

* update use

* rename to autocli

* updates

* switch to (hopefully) more intuitive design

* docs

* updates

* updates

* add flag_options example
2022-09-12 15:51:08 +00:00
Emmanuel T Odeke
abe3e0c6da
perf: all: remove unnecessary allocations from strings.Builder.WriteString(fmt.Sprintf(...)) (#13230)
This change removes a code pattern that I noticed while on a late night
audit of cosmovisor in which
strings.Builder.WriteString(fmt.Sprintf(...))
calls were being made, yet that's counterproductive to using fmt.Fprintf
which will check whether the writer implements .WriteString and then
avoids the need to firstly build a string using fmt.Sprintf.

The performance wins from this change transcend all dimensions as
exhibited below:

```shell
$ benchstat before.txt after.txt
name            old time/op    new time/op    delta
DetailString-8    5.48µs ±23%    4.40µs ±11%  -19.79%  (p=0.000 n=20+17)

name            old alloc/op   new alloc/op   delta
DetailString-8    2.63kB ± 0%    2.11kB ± 0%  -19.76%  (p=0.000 n=20+20)

name            old allocs/op  new allocs/op  delta
DetailString-8      63.0 ± 0%      50.0 ± 0%  -20.63%  (p=0.000 n=20+20)
```

Fixes #13229
2022-09-09 21:57:46 +00:00
Ezequiel Raynaudo
4882f933b1
perf: reduce user's password prompts when calling keyring List function (#13207)
* Reduce user password prompts by taking advantage of the already existing MigrateAll function

* Print message when no records were found on the keyring

* Update changelog

* Fix migration test

* Add keys sort
2022-09-09 11:38:10 +00:00