Commit Graph

159 Commits

Author SHA1 Message Date
Jacob Gadikian
be8c5a09c2
chore: lint tests (#14268) 2022-12-18 23:48:31 +00:00
Matt Kocubinski
b46d838502
refactor: x/group 0.47 audit (#14290) 2022-12-13 20:59:52 +00:00
Marko
755c99ac44
refactor: use proto.Message instead of ProtoMarshler (#14208) 2022-12-08 19:38:38 +00:00
Amaury
4ebe3aa93c
fix(group)!: Don't re-tally proposals after VP end (#14071) 2022-11-30 11:01:17 +00:00
Julien Robert
6239cdfddb
chore: clean-up deprecated function usage (#14078) 2022-11-30 01:10:50 +01:00
Julien Robert
cfd79fc39e
feat: add Genesis JSON migration for group (#14024) 2022-11-29 14:00:14 +00:00
Julien Robert
6f329d70c6
docs: add docs about x/auth/tx (#14021)
* docs: add docs about `x/auth/tx`

* updates

* updates

* updates

* updates

* updates

* updates

* updates

Co-authored-by: Marko <marbar3778@yahoo.com>
2022-11-27 20:30:23 +00:00
Julien Robert
d6da7037b6
fix(group): migrate group policy account to base accounts with credentials (#13742) 2022-11-21 22:46:48 +00:00
Julien Robert
34dcca710b
chore: remove typo (#13914) 2022-11-18 07:51:47 +00:00
Amaury
7661f62737
fix(group)!: Fix group min execution period (#13876)
* fix: don't check MinExecutionPeriod in `Allow`

* Check MinExecutionPeriod on doExecuteMsgs

* Fix TestExec

* Fix TestExec

* test exec pruned

* Fix submitproposal

* Add changelog

* typo

* revert some changes

* add minExecutionPeriod

* Add docs and specs
2022-11-16 12:37:06 +00:00
Julien Robert
3423442ab1
fix(group): add group members weight checks (#13869) 2022-11-15 22:15:32 +01:00
Aaron Craelius
ec27c5384b
refactor!: migrate to core appmodule.AppModule extension interfaces (#13794) 2022-11-14 21:23:55 +00:00
Damian Nolan
90fd3e9f42
fix: propagate events in x/group through sdk.Results (#13808) 2022-11-09 14:32:13 +00:00
Amaury
b49f948b36
feat: Add proto annotations for Amino JSON (#13501)
* add legacy_amino_name

* make-proto-gen

* remove useless omitempty

* add annotations

* Add proto annotations

* Add more annotations

* update cosmos-proto

* Add message scalar?

* Add comments

* Fix comment

* lint proto files

* proto-gen

* go mod tidy

* Add multisig encoding

* Add field name

* Format proto

* proto-gen

* Update proto/cosmos/msg/v1/msg.proto

Co-authored-by: Aaron Craelius <aaron@regen.network>

* Add dont_omitempty whenever we have nullable=false

* proto-gen

* Remove problematic annotations

* put legacy_amino in subpackage

* proto-gen

* Fixes

* legacy_amino.v1

* add non-working proto

* Generate in separate package

* Remove `cosmos.msg` prefix

* make proto-gen

* remove v1 too

* make proto-format

* Add field option

* format

* proto-gen

* Use underscores

* update legacy_amino -> amino

* update to `key_field`

* make proto-format

* make proto-gen

Co-authored-by: Aaron Craelius <aaron@regen.network>
2022-11-07 22:51:51 +00:00
Julien Robert
d6e5bb3669
docs: fix toc links (#13770) 2022-11-04 15:35:22 +00:00
Julien Robert
08be7ee74b
refactor: extract MockTendermintRPC to testutil/cli 2022-11-03 22:40:52 +00:00
Emmanuel T Odeke
cafa6b5125
fix: x/group/internal/orm: return iterator close errors (#13714)
Instead of nakedly always returning nil, instead return
the actual close errors.

Fixes https://github.com/cosmos/cosmos-sdk/security/code-scanning/6295
Fixes https://github.com/cosmos/cosmos-sdk/security/code-scanning/6296
2022-11-01 08:24:41 +00:00
Julien Robert
0d8787c3bd
feat: handle additional x/auth module app config parameters (#13684) 2022-11-01 06:39:21 +00:00
Amaury
9a9e5b59ae
fix(group)!: Register types with Amino (#13592)
* fix!(group): Register types with Amino

* Chagenlog
2022-10-19 13:16:23 +00:00
Giancarlos Salas
18d8b64ce5
refactor: check begin, end block interface extensions (#13560) 2022-10-17 08:17:01 +00:00
Aaron Craelius
f3a558c6b4
refactor!: require exported app wiring providers (#13292) 2022-10-10 20:27:44 +00:00
Julien Robert
214b11dcba
feat: add github links in docs (#13491)
* feat: add github links in docs

* apply proto theme

* fix toc
2022-10-10 20:02:32 +02:00
Julien Robert
a74989ddf4
feat: migrate to docusaurus (#13471) 2022-10-10 14:01:53 +00:00
Julien Robert
74ce07eb26
docs: improve documentation navigation and redirection (#13455) 2022-10-06 15:51:10 +02:00
Amaury
90bd3161a1
refactor: Improve and clarify API around AccountAddressById (#13460)
* Revert "chore: change id to use uint64 in `AccountAddressByID` (#13411)"

This reverts commit 3d0e214446.

* Add since

* Update CLI command

* make proto-gen

* id->accNum

* No API breaking changes

* improve err msg

* Update CHANGELOG.md

Co-authored-by: Julien Robert <julien@rbrt.fr>

* Update CHANGELOG.md

Co-authored-by: Julien Robert <julien@rbrt.fr>

Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-10-06 11:05:25 +00:00
Marko
306a9a7170
feat!: consensus module (#12905) 2022-10-05 18:06:24 +00:00
Emmanuel T Odeke
abdf61e292
fix: all: remove map iteration non-determinism with keys + sorting (#13377) 2022-09-24 16:20:54 +00:00
Jacob Gadikian
af816057f2
chore: run make format (#13375) 2022-09-24 00:22:03 +02:00
Julien Robert
df40c0a9d1
refactor!: remove broadcast mode block (#12659) 2022-09-23 15:16:31 +00:00
Julien Robert
7eb259fd86
feat: add draft-proposal for x/group (#13353)
* feat: add `draft-proposal` for x/group

* add changelog

* extract useful function

* add `GetMsgFromTypeURL` tests
2022-09-22 00:53:02 +02:00
Julien Robert
7252f4a758
feat: CLI tooling to generate proposal JSONs (#13304) 2022-09-19 14:22:04 +02:00
Amaury
340c01bf5a
fix!: Fix group amino codec (#13307)
* fix!: Fix group amino codec

* changelog
2022-09-15 17:06:43 +00:00
Aaron Craelius
5deb137f7a
feat: add proto annotation for Msg services (#13178)
* feat: add proto annotation for Msg services

* add annotation to Msg services

* proto gen

* add CHANGELOG entry

* expand doc string

* codegen

* revert

* proto-gen

* revert
2022-09-14 09:27:45 +00:00
likhita-809
fdf5a7b161
fix: Add withdraw proposal cmd to group's CLI tx cmds (#13214)
* add withdraw proposal cmd to group's cli tx cmds

* add changelog
2022-09-09 09:18:36 +02:00
Daniel Wedul
6a6e6c7802
feat(bank): Create message for Setting SendEnabled settings (#11981)
* go mod tidy everything.

* Add some third_party proto files that are imported but not included.

* [11859]: Add a new key for the SendEnabled flags and keeper methods for getting, setting, and deleting them.

* [11859]: Remove the send_enabled field from the bank Params proto.

* Revert "Add some third_party proto files that are imported but not included."

This reverts commit 8b7acf89f27825ba25bfef3379fd422a307a5e1b.

* [11859]: Regenerate the bank params stuff from the changed proto.

* [11859]: Add a send_enabled field to the bank genesis proto.

* Revert "[11859]: Remove the send_enabled field from the bank Params proto."

This reverts commit 0bd904c1f6ac0ea2d6e5b7dd43911d596cbf3ac9.

* Revert "[11859]: Regenerate the bank params stuff from the changed proto."

This reverts commit 33d4652696d2c3aefc6937dbf281525c1f86f79e.

* [11859]: Deprecate the bank Params send_enabled field.

* [11859]: Regenerate the bank go code from the updated protos.

* [11859]: Reduce the number of times the store is recreated during IsSendEnabledCoins. Store creation has some overhead.

* [11859]: Add the SendEnabled stuff to the genesis methods. Make a couple TODO notes. Create a way to iterate over the SendEnabled entries and get all of them.

* [11859]: Update the bank sim genesis stuff to create random SendEnabled entries similar to when they were params.

* Remove some of the bank params methods that are no longer meaningful.

* Add a comment about why we're calling a mutation method in a Validate function.

* [11859]: Add some more TODO notes and make the SendEnabled.String() function significantlly simpler.

* [11859]: Get rid of the SendEnabledParams type.

* Fix up a few comments.

* [11859]: Update the bank keeper test due to recent changes.

* [11859]: Tweak the bank Params and SendEnabled String funcs. Params no longer returns {} when there aren't any SendEnabled entries and the default is false. SendEnabled is back to outputting a yaml format.

* [11859]: Fix the params tests and add some new ones to it and key_test.

* [11859]: Create a 1-store method for updating several SendEnabled entries at once.

* [11859]: Create a migration for both the module and genesis state.

* [11859]: Create a new MsgSetSendEnabled for governanance proposals to set SendEnabled.

* [11859]: Add SetAllSendEnabled to the SendKeeper interface.

* [11859]: Add an authority to the bank keeper and create the handler for MsgSetSendEnabled.

* [11859]: Add an rpc endpoint for querying SendEnabled.

* [11859]: Implement the SendEnabled query.

* [11859]: Add a function for decoding a --page-key base64 value so that pagination can work as expected.

* [11859]: Implement a CLI command for querying SendEnabled.

* [11859]: Move the v047 store migration stuff into Migrate3to4 directly to prevent a circular dependency between 047 and the keeper. Not using the keeper for that would be a significant pain in the butt.

* [11869]: Implement the Msg interface for MsgSetSendEnabled.

* [11859]: Fix some unit tests that I broke along the way.

* [11859]: Reorg the funcs added to the SendKeeper interface.

* [11859]: Fix the return values of a couple of the MsgSetSendEnabled LegacyMsg funcs.

* [11859]: Tweak MigrateSendEnabled to add stuff to the existing slice (if there's anything to add). And then use that in the MigrateGenState function.

* [11859]: Don't set the Pagination field when looking up specific entries.

* [11859]: Put validateSendEnabledParams back to the way it was to allow reading the old Params without error.

* [11859]: Write up a bunch of unit tests.

* [11859]: Update the MsgSetSendEnabled.ValidateBasic() function with some extra failure points. Write up some tests.

* Update a test I fixed then broke.

* [11859]: Have the run-tests make target exit with a non-zero status if any of the tests fail.

* [11859]: Add changelog entries.

* [11859]: Add a missing func comment.

* [11859]: Only do a couple assertions if the elements exist to do so.

* [11859]: Add some more missing function comments.

* [11859]: Update the bank spec documentation.

* [11859]: Change name of WithPageKeyDecoded to FlagSetWithPageKeyDecoded, have it return an error and make MustFlagSetWithPageKeyDecoded for the one-liner.

* [11859]: Update the documentation on the SendEnabled query.

* [11859]: Add final newline to query.proto.

* [11859]: Upddate the SetSendEnabled endpoint to allow deleting entries and update the default value.

* [11859]: Regen code from protos to include recent changes.

* [11859]: Implement the functionality newly added to MsgSetSendEnabled.

* [11859]: Remove the SetSendEnabled msg and endpoint.

* [11859]: Add new fields to NewMsgSetSendEnabled.

* [11859]: Tweak the incorrect authority error a little to make it clearer.

* [11859]: Add some unit tests on handling of the MsgSetSendEnabled message.

* [11859]: Change the use_default field to use_default_for to make it less ambiguous.

* [11859]: Tweak a test to check that DeleteSendEnabled works with multiple denoms.

* [11859]: Add a test about a bad denom in the UseDefaultFor list.

* [11859]: Use nil instead of an empty slice of SendEnabled for defaults and where called for.

* [11859]: Update SetParams to migrate entries too.

* [11859]: Remove the spec doc info about the MsgSetSendEnabled that's part of another PR.

* [11859]: Update the bank spec docs again since that last merge undid it.

* [11859]: Update the changelog.

* Revert "[11859]: Update the changelog."

This reverts commit 85052b8579ec6bfac3411970a1597363329d6d66.

* [11859]: Update the changelog.

* [11859]: Rename the QuerySendEnabled message to QuerySendEnabledRequest to match the other messages in that proto.

* [11859]: Remove the authority field that is only needed for governance stuff (in the other PR).

* Revert "[11859]: Remove the authority field that is only needed for governance stuff (in the other PR)."

This reverts commit 93f414887109dc97062a68746616f7f5ce0e3648.

* [11859]: Add a version to the deprecation message.

* [11859]: Add unit test on MsgSetSendEnabled with the correct authority, but not signed by that address.

* [11859]: Update the comment on the now-deprecated SendEnabled params proto field to reference 0.46 instead of 0.47.

* Add some spacing to GetCmdQuerySendEnabled -> RunE.

* [11859]: Create banktypes.GenesisState.GetAllSendEnabled() to house the combination logic of the SendEnabled field and Params.SendEnabled. Have MigrateSendEnabled() use that. Remove some calls to MigrateSendEnabled and use GetAllSendEnabled in those cases.

* [11859]: Update Bank's ConsensusVersion to 4.

* [11859]: Add 'Since' comments to the new proto stuff.

* Add the authority to the bankInputs so it can be provided to NewBaseKeeper. I've no clue how that will get set though.

* [11859]: Fix a unit test that broke because it assumed the bank module's version was 3.

* [11859]: Remove an empty line.

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* [11859]: Remove movement of SendEnabled from the `ExportGenesis` function too.

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* [11859]: Hard-code the bank authority value with a TODO to allow injection of that value.

* [11859]: Inject the authority string for the bank module provider.

* [11859]: inject the bank authority value for module unit tests that need it.

* [11859]: Add a unit test for MsgSendEnabled.ValidateBasic that has an empty authority.

* [11859]: Don't require a MsgSetSendEnabled.Authority value in ValidateBasic. Maybe that field is supposed to be filed in by the governance module before passing on the message.

* [11859]: Update the capability testutil app_config to include the new bank authority value.

* [11859]: Undo the banktypes.Authority type thing.

* [11859]: Fix bad merge piece.

* Fix a couple unit tests that broke with the merge.

* [11859]: Remove the Route and Type LegacyMsg functions from the new MsgSetSendEnabled.

* [11859]: Add 'Since: cosmos-sdk 0.47' to the new proto stuff.

* [11859]: Get rid fo the BaseKeeper.GetAuthority since it was added to the SendKeeper.

* [11859]: emit an event when processing a SetSendEnabled.

* [11859]: Update MsgSetSendEnabled.ValidateBasic to return wrapped sdk errors.

* Add a link in the bank spec readme to the MsgUpdateParams.

* rename govtypesv1 import to govv1 since that's what's used elsewhere.

* [11859]: Update changelog link to point at the PR instead of the issue number.

* [11859]: Add some extra test cases for GetAuthority.

* Move changelog entry to unreleased.

* [11859]: Change a call to moduletestutil.MakeTestEncodingConfig (from simapp.MakeTestEncodingConfig).

* [11859]: Add SetSendEnabled to the MockBankKeeper.

* [11859]: make mocks.

* [11859]: Fix the bank app tests (had compilation issues due to merge changes).

* [11859]: Remove the set_default_send_enabled and default_send_enabled fields from MsgSetSendEnabled.

* [11859]: Remove any uses/references to the removed set_default_send_enabled and default_send_enabled fields.

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Daniel Wedul <github@wedul.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2022-09-09 00:21:54 +00:00
Julien Robert
6d0ef15b0a
refactor: migrate to cosmos/gogoproto (#13070) 2022-09-08 17:27:48 +00:00
Amaury
d9972c4dd1
fix!: Fix gov amino codec (#13196)
* fix!: Fix gov amino codec

* changelog
2022-09-08 15:35:57 +00:00
Marko
1ad3b29560
chore: proto image migrate to ghcr (#13168) 2022-09-07 12:03:00 +00:00
likhita-809
2efee04e4f
refactor(group): CLI tests using Tendermint Mock (#13067) 2022-09-05 14:31:30 +00:00
Aleksandr Bezobchuk
a0682b14f4
chore: collapse module spec and readme (#13143)
* updates

* add auth and separate vesting

* authz

* capability

* crisis

* epoching

* nft

* mint

* params

* upgrade

* fix website build

* finish other modules

* fix `pre.sh` and update modules title

* add docs

* display vesting in docs

* add page splitting for missing modules

* updates

* improve `pre.sh`

Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-09-05 12:26:40 +00:00
Sam Hart
6d6b804a73
docs: adds gov groups metadata spec (#13118) 2022-09-02 09:04:08 +00:00
Aleksandr Bezobchuk
9948fb6c7c
feat: emit cached context events (#13063) 2022-09-01 21:29:28 +00:00
Aleksandr Bezobchuk
0eacc88096
fix: fix Group-TotalWeight invariant (#13116) 2022-09-01 17:19:09 +00:00
dependabot[bot]
084e129fcf
build(deps): Bump pgregory.net/rapid from 0.4.8 to 0.5.2 (#13096)
* build(deps): Bump pgregory.net/rapid from 0.4.8 to 0.5.2

Bumps [pgregory.net/rapid](https://github.com/flyingmutant/rapid) from 0.4.8 to 0.5.2.
- [Release notes](https://github.com/flyingmutant/rapid/releases)
- [Commits](https://github.com/flyingmutant/rapid/compare/v0.4.8...v0.5.2)

---
updated-dependencies:
- dependency-name: pgregory.net/rapid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix group tests

* update orm to 0.5.2

* Fix some tests

* finish upgrading orm

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-08-30 20:17:15 +00:00
atheeshp
9412bcd82a
feat: x/group tests to mocks (#12864)
## Description

Closes: #12763 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-08-22 12:37:05 +00:00
Julien Robert
77a96d5fe1
docs: update sdk & tm version links in docs (#12976)
* docs: update sdk & tm version links in docs

* revert unrelated change
2022-08-20 08:42:13 +02:00
Julien Robert
1dee068932
chore: downgrade to tendermint v0.34.x (#12958) 2022-08-20 02:33:07 +02:00
Jacob Gadikian
0943a70215
chore: fix linting issues exposed by fixing golangci-lint (#12895)
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-08-11 22:00:24 +02:00
Damian Nolan
014bfae00f
fix(x/group): propagate events correctly to current context (#12888)
* fix(x/groups) propagate events correctly to current context

* update to use current context on logger

* adding changelog entry

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2022-08-10 15:35:33 +02:00
likhita-809
7496aa3d27
feat: Remove RandomizedParams from the AppModuleSimulation interface (#12846)
* remove RandomizedParams from AppModuleSimulation interface

* add changelog

* add upgrading doc

* nit fix

Co-authored-by: Marko <marbar3778@yahoo.com>
2022-08-10 14:34:45 +02:00