Commit Graph

3880 Commits

Author SHA1 Message Date
Jacob Gadikian
be8c5a09c2
chore: lint tests (#14268) 2022-12-18 23:48:31 +00:00
Julien Robert
b81f385cc5
docs: improve voting wording (#14340) 2022-12-16 21:04:20 +07:00
Julien Robert
ce167a2074
test: rename e2e tests (#13913) 2022-12-15 10:55:01 +01:00
Matt Kocubinski
b17c2d902e
refactor: x/staking 0.47 audit (#14303) 2022-12-14 23:09:32 +00:00
Julien Robert
05a6da32e2
refactor: improve x/upgrade app wiring (part of upgrade audit) (#14216) 2022-12-14 21:21:58 +01:00
Matt Kocubinski
b46d838502
refactor: x/group 0.47 audit (#14290) 2022-12-13 20:59:52 +00:00
Julien Robert
b634182ed5
refactor: x/evidence audit (#14260) 2022-12-13 20:05:56 +00:00
Julien Robert
99b5919194
refactor: types audit (#14283) 2022-12-13 15:41:57 +01:00
Amaury
1bd9cbe9e0
fix(gov): Fix v3 votes migrations (#14214)
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2022-12-13 09:23:38 +00:00
Aleksandr Bezobchuk
18b0fa0507
refactor: audit x/bank package changes in 0.47 release (#14076) 2022-12-09 17:10:21 +01:00
atheeshp
7ded32163b
chore: x/slashing audit changes (#14211)
## Description

ref: #14158 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-12-09 10:00:44 +00:00
Julien Robert
a4d885fe2a
feat(api): add order_migrations argument in runtime.Module config (#14213) 2022-12-08 19:58:56 +00:00
Marko
755c99ac44
refactor: use proto.Message instead of ProtoMarshler (#14208) 2022-12-08 19:38:38 +00:00
Likhita Polavarapu
bd59987df1
refactor: x/upgrade audit changes (#14188) 2022-12-08 13:02:49 +01:00
Ruslan Akhtariev
ecb4ca2a82
feat(simapp): move genesis related commands under one genesis command (#14149) 2022-12-07 12:17:19 +00:00
Likhita Polavarapu
f1062c7f2c
refactor: x/gov audit changes (#14174)
* make proto changes

* wip

* wip

* wip

* `make lint-fix`

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-12-07 00:51:34 +00:00
Aleksandr Bezobchuk
66dd2be12c
chore: cleanup baseapp tests (#14162) 2022-12-06 16:52:36 +00:00
atheeshp
8a2c93fb7d
chore: x/authz audit changes (#14120)
* chore: x/authz audit changes

* nits

* tests

* Update x/authz/keeper/msg_server_test.go

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2022-12-06 13:03:04 +00:00
Amaury
a1dc6d9998
chore(consensus): Add grpc proto comments and cleanups (#14156)
* chore(consensus): Add grpc proto comments

* refactor: x/consensus audit changes (#14110)

* refactor: x/consensus audit changes

Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com>
2022-12-06 09:40:17 +00:00
Amaury
fb4d964f7e
refactor: don't break SignModeHandler API (#14087)
* refactor: Make SignModeHandler update not API breaking

* changelog

* fix tests

* add comment

* Revert rosetta

* address reviews

* shorter name

* Fix test build
2022-12-01 16:20:10 +01:00
Likhita Polavarapu
37a9bc3bb6
refactor: x/evidence audit changes (#14092)
## Description

ref: #14063 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-12-01 08:39:10 +00:00
Paul Weidner
b9e0a40770
chore: correct language for fee granter error (#14111)
## Description

Closes: #XXXX

Right now this error message contains the word "not" twice. I don't think we want the double negative here ;-)

Example:
```
regen1sk9nwk0w7kct04tsdscqvg5knn6kzz7yq59arx does not not allow to pay fees for regen1n9dpmra4d2gvu22jmxv7tenjy0mdymfg70hd48: basic allowance: fee limit exceeded
```



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-12-01 08:12:27 +00:00
Likhita Polavarapu
65a991389f
refactor: Add back removed empty checks in grpc from x/nft audit 2022-12-01 08:49:51 +01:00
atheeshp
e0875661b6
chore: (x/mint) improve code cov (#14066)
## Description

missed the test coverage in last audit.
ref: #13988 #13456 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-11-30 11:32:40 +00:00
Amaury
4ebe3aa93c
fix(group)!: Don't re-tally proposals after VP end (#14071) 2022-11-30 11:01:17 +00:00
atheeshp
4a9062122b
chore: (x/feegrant) add missing test scenarios (#14018)
* add missing test scenarios

* review changes
2022-11-30 07:46:01 +00:00
Likhita Polavarapu
ac6b19df21
refactor: x/nft audit changes (#14055)
## Description

ref: #13991 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-11-30 07:23:30 +00:00
Julien Robert
6239cdfddb
chore: clean-up deprecated function usage (#14078) 2022-11-30 01:10:50 +01:00
Amaury
fffc9d07d5
refactor!: Add context arg to sign mode handler GetSignBytes (#13701)
* refactor!: Add context arg to sign mode handler `GetSignBytes`

* fix build

* fix tests

* Fix goling

* fix lint

* Fix lint

* Fix test

* Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* Fix tests

* Fix rosetta deps

* fix

* go mod tidy all

* go mod tidy

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-11-29 18:49:51 +00:00
Julien Robert
cfd79fc39e
feat: add Genesis JSON migration for group (#14024) 2022-11-29 14:00:14 +00:00
Julien Robert
a1b09a0481
refactor: remove gogoproto stringer annotations (#14046) 2022-11-29 13:34:03 +00:00
Julien Robert
41f0ab15e6
refactor: remove gogoproto stringer annotations and MarshalYAML functions (#13850) 2022-11-28 12:56:00 +00:00
atheeshp
5567828674
chore: update docs (#14038) 2022-11-28 12:12:20 +01:00
Julien Robert
e5038d8d76
chore: bumps math and api deps (#14035)
* chore: bumps math and api deps

* updates
2022-11-27 23:11:25 +01:00
Julien Robert
6f329d70c6
docs: add docs about x/auth/tx (#14021)
* docs: add docs about `x/auth/tx`

* updates

* updates

* updates

* updates

* updates

* updates

* updates

Co-authored-by: Marko <marbar3778@yahoo.com>
2022-11-27 20:30:23 +00:00
Facundo Medica
16c772d900
docs: (x/distribution) Fix docs for v0.47 (#14022) 2022-11-25 14:14:37 +00:00
Likhita Polavarapu
a19eead691
refactor: x/crisis audit changes (#13990)
* wip: nits

* add tests for VerifyInvariant and increase codecov for keeper

* add genesis test

* cover all keeper code in tests

Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-11-24 14:53:22 +00:00
Likhita Polavarapu
e260fc1c89
feat: Add tx encode and decode endpoints for amino txs (#13882)
* add proto changes

* make proto-gen

* wip: adds tests

* wip: tests

* remove consoles

* wip: fix something

* fix: encode amino tests

* add decode amino tests

* wip: address requested changes

* update proto inline docs

* address review comments

Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
2022-11-24 13:41:03 +00:00
Youngtaek Yoon
b585d17e72
fix: make downgrade verification work again (#13936) 2022-11-23 10:51:54 +00:00
Julien Robert
d6da7037b6
fix(group): migrate group policy account to base accounts with credentials (#13742) 2022-11-21 22:46:48 +00:00
Amaury
f124cb71ae
refactor: x/consensus audit changes (#13949) 2022-11-21 16:17:40 +01:00
atheeshp
42597ee593
chore: added new field account-id with uint64 in AccountAddressByID (#13780)
* add changes

* Update CHANGELOG.md

* Update CHANGELOG.md

* review changes

* add test

* fix static check

* fix lint

* fix lint

* fix lint

* review changes

* review changes

* review changes

* review changes

* fix tests

* Update CHANGELOG.md

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>

* Update proto/cosmos/auth/v1beta1/query.proto

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>

* review changes

* lint

* review changes

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
2022-11-21 11:50:10 +00:00
John Letey
5581f7f300
fix: correctly propagate msg errors in gov (#13918)
* fix: correctly propagate msg errors in gov

* chore: update changelog

* fix: correctly check proposal status in tests

* chore: delete unused var
2022-11-18 16:27:06 +00:00
Julien Robert
eb4afa74ba
ci: configure sonarcloud (#13921) 2022-11-18 15:14:49 +00:00
Julien Robert
34dcca710b
chore: remove typo (#13914) 2022-11-18 07:51:47 +00:00
atheeshp
e2ae2bb551
fix: attempt fixing evidence flaky test (#13901) 2022-11-17 10:44:25 -05:00
Facundo Medica
394f1b9478
fix: InitGenesis changes account numbers (upstream fix from Provenance) (#13877)
* fix: InitGenesis changes account numbers (upstream fix from Provenance)

* cl++

* rename GetNextAccountNumber to NextAccountNumber

* suggestion from @julienrbrt

* cl++

* fix readme

* missing replace
2022-11-16 14:13:20 -03:00
Amaury
7661f62737
fix(group)!: Fix group min execution period (#13876)
* fix: don't check MinExecutionPeriod in `Allow`

* Check MinExecutionPeriod on doExecuteMsgs

* Fix TestExec

* Fix TestExec

* test exec pruned

* Fix submitproposal

* Add changelog

* typo

* revert some changes

* add minExecutionPeriod

* Add docs and specs
2022-11-16 12:37:06 +00:00
Julien Robert
3423442ab1
fix(group): add group members weight checks (#13869) 2022-11-15 22:15:32 +01:00
Julien Robert
f82775ba1f
docs: add documentation for nft module (#13871) 2022-11-15 14:45:19 +00:00