Commit Graph

384 Commits

Author SHA1 Message Date
ValarDragon
c708c799fd Add print-response flag 2018-07-05 22:19:50 -07:00
ValarDragon
2197a9598b Merge branch 'dev/add_async_flag' of github.com:cosmos/cosmos-sdk into dev/add_async_flag 2018-07-05 20:19:39 -07:00
ValarDragon
8857b69d02 Use async flag directly from context 2018-07-05 20:15:40 -07:00
Dev Ojha
be9ae47b0a
Merge branch 'develop' into dev/add_async_flag 2018-07-05 20:06:52 -07:00
ValarDragon
27a31cae44 add Async to context 2018-07-05 20:05:17 -07:00
Christopher Goes
1f3ab377ae
Merge PR #1570: stake/client: Fix panic on if validator doesn't exist 2018-07-06 04:26:39 +02:00
ValarDragon
6f94dd64c0 cli: Add async flag to all broadcasting txs
closes #1436
2018-07-05 19:15:37 -07:00
ValarDragon
8fc6e68511 stake/client: Fix panic on if validator doesn't exist
Closes #1505
2018-07-05 18:24:02 -07:00
Ismail Khoffi
abce54ea60
Merge branch 'develop' into sort_getsignbytes 2018-07-06 01:31:34 +01:00
Liamsi
b7f902fba5 sort *all* GetSignBytes:
- call MustSortJSON before return JSON bytes to guarantee alphabetic
ordering

- moved SortJSON and MustSortJSON to types package to avoid cyclic
package dep
2018-07-06 01:12:57 +01:00
Liamsi
0f1ceb073e sort all relevant GetSignBytes:
- call SortJSON before return JSON bytes to guarantee alphabetic
ordering
2018-07-06 00:23:12 +01:00
Ethan Buchman
84ecd1e043
Merge pull request #1339 from forbole/develop
Update testnet readme and use Bech32-encoded delegator address
2018-07-05 16:59:04 -04:00
rigelrozanski
aed3a87366 address cwgoes comments 2018-07-04 17:07:06 -04:00
rigelrozanski
f152b64952 Merge remote-tracking branch 'origin/develop' into rigel/no_keys_in_state_value 2018-07-04 14:29:12 -04:00
rigelrozanski
a2f7b582df validators smaller values stored 2018-07-04 01:32:49 -04:00
rigelrozanski
04921b9ebd ubd and red more limited values 2018-07-04 00:29:02 -04:00
Alexander Bezobchuk
0b9e0f2afc Merge PR #1492: Improve Module Test Coverage
* Merge pull request #1492: Improve Module Test Coverage
* Revert renaming of SignCheckDeliver [#1492]
* Remove named fields from stake unit tests & fix comments [#1492]
* update for tmlibs->tendermint/libs
* Remove tmlibs dependency
2018-07-04 06:21:36 +02:00
rigelrozanski
199c1e81eb delegations new key format ported 2018-07-03 23:44:54 -04:00
Rigel
cae6b40221
Merge pull request #1467: staking index keys don't hold values
* docs: Explain the expected return type within the store (#1452)

* bug somewhere here

* ...

* ...

* fix appending over key

* keys cleanup

* changelog

* remove some junk

* address bucky comments - rearrange appends

* hard code address length
2018-07-03 19:15:48 -04:00
rigelrozanski
ab964da105 marshal/unmarshal delegation 2018-07-03 15:03:35 -04:00
Rigel
f50c7be976
Merge branch 'develop' into rigel/stake-spec-compliance 2018-07-03 13:37:59 -04:00
rigelrozanski
4f0c7d8746 address bucky comments - rearrange appends 2018-07-03 13:37:17 -04:00
Ethan Buchman
d388036454 Merge PR #1520: various fixes for test_cli
* various fixes for test_cli
* linting
2018-07-03 06:33:53 +02:00
rigelrozanski
271fbb2db3 remove some junk 2018-07-02 21:16:32 -04:00
Rigel
2a2f5db450
Merge branch 'develop' into rigel/stake-spec-compliance 2018-07-02 21:03:46 -04:00
rigelrozanski
6f3b4c1805 keys cleanup 2018-07-02 20:58:22 -04:00
rigelrozanski
96f2d2983b Merge branch 'rigel/stake-spec-compliance' of https://github.com/cosmos/cosmos-sdk into rigel/stake-spec-compliance 2018-07-02 20:08:55 -04:00
Ethan Buchman
aa243565ce fix appending over key 2018-07-02 20:09:57 -04:00
rigelrozanski
2355e5ae6e ... 2018-07-02 20:05:52 -04:00
rigelrozanski
b3d6a59c61 ... 2018-07-02 18:58:52 -04:00
rigelrozanski
ab4661f88b bug somewhere here 2018-07-02 18:16:47 -04:00
Ethan Buchman
f78f30c67a update for tm v0.22.0. tmlibs->tendermint/libs 2018-07-02 16:34:06 -04:00
Rigel
f1937bc0e7
Merge branch 'develop' into rigel/stake-spec-compliance 2018-07-02 12:06:20 -04:00
Dev Ojha
6a864923fa types: Rename rational.Evaluate to rational.Round (#1487)
* rational.Evaluate -> rational.RoundInt64
	* rational.EvaluateInt -> rational.RoundInt

This done to improve clarity of the code.

Closes #1485
2018-07-02 11:57:33 -04:00
Christopher Goes
3654579ea7
Merge PR #1278: Slashing v2
Implement semifinal Gaia slashing spec (#1263), less #1348, #1378, and #1440 which are TBD.
2018-06-30 05:34:55 +02:00
Dev Ojha
955a0c9af7 Switch asserts to require (#1483)
* meta: Switch the majority of asserts to require

Switch most assert statements to require, to ease debugging.
Closes #1418

* Fix imports
2018-06-30 03:10:15 +02:00
Dev Ojha
097dd8a164 tools: Add unparam linter (#1443)
* tools: Add unparam linter

unparam detects unused parameters in functions, and a parameter to
a function which only ever takes on one value. The latter is an
indication that more tests are required.

There are many nolints in this PR, as I believe that writing tests
to fix alot of these situations is out of scope for this PR / it
will be changed in future commits. There are some nolints for
when we have to comply to normal api's.

* crypto/keys no longer used by x/gov/client/rest/rest.go
2018-06-29 18:22:24 -04:00
Dev Ojha
47e4682d9f Merge PR #1415: x/stake: Limit the size of rationals from user input
* x/stake: Limit the size of rationals from user input

This commit sets the maximum number of decimal points that can be
passed in from messages. This is enforced on the validate basic of
MsgBeginUnbonding and MsgBeginRedelegation. The cli has been
updated to truncate the user input to the specified precision. This
also updates types/rational to return big ints for Num() and Den().

Closes #887

* Switch NewFromDecimal to error instead of truncating
2018-06-29 22:30:12 +02:00
Dev Ojha
94a3ce4c83 docs: Explain the expected return type within the store (#1452) 2018-06-29 13:45:11 -04:00
Christopher Goes
59aadf42aa
Ledger integration (#931)
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK
Adds support for Ledger into gaiacli
Cherry-picks updated error handling from #1158
2018-06-29 02:54:47 +02:00
Dev Ojha
ac3adff1e8 Merge PR #1438: Tools: Add errcheck linter
This linter ensures that all errors are checked.
This is disabled in the client directories, since its not needed on
those writes
2018-06-29 00:52:10 +02:00
Dev Ojha
3e14868bd6 Merge PR #1429: tools: Add ineffassign linter
* tools: Add ineffassign linter

This errors on assignments that don't actually do anything. i.e.

x, err := myFunc(1)
y, err = myFunc(2)

This will call out that the first function's call error was never
used.

* Fix makefile, add misspell to makefile
2018-06-28 19:12:02 +02:00
Sherry Ma
e7797835e2
Merge branch 'develop' into develop 2018-06-28 10:02:52 +08:00
Dev Ojha
6d9f07dfee tools: Add go vet as a linter (#1421)
* tools: add go vet

* tools: Add go vet as a linter
2018-06-27 20:32:06 -04:00
Rigel
50733f5c22
Merge branch 'develop' into develop 2018-06-27 19:22:48 -04:00
Rigel
6f140d7296 Merge PR #1119: Unbonding, Redelegation
* stake/fees spec updates
* staking overview.md revisions, moving files
* docs reorganization
* staking spec state revisions
* transaction stake updates
* complete staking spec update
* WIP adding unbonding/redelegation commands
* added msg types for unbonding, redelegation
* stake sub-package reorg
* working stake reorg
* modify lcd tests to not use hardcoded json strings
* add description update
* index keys
* key managment for unbonding redelegation complete
* update stake errors
* completed handleMsgCompleteUnbonding fn
* updated to use begin/complete unbonding/redelegation
* fix token shares bug
* develop docs into unbonding
* got non-tests compiling after merge develop
* working fixing tests
* PrivlegedKeeper -> PrivilegedKeeper
* tests compile
* fix some tests
* fixing tests
* remove PrivilegedKeeper
* get unbonding bug
* only rpc sig verification failed tests now
* move percent unbonding/redelegation to the CLI and out of handler logic
* remove min unbonding height
* add lcd txs
* add pool sanity checks, fix a buncha tests
* fix ante. set lcd log to debug (#1322)
* redelegation tests, adding query functionality for bonds
* add self-delegations at genesis ref #1165
* PR comments (mostly) addressed
* cleanup, added Query LCD functionality
* test cleanup/fixes
* fix governance test
* SlashValidatorSet -> ValidatorSet
* changelog
* stake lcd fix
* x/auth: fix chainID in ante
* fix lcd test
* fix lint, update lint make command for spelling
* lowercase error string
* don't expose coinkeeper in staking
* remove a few duplicate lines in changelog
* chain_id in stake lcd tests
* added transient redelegation
* 'transient' => 'transitive'
* Re-add nolint instruction
* Fix tiny linter error
2018-06-27 04:00:12 +02:00
Sunny Aggarwal
9ca3a16bb3 Merge PR #1397: Fix spelling changes
* fixed spelling changes
* extra spelling error
2018-06-27 01:58:42 +02:00
7768
4f57a765ad Merge PR 1354: CLI: Show fractional in human-readable format
Fix https://github.com/cosmos/cosmos-sdk/issues/1353

before:
```
Shares: Status Bonded,  Amount: -6508168128760126341/-3308135364330552608
Delegator Shares: -6508168128760126341/-3308135364330552608
```
after:
```
Shares: Status Bonded,  Amount: 2.0000000000
Delegator Shares: 2.0000000000
```
2018-06-26 19:26:12 +02:00
Sherry Ma
1a67dc5d7c
Changed decode delegator address function
In delegation query, the function to decode the address of delegator should be using Bech32 but not Hex
2018-06-22 18:37:15 +08:00
Joon
ec6acda6a4 Merge PR #1331: Remove TxBytes from NewContext 2018-06-22 03:03:05 +02:00