6ceedc9e4f
Remove TxBuilder references to viper. ( #6653 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
Co-authored-by: Alessio Treglia <alessio@tendermint.com >
2020-07-10 11:05:35 +02:00
Alessio Treglia
255ed06eb4
testutil: add ApplyMockIODiscardOutErr, simplify existing functions ( #6665 )
2020-07-10 08:55:48 +02:00
Alessio Treglia
a940214a49
testutil cleanup and reorg ( #6658 )
...
Prepare migrating testing auxiliary functions from tests
to testutil.
Remove local duplicates on testutil.WriteToNewTempFile().
Always favor testutil.NewTestCaseDir() over ioutil.TempDir().
Add test cases for the testing auxiliary functions.
2020-07-09 14:21:20 +02:00
4536ca22bb
x/auth: gRPC query service ( #6565 )
...
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com >
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com >
2020-07-08 13:12:38 +02:00
Alessio Treglia
57ffe14631
Makefile: build simd with ledger support ( #6629 )
...
Makefile: parse COSMOS_BUILD_OPTIONS
Look for build options in the make's COSMOS_BUILD_OPTIONS
variable. This allows one to build simd with ledger support.
References:
* https://github.com/cosmos/gaia/pull/363
* https://github.com/tendermint/tendermint/pull/4738
fix tiny typo in nolint: statement that causes golangci-lint to
misbehave.
2020-07-07 19:10:11 +02:00
Alexander Bezobchuk
8670a10564
Merge PR #6595 : Single Binary & Command Refactor
2020-07-07 11:40:46 -04:00
Jonathan Gimeno
3c76084bf5
Merge PR #6596 : Genutil remove global viper
2020-07-06 17:48:54 -04:00
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com >
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com >
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com >
Co-authored-by: anilCSE <anil@vitwit.com >
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com >
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
2020-07-06 17:03:45 +00:00
Alexander Bezobchuk
feb69770ef
Merge PR #6609 : x/auth: CLI Remove Viper
2020-07-06 10:23:32 -04:00
Alexander Bezobchuk
dacbcef54d
cl & deps++ ( #6582 )
...
* cl & deps++
* Use PersistentPreRunE
* revert x/bank/client/cli/tx.go
* move to root level
* Use block mode by default
* Skip x/auth CLI tests
2020-07-02 19:35:42 +00:00
Marko
a0f9cc7627
vesting: remove alias.go ( #6579 )
2020-07-02 15:08:44 +02:00
6a52c5a569
Remove DefaultParamspace and simplify simapp creation. ( #6564 )
...
* Remove DefaultParamspace and simplify simapp creation.
* Update changelog.
* Create function that inits ParamsKeeper.
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-01 13:57:29 +00:00
Alexander Bezobchuk
d5049413ef
Merge PR #6525 : x/bank: Refactor CLI & Tests
2020-06-30 16:59:21 -04:00
c0e48e1c43
Update ante handlers to use SignatureV2 ( #6428 )
...
* Update ante handlers to use SignatureV2
* WIP on test fixes
* WIP on test fixes
* Debugging CLI Tests
* CHANGELOG.md
* CHANGELOG
* Add missing tests for ante
* Add tests for verify signatures
* Update verify tests
* Fix register codec issue
* debug
* Cleanup
* Fix verify signature tests
* Remove viper
* remove keyring usage
* Fix review changes
* Fix simapp
* Fix ante tests
* Add reference issue
* Add test for multisignature
* Wrap sign error with sig
* Fix verify sign test
* Fix CHANGELOG.md
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com >
Co-authored-by: anilCSE <anil@vitwit.com >
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
2020-06-29 20:48:41 +00:00
74eb56dd2a
Add test suite for client TxBuilder ( #6460 )
...
* Add tests
* Fix gofmt
* typecast tests
* Fix review comments
* typecast SigVerificableTx
* cleanup
* Refactor
* Linting and move encode/decode tests to suite
* Fix lint
* Move test suite
* godoc
* Refactor
* Refactor
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com >
Co-authored-by: Aaron Craelius <aaron@regen.network >
2020-06-29 14:05:30 +00:00
712d23740f
Migrate x/auth cmd's to TxGenerator marshaling ( #6391 )
...
* Migrate encode, decode, and broadcast cmd's to use TxGenerator marshal methods
* Fix tests, add EncodingConfig
* Add simapp/encoding.go and wire up with simcli
* add godocs
* fix tests
* Debugging CLI Tests
* Fix integration test
* 6391 - lint issues and code coverage (#6414 )
* fixed lint issue of "txEncodeRespStr"
* added tests for encode.go
* WIP: added tests for decode.go
* added txEncoder at bytes
* updated decode test
* updated txBytes to use TxEncoder in decoder test
* added a require after TxEncoder
* removed file save
* debug decode command
* fixed decode tests
* added decode cli
* updated encode and decode in a single file
* separated decode test from encode test
* review changes
* removed register interface
* review change
* Fix tests
* WIP add test for tx sign
* removed commented code
* Fix flags
* WIP add test for sign
* Address review suggestions
* fixed command issue
* Add tests for TxEncoder
* Revert sign changes
* Fix TxEncoder tests
* Fix GetSign Cmd
* Add tx test
* Remove duplicate validation
* Add tests for TxDecoder
* Fix tests
* Fix tests
* Output to clientCtx.Output
* Fix cli_tests
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com >
Co-authored-by: atheesh <atheesh@vitwit.com >
Co-authored-by: anilCSE <anil@vitwit.com >
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com >
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-18 20:29:41 +00:00
Alexander Bezobchuk
5040ff87c4
Merge PR #6449 : Initial Metrics
2020-06-18 14:12:44 -04:00
4e73e0f817
Update proto files & definitions in accordance with ADR023 ( #6413 )
...
* consolidate proto files into single directory, turn on PACKAGE_DIRECTORY_MATCH linting
* add third_party root for third party proto files
* move ibc proto files to top level folder, rename .proto files to types.proto as before
* update protocgen script, and run code generation
* move vesting proto definition to cosmos namespace, rename from types.proto in alignment with buf.build naming conventions
* update Makefile so proto dependencies are set with new structure when updated
* add comment for sed usage in makefile
* remove unused aliases of proto generated types
* add settings.json instructions to contributing.md for including protobuf paths
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
Co-authored-by: Aaron Craelius <aaron@regen.network >
2020-06-18 10:04:26 -07:00
32278d9a2b
x/auth: remove alias.go usage ( #6440 )
...
* x/auth: remove alias.go usage
* Fix simd_test.go and formatting
* Fix app.go formatting
* Fix cli_test.go
* Fix lint warnings
* Undo accidental deletion during merge
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com >
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
2020-06-17 14:42:27 -04:00
Aaron Craelius and anilCSE
c13809062a
Update TxBuilder to use SignatureV2 ( #6443 )
...
* Update TxBuilder to use SignatureV2
* Fix unit tests
* Lint
* lint
* Cleanup
* Address review feedback
* Add Sign tests
* Add more cases for sign tests
* Fix lint
* Fix gofmt
* Deprecate StdTx
* Undeprecate StdTx, but leave a comment to use the protobuf Tx
* Address review comment
Co-authored-by: anilCSE <anil@vitwit.com >
2020-06-16 19:57:37 +00:00
Alexander Bezobchuk
35312d098e
JSON Codec Updates ( #6444 )
...
* Initial commit
* More updates
* Fix tests
* CLI test updates
* Updates
* Updates
2020-06-16 00:20:50 +00:00
dauTT
24b9be0ef8
x/bank: remove alias.go usage ( #6439 )
...
* x/bank: remove alias.go usage
* Fix simd_test.go
2020-06-14 23:06:16 +00:00
60f7edfe3d
Add SignatureV2 infrastructure ( #6373 )
...
* Updte tx generator
* Add sigv2, PublicKeyCodec
* revert changes
* revert changes
* updates
* Updates
* Integrate multisig support
* Undo move
* remove func
* undo
* godocs
* godocs, cleanup
* Cleanup
* godocs, tests
* lint
* Re-enable VerifyBytes
* Address comments
* Fix imports
* Update crypto/types/multisig/multisignature.go
* Add test for MultiSignatureData
* Add nested multisig case
* Add test for AddSignatureV2
* Add changelog
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com >
2020-06-12 18:13:20 +00:00
49597b19ec
module: pass route by value ( #6404 )
...
* use instance
* add some comments
* Update types/router.go
* rename Nil to Empty
* run make mocks
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
Co-authored-by: Alessio Treglia <alessio@tendermint.com >
2020-06-11 15:37:23 +00:00
Jonathan Gimeno and Federico Kunze
79c308ae4a
Concept PR simplify Module ( #6231 )
...
* add test of alternative impl
* simplify query route too
* change name querier
* simplify register routes
* revert change
* add route
* add router
* first step refactor
* refactor
* update documentation
* update
* add format
* simplify appmodule
* update changelog
* rename vars
* remove interface
* Update CHANGELOG.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
2020-06-10 18:48:16 +00:00
08b7557fe5
Add basic sign mode infrastructure ( #6371 )
...
* Add SignModeHandler and LegacyAminoJSONHandler
* Simplify, add tests
* Add godocs
* Add handler map
* Rename HandlerMap
* Don't use pointer
* Lint
* Lint
* Update x/auth/signing/amino/amino.go
Co-authored-by: Marko <marbar3778@yahoo.com >
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
Co-authored-by: Marko <marbar3778@yahoo.com >
2020-06-09 15:19:18 +00:00
Alessio Treglia
65ea305336
x/auth: add sign-batch command ( #6350 )
...
The command processes list of transactions from file
(one StdTx each line), generate signed transactions
or signatures and print their JSON encoding, delimited
by '\n'. As the signatures are generated, the command
increments the sequence number automatically.
Author: @jgimeno
Reviewed-by: @alessio
2020-06-08 17:19:29 +02:00
Marko and Federico Kunze
b618e0a827
add comments to why its nolint ( #6366 )
...
* add comments to why its nolint
* fix spelling
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
2020-06-08 13:47:18 +00:00
colin axner and mergify[bot]
71374d0eca
add contextual info to sigverify err msg ( #6355 )
...
* update sigverify error message
* whoops, use get sequence
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-06 08:05:30 +00:00
43947ca2ef
Add RegisterQueryService to AppModule ( #6336 )
...
* Add RegisterQueryService to AppModule
* Update CHANGELOG.md
* Update CHANGELOG.md
* Wire up BaseApp, fix tests
* Add mock test
* add missing file
* Update types/module/module.go
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-06 07:59:57 +00:00
Alessio Treglia
e248693ac8
x/auth/client: remove duplicate flags ( #6348 )
2020-06-05 16:14:22 +02:00
Aaron Craelius and Federico Kunze
81d647e505
Move codec.RegisterCrypto and codec.Cdc to new packages ( #6330 )
...
* Move codec.Cdc to legacy_global.Cdc
* Update CHANGELOG.md
* Updates
* nit
* Fix imports
* Updates
* Use cosmos multisig instead of tendermint multisig everywhere
* Fix tests
* Rename legacy_global -> legacy
* Add doc.go
* Linting, move all RegisterCrypto calls to crypto/codec
* Update crypto/codec/amino.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
2020-06-04 10:38:24 +00:00
Aaron Craelius and Alexander Bezobchuk
fed0c2317d
Change GetQueryCmd to take client.Context ( #6326 )
...
* Change GetQueryCmd to take a client.Context
* Update CHANGELOG
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
2020-06-03 20:15:11 +00:00
39f53ac22f
client: rename CliContext to Context ( #6290 )
...
* Refactor CliContext as Context
* Fix lint issues
* Fix goimports
* Fix gov tests
* Resolved ci-lint issues
* Add changelog
* Rename cliCtx to clientCtx
* Fix mocks and routes
* Add changelog
* Update changelog
* Apply suggestions from code review
Co-authored-by: Alessio Treglia <alessio@tendermint.com >
* merge client/rpc/ro{ot,utes}.go
* Update docs
* client/rpc: remove redundant client/rpc.RegisterRPCRoutes
* regenerate mocks
* Update ADRs
Co-authored-by: Alessio Treglia <alessio@tendermint.com >
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com >
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-01 12:46:03 +00:00
f3962eb29b
fix #6287 sending multiple transactions from an account make nonce sequence stuck ( #6291 )
...
* fix #6287 sending multiple transactions from an account make nonce sequence stuck
* add change log
* fix ante unit test after #6287 fix
* Update x/auth/ante/sigverify.go
Co-authored-by: Alessio Treglia <alessio@tendermint.com >
Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com >
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
2020-05-28 21:07:12 +00:00
dauTT
97fecb1aa2
Merge PR #6276 : Fix error msg
2020-05-23 15:29:51 -04:00
Alessio Treglia
37882fbf4a
x/auth: remove unused passphrase arguments ( #6270 )
...
The new keyring does not handle passphrases anymore.
2020-05-22 13:34:15 +00:00
Aaron Craelius and Alexander Bezobchuk
850419fffd
Tx CLI proto module interface ( #5989 )
...
* WIP
* WIP
* WIP on removing x/auth dependency from client/tx
* Revert unneeded changes
* Simplify cli tx UX
* Wire up bank tx REST routes
* Fix assignment issue
* Wire up bank NewSendTxCmd
* fix lint
* revert file
* revert file
* fix simcli
* Refactor AccountRetriever
* Fix build
* Fix build
* Fix build
* Fix integration tests
* Fix tests
* Docs, linting
* Linting
* WIP on all modules
* Implement other module new tx cmd's
* Fix cmd's
* Refactor existing GetTxCmd
* Fix cmd
* Removing deprecated code
* Update ADR 020 & CHANGELOG
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Lint
* Fix client/tx tests
* Fix mocks
* Fix tests
* Lint fixes
* REST tx migration
* Wire up REST
* Linting
* Update CHANGELOG, docs
* Fix tests
* lint
* Address review feedback
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
* group vars
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
2020-05-21 21:29:34 +00:00
SaReN and Aaron Craelius
bf8809ef98
Update x/auth to use Any ( #6165 )
...
* Migrate keeper codec to use marshaler
* Migrate AccountI to types
* Did go imports
* Fix tests for x/auth
* Cleanup std/codec
* Sort imports
* Fix legacy codec
* Add godoc for RegisterInterfaces
* Add RegisterInterfaces to std
* Fix typo
* Fixed merge changes
* Eliminate vesting import in auth
* Fix lint issues
* Fix tests
* Addressed comments
* Rename interfaces in RegisterInterfaces
* Removed codec.proto from std
* Minor code cleanup
Co-authored-by: Aaron Craelius <aaron@regen.network >
2020-05-20 19:21:00 +00:00
70767c87c4
Update x/gov to use Any ( #6147 )
...
* Update x/gov to use Any
* Fixes
* Remove MsgSubmitProposalLegacy
* Update CHANGELOG.md
* Add RegisterInterfaces for x/distribution, x/params, & x/upgrade
* Fix query JSON issue
* Fix gov tests
* Revert custom Any Equals
* Re-remove types
* Rename receivers
* Fix imports in gov
* Sort imports
* Make amino JSON signing work with Any
* Run proto-gen
* Create full amino wrapper
* Fix errors
* Fixes
* Fix tests
* Test fixes
* Fix tests
* Linting
* Update ADR 019 and CHANGELOG
* Updated ADR 019
* Extract Marshal/UnmarshalProposal
* fix error
* lint
* linting
* linting
* Update client/keys/parse.go
Co-authored-by: Marko <marbar3778@yahoo.com >
* linting
* Update docs/architecture/adr-019-protobuf-state-encoding.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
* Update docs/architecture/adr-019-protobuf-state-encoding.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
* Address review feedback
* Add godocs
* Fix errors
* fix errors
* revert file
* Address review feedback
* Address review feedback
* Stacktrace debug flag
* Fix tests
* Address review feedback
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com >
Co-authored-by: Marko <marbar3778@yahoo.com >
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
2020-05-19 20:17:29 +00:00
Marko and mergify[bot]
bef3689245
linter: enable nolintlint ( #6162 )
...
* nolintlint enable
* remove space
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-05-08 08:46:12 +00:00
54ed8d7a2c
lint: official action ( #6156 )
...
* switch from review dog to official golangci action
* fix release
* disable nolintlint and wsl
* fix linting issues
* have name adhere to required
* add timeout
Co-authored-by: Alessio Treglia <alessio@tendermint.com >
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-05-07 09:40:49 +00:00
SaReN
c211488b0b
x/auth: cli tests ( #6152 )
...
* Add cli tests for auth
* Format imports
* Fix auth tests
* Remove keys in validate sign call
* Eliminate defer in tests
* Format imports
* Test commit
2020-05-05 21:16:37 -04:00
Aaron Craelius
386217209d
Merge PR #6076 : Proto Any init + evidence
2020-05-05 10:28:20 -04:00
Alessio Treglia and Alexander Bezobchuk
2414e5bdd4
x/auth: turn sign --validate-sigantures into a standalone command ( #6108 )
...
--validate-signatures should not be a flag of the sign command
as the operation performed (transaction signatures verification)
is logically distinct.
cli_test is and has always been an horrible name for package
directory as it's very much Go anti-idiomatic - _test is the
suffix used by test packages, not directories. Plus, CLI test
cases can and should live alongside other testcases that don't
require binaries to be built beforehand. Thus:
x/module/client/cli_test/*.go -> x/module/client/cli/
Test files that require sim{cli,d} shall be tagged with // +build cli_test
With regard to cli test auxiliary functions, they should live in:
x/module/client/testutil/
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com >
2020-05-04 13:55:16 +00:00
Marko and Alessio Treglia
218ec99508
various linter fixes ( #6106 )
...
x/staking: Fix all linter warnings.
Fixed warnings across base packages.
New linters:
- unparam
- nolintlint
Co-authored-by: Alessio Treglia <alessio@tendermint.com >
2020-05-02 21:26:59 +02:00
Alessio Treglia
2879c0702c
x/ibc: fix missing return statement ( #6099 )
...
* enable the wsl linter
Fix various wsl-related warnings.
x/ibc/04-channel/keeper/handshake.go: fix missing return statement in ChanOpenTry().
* goimports -w files
* remove unknown linter references
* run make format
* Revert "run make format"
This reverts commit f810b62b9e4993f08506663d4e5f2ec2228a9863.
* run make format
2020-04-29 22:36:34 -04:00
Aaron Craelius
cc90f2e002
Merge pull request #6085 : Move codec/std to std
2020-04-27 15:40:50 -04:00
Alexander Bezobchuk
b737e7f7f9
Remove JSON marshaler for base account ( #6054 )
...
* Remove JSON marshaler for base account
* Add changelog entries
2020-04-22 14:01:20 +00:00
Federico Kunze
3ee975c57b
Merge PR #6037 : refactor simulation decoder
2020-04-21 17:33:56 -04:00
Marko
