Commit Graph
174 Commits
Author SHA1 Message Date
Julián Toledano 25aea8af8a refactor!: remove global config from x/auth and client (#19447) 2024-03-06 13:14:16 +00:00
Julien Robert b304cf7556 refactor!: kill basic manager (#19512) 2024-02-22 14:44:49 +00:00
Julien Robert 4d5b140ad2 fix: check bugs from #19224 (#19524) 2024-02-22 13:58:23 +00:00
Elias Naur 821d080a59 ci: silence bogus resleak error (#18770) 2023-12-17 08:19:53 +00:00
8f0d5b15f0 chore: typos fixes by cosmos-sdk bot (#18689)
Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2023-12-11 13:03:19 +00:00
Emmanuel T Odeke 05261cc46e refactor(x/auth): spin out go.mod (#18351) 2023-11-07 11:42:58 +00:00
Julien Robert d82503e24e refactor(x/genutil,server): add export functions to x/gentutil (#18303) 2023-10-30 15:49:49 +00:00
Marko 21e69bad04 refactor(bank): add go module (#18279) 2023-10-27 09:25:04 +00:00
Marko 2a6640d488 refactor(staking): add go.mod (#18257) 2023-10-26 07:39:34 +00:00
Marko 5987d0003a chore!: remove bank & genutil legacy migrations (#17818) 2023-09-21 10:33:14 +00:00
Julien Robert bdb7387fa9 refactor: reword upgrading.md and verify match with repo (#17262) 2023-08-07 15:53:45 +00:00
mmsqe 7a778f5c90 refactor: add MigrateHandler to allow reuse migrate genesis related function (#17296) 2023-08-07 08:12:27 +00:00
zakir c36c86005f refactor(cli): remove duplicate --home flag (#17215) 2023-08-01 09:42:32 +00:00
zakir-codeandJulien Robert 0b5e7ed0af refactor: hide --output flags that don't work (#17188)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-07-29 23:53:27 +00:00
58855c6859 refactor: remove global valaddress bech32 codec calls (1/2) (#17098)
Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-07-26 19:01:21 +00:00
ruthishvitwit fd7e549a3c chore: enable errcheck linter (#16406) 2023-07-12 08:58:27 +00:00
Jacob Gadikian 6afece635c style: add gci linter (#16605) 2023-06-22 15:35:51 +00:00
99a570a7aa chore: properly propagate fmt.Errorf errors + use errors.New (#16537)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2023-06-22 09:50:07 +00:00
Emmanuel T Odeke f5a596c88b chore: finish removing all exported *SortJSON usages (#16497) 2023-06-12 12:10:36 +00:00
Matt Kocubinski e169374eb4 refactor: remove dependencies x/auth -> x/genutil, x/gov (#16423) 2023-06-06 15:31:25 +00:00
Devon Bearandmarbar3778 95178ce036 feat(genutil): Add module account at genesis. (#16046)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
2023-06-03 14:35:50 +00:00
Julien Robert cf1a573679 chore: set correct eden version number (#16281) 2023-05-24 19:58:45 +00:00
6cee22df52 feat!: Comet v0.38 Integration (#15519)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-05-24 16:09:19 +00:00
Julien Robert 16e940df55 chore: rename comet logger wrapper (#15983) 2023-04-28 14:36:09 +00:00
Julien Robert c0eade17fe test: fix module cli tests (#15882) 2023-04-19 14:24:07 +00:00
samricotta e2c91fc1d7 refactor(genutil,group,mint): remove aliases from types/math.go (#15824)
## Description

Closes part of: https://github.com/cosmos/cosmos-sdk/issues/14405



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

* [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] added `!` to the type prefix if API or client breaking change
* [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] provided a link to the relevant issue or specification
* [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
* [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
* [ ] added a changelog entry to `CHANGELOG.md`
* [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] updated the relevant documentation or specification
* [ ] reviewed "Files changed" and left comments if necessary
* [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] confirmed all author checklist items have been addressed 
* [ ] reviewed state machine logic
* [ ] reviewed API design and naming
* [ ] reviewed documentation is accurate
* [ ] reviewed tests and test coverage
* [ ] manually tested (if applicable)
2023-04-13 12:34:47 +00:00
Julien Robert df161c214c feat: optional validate basic (#15735) 2023-04-07 13:13:15 +00:00
Julien Robert d0d1f5c056 feat: improve genesis migration command (#15679)
## Description

Closes: https://github.com/cosmos/cosmos-sdk/issues/5041
ref: https://github.com/cosmos/gaia/issues/1950#issuecomment-1400097306

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

* [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] added `!` to the type prefix if API or client breaking change
* [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] provided a link to the relevant issue or specification
* [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
* [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
* [ ] added a changelog entry to `CHANGELOG.md`
* [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] updated the relevant documentation or specification
* [ ] reviewed "Files changed" and left comments if necessary
* [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] confirmed all author checklist items have been addressed 
* [ ] reviewed state machine logic
* [ ] reviewed API design and naming
* [ ] reviewed documentation is accurate
* [ ] reviewed tests and test coverage
* [ ] manually tested (if applicable)
2023-04-04 17:31:42 +00:00
Julien Robert c1974e4b3c refactor: remove cometbft/libs/cli import (#15673) 2023-04-03 14:48:02 +00:00
Julien Robert 5d559dd265 feat!: use cosmossdk.io/log logger (#15011) 2023-02-27 21:36:22 +00:00
Till Ziegler b53be683b6 feat: add --initial-height flag to cli init cmd (#15147) 2023-02-24 15:26:40 +01:00
Jayden Lee c71d19939b fix: change the behavior of offline mode correctly (#15123)
## Description
Closes: #15109 

Change to work only when `FlagAccountNumber` and `FlagSequence` are in offline mode. In other cases, use `AccountRetriever` to populate those values.



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2023-02-23 10:03:20 +00:00
Julien Robert 832517befc feat: add application genesis (#15031) 2023-02-22 10:29:03 +00:00
Julien Robert 067ee92d4d refactor: simply errors (#15067) 2023-02-20 12:03:40 +00:00
Facundo Medica 4a6a1e3cb8 refactor: fix lint issues + gofumpt (#15062) 2023-02-19 10:31:49 +00:00
Marko 2b484a241f feat: add rand funcs to math (#15043) 2023-02-18 18:39:46 +00:00
Julien Robert c17c3caab8 refactor: rename commands to match consensus engine name (#14956) 2023-02-08 20:09:28 +00:00
Marko 281017ae90 refactor: use cosmos-sdk/log throughout (#14909)
## Description

removes the dependency of tendermint/utils/log from countless locations. This is in effort of reducing Tendermint's lib usage in the sdk 

this is nonbreaking as the interface is the same. To eliminate tm/utils/log in the sdk we need a few more things. Once we have fully removed the tendermint logger, I would propose we break the interface and define our own for our use case, when we pass the logger to tendermint in the node.New() function we can wrap our logger for its use case 

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2023-02-07 10:54:48 +00:00
Julien Robert 80dd55f79b refactor: rename to CometBFT (#14914) 2023-02-06 18:11:14 +00:00
Facundo MedicaandMarko 5e57be076e test: use a queue of open ports for tests (#14893)
Co-authored-by: Marko <marbar3778@yahoo.com>
2023-02-06 13:29:18 +00:00
Julien Robert 41a3dfeced refactor!: migrate Cosmos SDK to CometBFT (#14897) 2023-02-05 14:51:33 +01:00
Marko 3684966676 chore: remove unused code from server (#14437) 2022-12-27 23:46:12 +00:00
Ruslan Akhtariev ecb4ca2a82 feat(simapp): move genesis related commands under one genesis command (#14149) 2022-12-07 12:17:19 +00:00
Julien Robert 08be7ee74b refactor: extract MockTendermintRPC to testutil/cli 2022-11-03 22:40:52 +00:00
Julien Robert 89c65f4d58 feat: overwrite default denom in init cmd (#13535)
* feat: overwrite default denom in `init` cmd

* add changelog

* wording

* `make format`

* update comment
2022-10-13 18:24:28 +02:00
Jacob Gadikian af816057f2 chore: run make format (#13375) 2022-09-24 00:22:03 +02:00
Julien Robert df40c0a9d1 refactor!: remove broadcast mode block (#12659) 2022-09-23 15:16:31 +00:00
Emmanuel T Odeke 9c2aef342d chore: all: use golang.org/x/exp/maps.(Keys, Values) where necessary (#13349)
Uses golang.org/x/exp/maps.(Keys, Values) to sort out flagged
potential non-determinism issues due to map iteration which is
randomized in maps.

These were flagged by cosmos/gosec in

* https://github.com/cosmos/cosmos-sdk/security/code-scanning/724
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/725
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/726
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/727
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/728
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/729
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/782
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/813
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/814
* https://github.com/cosmos/cosmos-sdk/security/code-scanning/816

which complained about potential non-determinism in
map iteration in which we only want appends in map iteration loops,
this change instead uses golang.org/x/exp/maps.Keys to retrieve
the keys then sort.Strings which simplifies the helper code.

This change fixes issues in:
* orm/model/ormdb: non-determinism in ExportJSON
* store/internal/proofs
* types/module
* x/auth/keeper
* x/bank
* x/genutil/client/cli

Fixes #13348
2022-09-21 02:08:13 +00:00
7ebbfa0b30 refactor(nft): CLI tests using Tendermint Mock (#13256)
* wip: move nft cli tests to e2e tests

* wip: add cli tests using Tendermint Mock

* cleanup genutil test file

* remove unncessary test cases

* address review comments

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2022-09-19 13:01:49 +00:00
likhita-809andMarko 97a77a47dc refactor(genutil): CLI tests using Tendermint Mock (#13190)
* wip

* wip

* wip: add more tests

* refactor tests

* add expCmdOutput field to tests struct

* remove unnecessary code

Co-authored-by: Marko <marbar3778@yahoo.com>
2022-09-12 15:27:32 +00:00