Commit Graph
299 Commits
Author SHA1 Message Date
e76102f885 refactor: migrate away from using valBech32 globals (2/2) (backport #17157) (#17379)
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-08-14 17:06:56 +02:00
46be66ed42 refactor: remove global valaddress bech32 codec calls (1/2) (backport #17098) (#17149)
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-07-27 00:55:11 +02:00
16ab635645 refactor(staking): use validator & address codecs in staking (backport #16958) (#17066)
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-07-19 16:02:28 +02:00
mergify[bot]andJulien Robert d9c53bfefc refactor!: remove types/math aliases (backport #16798) (#16803)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-06-30 19:56:38 +02:00
mergify[bot]andJulien Robert 9f4a4e416f build(deps): use hashicorp/go-metrics instead of armon/go-metrics (backport #16790) (#16800)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-06-30 15:27:05 +00:00
950b910030 refactor(x/distribution): audit changes (backport #16785) (#16799)
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-06-30 14:51:43 +00:00
Julien RobertandJacob Gadikian c452721442 style: add gci linter (#16758)
Co-authored-by: Jacob Gadikian <faddat@users.noreply.github.com>
2023-06-29 09:46:37 +00:00
9f7a16080a refactor(x/staking)!: KVStoreService, return errors and use context.Context (backport #16324) (#16598)
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Facundo Medica <facundomedica@gmail.com>
2023-06-19 11:40:27 -03:00
testinginprodandunknown unknown f851e188b3 refactor(distribution)!: make FeePool state use collections (#16302)
Co-authored-by: unknown unknown <unknown@unknown>
2023-05-26 09:51:37 +00:00
6cee22df52 feat!: Comet v0.38 Integration (#15519)
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-05-24 16:09:19 +00:00
samricotta 2843261161 refactor(distribution)!: use collections for params state (#16211) 2023-05-22 19:51:24 +00:00
Marko c8ab555174 refactor(bech32): remove embedding of addresscodec (#16197) 2023-05-22 10:20:45 +00:00
MarkoandJulien Robert 044fe13789 refactor(math)!: remove aliases in math (#16040)
Co-authored-by: Julien Robert <julien@rbrt.fr>
2023-05-07 17:25:59 +00:00
Facundo Medica 428e19f4f0 refactor(x/distribution)!: Use KVStoreService, context.Context and return errors instead of panic (#15948) 2023-04-27 13:26:51 +00:00
Likhita PolavarapuandMarko 495ef01f71 test(x/distribution): write integration tests (#15569)
Co-authored-by: Marko <marbar3778@yahoo.com>
2023-04-13 10:05:59 +00:00
Julien Robert e4dbf1b7b4 refactor(auth,vesting): move ValidateBasic logic to msgServer (#15786) 2023-04-12 14:37:06 +00:00
Julien Robert ee53930fc1 refactor(distribution): move ValidateBasic logic to msgServer (#15755) 2023-04-11 08:11:52 +00:00
Marko 90e2a2ae89 style: linting (#15704)
## Description

closing in on completion of linting

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

* [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] added `!` to the type prefix if API or client breaking change
* [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] provided a link to the relevant issue or specification
* [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
* [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
* [ ] added a changelog entry to `CHANGELOG.md`
* [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] updated the relevant documentation or specification
* [ ] reviewed "Files changed" and left comments if necessary
* [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] confirmed all author checklist items have been addressed 
* [ ] reviewed state machine logic
* [ ] reviewed API design and naming
* [ ] reviewed documentation is accurate
* [ ] reviewed tests and test coverage
* [ ] manually tested (if applicable)
2023-04-06 23:25:23 +00:00
Marko e2a8f7ca32 refactor(distribution): remove global bech32 (#15684)
## Description

ref #13140 

remove global bech32 in distribution

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

* [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] added `!` to the type prefix if API or client breaking change
* [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
* [ ] provided a link to the relevant issue or specification
* [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
* [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
* [ ] added a changelog entry to `CHANGELOG.md`
* [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
* [ ] updated the relevant documentation or specification
* [ ] reviewed "Files changed" and left comments if necessary
* [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
* [ ] confirmed `!` in the type prefix if API or client breaking change
* [ ] confirmed all author checklist items have been addressed 
* [ ] reviewed state machine logic
* [ ] reviewed API design and naming
* [ ] reviewed documentation is accurate
* [ ] reviewed tests and test coverage
* [ ] manually tested (if applicable)
2023-04-05 14:14:51 +00:00
samricotta 81d3b186be refactor: remove aliases from types/math.go in crisis and distribution (#15674) 2023-04-05 11:19:22 +00:00
Marko 51f3e70a12 style: more linting (#15618) 2023-03-30 13:00:18 +00:00
Jacob Gadikian 37ba88872d style: enable strict gofumpt (#15579) 2023-03-28 18:59:21 +00:00
Marko 176c61cf70 feat: add delegator to withdraw address (#15462) 2023-03-20 14:43:07 +00:00
Puneet bf85bfbf4d refactor: Rename clientCtx to ctx in distr params.go (#15453) 2023-03-19 13:22:41 +00:00
Facundo Medica 4a6a1e3cb8 refactor: fix lint issues + gofumpt (#15062) 2023-02-19 10:31:49 +00:00
Julien Robert a7ac29e3f4 chore: rename log pkg and add zerolog (#14955) 2023-02-08 11:32:22 +00:00
Marko 281017ae90 refactor: use cosmos-sdk/log throughout (#14909)
## Description

removes the dependency of tendermint/utils/log from countless locations. This is in effort of reducing Tendermint's lib usage in the sdk 

this is nonbreaking as the interface is the same. To eliminate tm/utils/log in the sdk we need a few more things. Once we have fully removed the tendermint logger, I would propose we break the interface and define our own for our use case, when we pass the logger to tendermint in the node.New() function we can wrap our logger for its use case 

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2023-02-07 10:54:48 +00:00
Julien Robert 80dd55f79b refactor: rename to CometBFT (#14914) 2023-02-06 18:11:14 +00:00
Julien Robert 41a3dfeced refactor!: migrate Cosmos SDK to CometBFT (#14897) 2023-02-05 14:51:33 +01:00
Likhita PolavarapuandMarko 7559d9ecd3 refactor: create go.mod for store (#14746)
Co-authored-by: Marko <marbar3778@yahoo.com>
2023-01-25 13:31:56 +00:00
Emil Georgiev e9fbb01f3a fix: replace IsEqual with Equal (#14739)
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: Marko <marbar3778@yahoo.com>
Closes https://github.com/cosmos/cosmos-sdk/issues/3246
2023-01-24 09:50:34 +00:00
Noel Ukwa c822836501 refactor: migrate calls from alias file to appropriate store/types (#14455)
Co-authored-by: Marko <marbar3778@yahoo.com>
Closes https://github.com/cosmos/cosmos-sdk/issues/14406
2023-01-10 15:31:06 +00:00
Likhita Polavarapu 36069956e3 refactor: Move x/auth's AccountI and ModuleAccountI interfaces to types package (#13937) 2023-01-03 11:25:09 +01:00
Julien Robert bca18ba2ea fix(distribution): correct default for deprecated distribution params (#14462) 2023-01-02 17:54:49 +00:00
Aleksandr Bezobchuk 11f1e8d74c feat!: deposit to validator rewards pool (#14322) 2022-12-20 15:49:18 +00:00
Jacob Gadikian be8c5a09c2 chore: lint tests (#14268) 2022-12-18 23:48:31 +00:00
Julien Robert 7efeb826e0 refactor: rename migrations from v42, v43, v{SDK} to v1, v2, v{Consensus} (#13772)
* chore: rename migrations from v42, v43 to v1, v2

* group migration should be in #13742

* updates
2022-11-07 11:32:56 +01:00
Julien Robert 3c9b244f62 refactor: automate EventTypeMessage inclusion in every message execution (#13532) 2022-10-16 19:00:34 -04:00
Aleksandr Bezobchuk 7781cdb3d2 refactor: Improve AllocateTokens #13524 2022-10-12 22:03:45 +02:00
MarkoandJulien Robert 84675a6bf1 feat!: IS rebase (#13122)
* feat: IS rebase (squash da53124..b45dd5f)

* clean up docs

* fix: fix IS tests (#13420)

* revert key update

* add hook error handling

* impl feedback

* add changelog

* implements style nits
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* more nits

* fix tests
Co-authored-by: Simon <sainoe@users.noreply.github.com>

* add godoc

* add godoc

Co-authored-by: Julien Robert <julien@rbrt.fr>
2022-10-09 12:21:20 +02:00
Julien Robert 53519ea5b3 refactor: simplify hooks implementation (#13396) 2022-09-27 20:37:26 +02:00
Aleksandr Bezobchuk c1c23a75d9 fix: ensure withdraw_rewards events are always emitted on reward withdrawal (#13323) 2022-09-20 10:23:21 +00:00
Julien Robert 6d0ef15b0a refactor: migrate to cosmos/gogoproto (#13070) 2022-09-08 17:27:48 +00:00
Sai Kumar 65fff07a34 feat(cli/api): add validator distribution info grpc gateway get endpoint (#13144) 2022-09-05 15:01:01 +00:00
Facundo MedicaandMarko 797bd12af5 refactor!: Remove sdk.Router and refactor baseapp tests (#13005)
* test

* progress-ish

* progress

* progress

* make mocks

* progress

* test

* progress

* progress

* progress

* progress

* progress

* progress

* fix mock tests

* progress

* pretty much done, might need some tidying up

* lint

* re-enable blockgas test

* remove router

* gofumpt

* remove more references of Router

* fix

* remove unused code

* remove unused code

Co-authored-by: Marko <marbar3778@yahoo.com>
2022-08-30 23:50:47 +02:00
Facundo MedicaandMarko 0024a0bf44 refactor: use mocks for x/distribution (#12889)
* initial commit

* add mocks

* TestAllocateTokensToManyValidators

* one file more in, like a hundred left

* progress

* progress

* move tests to integration

* finally got TestCalculateRewardsMultiDelegator right lol

* small fixes

* progress

* progress

* progress

* progress

* revert test panic

* progress

* progress

* more progress

* fix go.mod

* merge

* merge

* cache issue?

* fix go.sum

* fix tests

* make mocks

* move back simulations

Co-authored-by: Marko <marbar3778@yahoo.com>
2022-08-29 20:15:51 -03:00
Aleksandr Bezobchuk 9cec22d861 refactor!: Refactor CommunityPoolSpendProposal (#12852) 2022-08-22 16:09:22 -04:00
Aleksandr Bezobchuk eef086f770 refactor!: Remove proposer-based rewards (#12876) 2022-08-16 08:53:00 -04:00
JooHyung KimandAleksandr Bezobchuk 5f9e7e6ea6 refactor: x/distr module create querier (#12829)
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
2022-08-05 17:17:24 +02:00
Jacob Gadikian cb31043d35 chore: math lib update and type fixes (#12791)
## Description

Upgrades the math library in the repo root and find/replaces many usages of sdk.Dec, sdk.ZeroDec, sdk.OneDec, sdk.NewDec with their legacy-ified-math-lib replacements.

Note for review: I assume that I did not find 100% of usages

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2022-08-02 11:16:40 +00:00