LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity
7,621 Commits 6 Branches 5 Tags 288 MiB
039036f1cd
Commit Graph

71 Commits

Author SHA1 Message Date
Jun Kimura
039036f1cd
add Increment method to Height interface (#8157) 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
 2020-12-15 12:26:43 +00:00
Robert Zaremba
a3ae6e3704
Combine client.ReadTxCommandFlags with GetClientContextFromCmd (#8155) 
* Update codebase to simplify clientCtx loading from cmd

* make ReadTxCommandFlags and ReadQueryCommandFlags private

* fix build error

* fix conflicts
 2020-12-14 22:09:51 +00:00
Robert Zaremba
fe41718047
Robert/api clientctx (#8107) 
* rename clientCtx.PrintOutput to PrintObject

* rename clientCtx.PrintOutputLegacy to PrintObjectLegacy

* Changelog update

* Rename PrintObject to PrintProto
 2020-12-08 20:17:40 +00:00
Robert Zaremba
b219c54c2d
Move and update codec.MarshalAny functions to codec.Marshaler interface (#8080) 
* Changelog update

* Rename codec.MarshalAny

* move codec.MarshalInterface to codec.Marshaler

* fix tests

* Update amino_codec for compliance with MarshalerInterface

* update tests and comments

* add tests

* change order of args in UnmarshalInterface to a canonical one

* uplift MarshalInterface to take ProtoMessage as an argument

* wip

* add nil check

* make tests working

* tests cleanup

* add support for *JSON methods

* Update changelog

* linter fixes

* fix test types

* update evidence genesis_test

* adding test

* review updates

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-12-08 09:27:08 +00:00
Emmanuel T Odeke
291d966fe9
x/ibc/core/23-commitment/types: fix MerkleProof.Empty comparisons (#8092) 
* x/ibc/core/23-commitment/types: fix MerkleProof.Empty comparisons

Fixes invalid pointer creation, reduces on unnecessary allocations
inside MerkleProof.Empty, and changes the method to a pointer; the
invalid pointer creation was symptomatic of broad use of values.

With this change we have improvements whose benchmarks produce:

```shell
name     old time/op    new time/op    delta
Empty-8     311ns ± 5%     232ns ± 5%  -25.49%  (p=0.000 n=20+19)

name     old alloc/op   new alloc/op   delta
Empty-8     56.0B ± 0%      8.0B ± 0%  -85.71%  (p=0.000 n=20+20)

name     old allocs/op  new allocs/op  delta
Empty-8      3.00 ± 0%      1.00 ± 0%  -66.67%  (p=0.000 n=20+20)
```

Fixes #8091

* Move Empty godoc to right place + add comments for blank*
 2020-12-07 20:57:15 +00:00
Aditya
971d253214
Implement Connection-specified delay (#8069) 
* start with initialization and metadata

* start by fixing delay period during connection handshake

* fix connection handshake tests

* add delay period logic to packet verification

* proto format

* fix err issue

* appease linter

* document upgrade special case

* Update x/ibc/light-clients/07-tendermint/types/client_state.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update x/ibc/light-clients/07-tendermint/types/store.go

* add sanity check

* fix build

* fix tests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
 2020-12-07 12:13:06 +00:00
colin axnér
c8a9da1d27
increase ibc basic genesis validation (#8081) 
* increase client basic genesis validation

* add connection/channel genesis validation

* fix tests

* apply @AdityaSripal suggestion

Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
 2020-12-05 21:10:15 +00:00
Anil Kumar Kammari
4a233b8dcf
Rename GRPCRouter (#8079) 
* rename GRPCRouter

* Update store/types/store.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Fix gofmt

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
 2020-12-04 15:06:50 +00:00
Aleksandr Bezobchuk
5291a8ff31
Refactor Logging using Zerolog (#8072) 
* init commit

* server: use flags

* server: godoc++

* updates

* baseapp: update logging

* logging updates

* x/bank: update logging

* logging updates

* lint++

* logging updates

* logging updates

* logging updates

* logging updates

* cl++
 2020-12-03 23:17:21 +00:00
colin axnér
bcb3240d06
Use generated client identifiers (#8034) 
* add client identifier generation

* update proto and start fixing tests

* fix ibc tests

* fix auth rest test

* update spec

* fix lint

* add parsing tests and fix bugs

* fix regexp

* add godoc

* address @AdityaSripal review suggestions for identifier parsing

* address rest of @AdityaSripal's review comments

* remove unnecessary comment

* typos

* fix lint

* Apply suggestions from code review

Co-authored-by: Aditya <adityasripal@gmail.com>

* add more heigh tests as per @AdityaSripal suggestion

Co-authored-by: Aditya <adityasripal@gmail.com>
 2020-11-30 15:52:45 +00:00
Aditya
c15884a204
Rename Version to Revision in IBC Height (#8020) 
* rename Version to Revision in ibc Height

* lint

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-24 15:38:24 +00:00
colin axnér
88e03e4f40
Deterministic connection and channel identifiers (#7993) 
* add generate identifier functions for connection and channel

* update proto types and begin open init changes

remove unnecessary field from open init msgs. Update connectionopeninit handshake, begin updating channel handshake

* finish connection handshake chanes and some channel handshake changes

Finish updating connection handshake changes, update genesis for connection and channel, some channel handshake changes, fix build for tests but still failing

* finish channel handshake changes

* fix more tests

* fix connection handshake tests

* fix more tests

* fix build

* changes from self review

* address @fedekunze review suggestions

* update spec

* fix build

* fix tests

* Update x/ibc/testing/chain.go

Co-authored-by: Aditya <adityasripal@gmail.com>

* Update x/ibc/core/03-connection/types/msgs.go

Co-authored-by: Aditya <adityasripal@gmail.com>

* address @AdityaSripal comments

* reflect spec changes

* address @AdityaSripal review suggestions

* nit

* add connection/channel identifier parsing and validation as per @AdityaSripal suggestion, cc @fedekunze

* Fix auth rest test

Change dummy channel id to a valid channel id given the updated stricter channel identifier checks cc @amaurymartiny

Co-authored-by: Aditya <adityasripal@gmail.com>
 2020-11-24 15:28:20 +00:00
Aditya
53294f5269
check clients against params and consensus against clients (#8016) 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
 2020-11-24 12:27:35 +00:00
Aditya
def3c5ba71
Add ConsensusState to IBC Upgrades (#7919) 
* upgrade progress

* fix build minus cli

* write state at block before upgrade height

* refix build

* Apply suggestions from code review

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* fix upgrade and start with tests

* fix tendermint tests

* add tests and remove unnecessary relayer options on upgradedClient

* fix all tests except weird msg panic

* add invalid final client test and codec stuff

* fix everything but msg issue

* remove problematic test for now

* safer self validation

* upgrade fixes

* proto-linting

* remove unnecessary last height

* add timestamp to committed upgrade consensus state

* address final nits

* address nit

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
 2020-11-24 11:45:33 +00:00
Federico Kunze
87315a6aab
ibc: commit packet and hash (#7808) 
* ibc: commit packet and hash

* minor changes

* fix build

* update err msgs

* don't use Any

* update commitment hash to used fixed length preimage

The commitment hash will now use 8 bytes timeout timestamp + 8 bytes timeout height version number + 8 bytes timeout height version height + sha 256 hash of data

* remove error from CommitPacket return values

* update godoc

* rm proto-tools-stamp

Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-18 19:01:22 +00:00
colin axnér
a7435d03eb
fix validate basic check (#7962) 
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
 2020-11-17 15:18:16 +00:00
colin axnér
715933b5f3
reduce redundancy (#7959) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-17 15:01:34 +00:00
colin axnér
0647d897f5
add is frozen client state check to send packet (#7957) 
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
 2020-11-17 12:55:33 +00:00
colin axnér
e93b18e60e
self height uses GTE in self client check (#7945) 
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-17 11:40:12 +00:00
Jun Kimura
f962f3a28c
Fix int64 overflow error for height comparison (#7944) 
* fix int64 overflow for height comparison

* apply suggestions from review

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
 2020-11-17 10:42:06 +00:00
colin axnér
be10bcb163
counterParty -> counterparty (#7946) 
* nit

* fix spec and docs
 2020-11-16 15:06:55 +00:00
colin axnér
cd29fd642a
Fix connection path validation and remove unused PathValidator function (#7930) 
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-16 09:30:57 +00:00
colin axnér
ddc777cf6f
remove chainid from ibc tm misbehaviour (#7932) 
* remove chainid from misbehaviour

* update err msg

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-13 14:16:51 +00:00
Federico Kunze
e77c9506c8
ibc: packet fixes (#7810) 
* ibc: msg validation fields

* msg tests

* rename proof

* rename proofs

* check seq ≠ 0

Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
 2020-11-13 13:58:13 +00:00
Ethan Buchman
15103b63a1
x/ibc/24-host: fix some comments (#7923) 
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-13 10:33:33 +00:00
colin axnér
c8afb2cbe7
Remove consensus params from IBC tm client (#7891) 
* remove consensus params

* fix build

* fix build

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-12 10:08:04 +00:00
colin axnér
e9f19225a9
IBC Upgrades function interface return client/consensus (#7895) 
* return client and consensus state on upgrades

* fix build
 2020-11-11 18:06:37 +00:00
Federico Kunze
136f3ade88
ibc: client params allowlist (#7855) 
* ibc: client params allowlist

* genesis and gRPC

* client

* lint

* spec

* fixes

* validate localhost client

* move client types back to exported

* update genesis

* sort clients by id
 2020-11-11 11:07:29 +00:00
Federico Kunze
bcdd6ee15c
ibc: fix grpc gateway routes (#7881) 2020-11-10 17:50:53 +00:00
colin axnér
300b7393ad
Update IBC host keys + cleanup (#7873) 
* init changes

* cleanup keys and remove redunancdy

* revert unintentional changes

* KeyChannel -> ChannelKey
 2020-11-10 17:05:21 +00:00
Aditya
fdcb028636
ibc: proof fixes (#7869) 
* change proof proto def

* progress fixing tests

* complete proof restructure

* remove use of KeyPath

* improve error msgs

* docs and lint

* Apply suggestions from code review

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* address code review

* fix string tests

* add ConvertProofs tests

* Apply suggestions from code review

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
 2020-11-10 15:39:09 +01:00
Marie Gauthier
90e9370bd8
Replace tmcrypto.PubKey by our own cryptotypes.PubKey (#7419) 
* WIP on removing tm pub/privkey

* Fix part of crypto tests

* Add PrivKeyLedgerSecp256K1 proto type

* Use BasePrivKey for ledger priv key type

* Refacto continued

* First round

* x/staking

* Continue porting

* x/* done

* Make build pass

* More conversion

* Remove IntoTmPubKey

* Fix test

* Remove crypto.PubKey in some other places

* Revert ledger changes

* Fix comment

* Remove useless function

* Add To/FromTmPublicKey

* Add migrate tests

* Fix test

* Fix another test

* Rename tm conversion functions

* Less code

* Rename BasePrivKey to LedgerPrivKey

* Add changelog

* Rename functions

Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
 2020-11-09 16:01:43 +00:00
Federico Kunze
70fa17b55a
ibc: spec overview (#7853) 2020-11-09 12:44:20 +01:00
Aditya
03a46181c6
Merge Packet Functions (#7813) 
* start implementation and debugging tests

* fix some issues, continue debugging

* fix IBC tests

* remove print statement and fix docs

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-05 14:07:15 +00:00
Federico Kunze
97963c71df
ibc: remove GetClientConsensusStateLTE (#7812) 2020-11-05 14:46:00 +01:00
Aditya
432afb274b
ibc: minor fixes from audit (#7807) 2020-11-04 13:16:20 +01:00
Aditya
30efa5ab16
Host Key changes (#7783) 
* change host keys on sequences

* fix prefix names

Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-03 14:35:54 +00:00
Federico Kunze
72ab03b3ef
ibc: validate signer address (#7781) 
* ibc: validate signer address

* comment

* validate channel handshakes and transfer signers
 2020-11-03 10:07:32 +00:00
Aditya
6559e19764
Remove BatchProofs implementation (#7784) 
* remove batch proofs

* Apply suggestions from code review

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
 2020-11-03 09:37:55 +00:00
Federico Kunze
4420fe2d52
ibc: remove root from verification funcs (#7780) 
* ibc: remove root from verification funcs

* fix VerifyClientConsensusState

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-11-02 17:16:22 +00:00
Aditya
e9801edb99
Async Ack Fixes (#7735) 
* Add function to query ack proofs

* fix bugs

* fix swagger

* fix final queries

* docs and add test case

* Rename QueryUnrelayedAcks to more accurate QueryUnreceivedAcks

* Apply suggestions from code review

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* address rest of reviews

* consistent spelling

Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
 2020-11-02 15:13:48 +00:00
Jack Zampolin
b2bc32f3c9
Add function to query ack proofs (#7732) 
* Add function to query ack proofs

* Fix compilation issue

Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-10-29 22:19:01 +00:00
colin axnér
1a15713289
remove proof path from IBC queries (#7725) 
* remove proof path

* make proto-all with old install

* fix build
 2020-10-29 12:42:12 +00:00
Amaury Martiny
82f15f306e
RegisterInterfaces registers service Msg type_urls (#7671) 
* Add RegisterMsgServiceDesc

* Refactor newSendTxMsgServiceCmd

* Add test

* Register in all modules

* Remove RegisterMsgServiceDesc from baseapp

* Add explicit error message

* Add comment

* Update comment

* Add test

* Update comment

* Remove duplicate import

* Fix lint

* Forgot vesting

* Fix lint

* Fix test

* Put in types/module

* Put in types/msgservice

* Add comment about panic

* Update baseapp/msg_service_router.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update baseapp/msg_service_router.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Update baseapp/msg_service_router.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* Add comment

* Add better test

* Update baseapp/msg_service_router.go

Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-10-28 19:20:45 +00:00
Federico Kunze
1b0d6540d8
ibc: internal audit part 1 (#7704) 
* ibc: internal audit part 1

* Update x/ibc/core/02-client/keeper/client.go

* gofmt

* fix tests

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
 2020-10-28 15:57:48 +00:00
Anil Kumar Kammari
51ac6f876b
Rename RegisterGRPCRoutes (#7696) 
* Rename

* Fix missing

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-10-28 11:39:49 +00:00
Federico Kunze
426d195387
ibc: Connection Version changed from string to proto definition (#7644) 
* ibc: Version to proto Any

* change version string to struct

* various version fixes

* fix build

* reorder code

* update spec

* rename to ProtoVersionsToExported and ExportedVersionsToProto

Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-10-28 09:41:54 +00:00
colin axnér
e306a852ff
update core IBC docs (#7560) 
* update state

* add empty concept fields, update callbacks and messages

* update client creation, update and upgrade section

* add packet lifecycle concepts

* add host and proof section

* add connection handshake section

* add channel handshakes

* state transitions

* self review fixes

* Apply suggestions from code review

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* apply @fedekunze review suggestions

* packet data section

* Apply suggestions from code review

Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>

* add @cwgoes and @fedekunze review suggestions

* fix typos

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-10-27 14:51:47 +00:00
colin axnér
3d46c672f6
Fix Optimistic Channel Handshake bugs (#7678) 
* fix optimistic handshake bugs and add crossing hello test

* fix tests

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-10-27 14:34:25 +00:00
Federico Kunze
7ccd2675d7
ibc: refactor proto files (#7689) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2020-10-27 14:14:07 +00:00